From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C1074369C; Thu, 7 Dec 2023 15:35:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1B0A042ECC; Thu, 7 Dec 2023 15:35:50 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2041.outbound.protection.outlook.com [40.107.243.41]) by mails.dpdk.org (Postfix) with ESMTP id 9287442E2D; Thu, 7 Dec 2023 15:35:48 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P5ldMUIx2rqKrPgYe3qMB3uF1xAUkNlXu/hCf3p/jwKLyR/ySR2TiLS0N1AGFwwcj4+OC3TeGKrI0qAmOH04ylyYLUoGgwuhZvCo8nbMsO8oO2Gwqyxdt1AZthk/7lH6+RYKShw2KAJ34UyoeSFN6adWQFim32oiKafiVwGSZaWtjc5I/FdjZr2AhTIsfs4Xe2MPD7WyXgluCMMSjKqSyr2OsZjew+TLrviWVCkfWABN5tW9UWb5U/VWY7gsawK0H3HHE62gBp/v8V091L5uFnv1DvyJboPIpxxUkCyxsMhy6+J0c+S1FUYsHS2tdHAH89o18H8nOALs0DpUFLPsDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+3+pg6HmeG86SAz6/t5ERO8OLBFW0TqBLrWeWSpeJoo=; b=GSl6CU7F3E7s8Ya3IumL9slc+kaeManoHP7YVezZdpB+ZGum8LL2LVqmStqj1WZB3o8ClW71NDAo0WBMxKx8OEbx/ZR1cIJGCGXb/PVpfTRexf2XLcxC9244HULokxzmlgi50A8Rkps1mqUojxikml/7X16Jm8btpQAOgd32sD+R5Od6StWvJxa6eGc7VXY+9VnVf31+0Kl800bJ89NNQ331eTuF4GFKoP5ktf3mynyMBo96rLv66LX0ZBm2zam2sB9eSuXW4JI3O8L99uf4VUeHJ5ufcgHAiXT8kXWSYLQ+mlKs/pIAESsFpAGzy0+Px4f+j3NPpDFiDVKAxmGrOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+3+pg6HmeG86SAz6/t5ERO8OLBFW0TqBLrWeWSpeJoo=; b=p6ArijijCtcgjPf1VrtUeJbG6L7yMJfmrtLTTZiqrmS7xtPIGAE8SvNoA2NlLcSEi6E+iNRtCVynPxSCwyMli4QZ1obD0A2bJK6m/sleqjLut91QuGIRFZ1KKzrOPN16bnftnF0FREgKbpOyV7Ysw9K0axEig9C/XiQre8aeR7E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA0PR12MB7074.namprd12.prod.outlook.com (2603:10b6:806:2d5::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.27; Thu, 7 Dec 2023 14:35:46 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7068.025; Thu, 7 Dec 2023 14:35:46 +0000 Message-ID: Date: Thu, 7 Dec 2023 14:35:42 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] app/test-pmd: fix tcp/udp cksum with padding data Content-Language: en-US To: Kaiwen Deng , dev@dpdk.org Cc: stable@dpdk.org, qiming.yang@intel.com, yidingx.zhou@intel.com, Aman Singh , Yuying Zhang , Olivier Matz , Pablo de Lara References: <20230804082849.533059-1-kaiwenx.deng@intel.com> <20231207085303.1924630-1-kaiwenx.deng@intel.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231207085303.1924630-1-kaiwenx.deng@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PA7P264CA0235.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:372::13) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA0PR12MB7074:EE_ X-MS-Office365-Filtering-Correlation-Id: e2dc0518-cc7b-4df0-5aa4-08dbf731ccd3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z7GTLy0/7Mb/Y1h/5e0rbUfPj+6eAmQHjqnyt3TtBX4wsKotaWC4q/8SEQfbY4F+uvnYk5s8N4ogjOxcLjYSmixxO3Zh+cZE5JUa0cyHXuOltpTXehXs3EbwYFVhZthKf+jFUipz4J3qJe4l8Nq5MLWXnswT2rooc+g8IX5I4rIrOMdFhX8ZhNHmzwAc+Qs+v+NIc+FBnBrCHOROhlSay6qXBub6tPUO5VMw58t7bO1K7DA05i/WRLpILBSlfDYjaVXQ1o9JK+sm+SulFuW7sOpTf5ziI2TREIBfpauMkA9rm8IxdpKPmMhi+Q+dLttcmhEyIMJzm+i90bdpPNkNpxmvc3Yp2e3j0gVB0ps+/5gyqXI51vizXuJfLP/hAnHoAcp5CzX8V9wQAJcdndeed/bq/DQh0pqAYoux/tsntI7EQ9hroRwEOL+X75RaK89G6RTxcBaUkUHQcZff1TlJSNJxNIiGw1sl87W7SFYrOhZj+FQjjG0gwJ9RNRe0ATkmMuFZC5jJKMil519M0UEweFwwcoAGCZUNjqc/AO8rDBpd1lGhMnbuisSbvBT77e8052+25l0igZ7C+FXvG4npqbAyzpNW/UThZ7EriiPZ0pJebFZolnCDkXPkO+AkIl9hJW0K8BhX3cwpQs66cWdouw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(376002)(346002)(39860400002)(136003)(366004)(230922051799003)(451199024)(186009)(1800799012)(64100799003)(41300700001)(36756003)(4744005)(2906002)(5660300002)(44832011)(31686004)(6506007)(53546011)(6512007)(6666004)(26005)(2616005)(6486002)(83380400001)(478600001)(31696002)(38100700002)(8676002)(8936002)(4326008)(86362001)(316002)(66946007)(66556008)(66476007)(54906003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUZqbzBnSzF3VHNXRlpsUTBkWXFhZ1g4d24ybTRQOTYyOEdqTnF3RWcwMURU?= =?utf-8?B?NXUxWFhPeFdBd1l2R2Vvc29EZm1KVVVRd3dpRnZJQlFIaHJEK256RjRXaGJh?= =?utf-8?B?amFYL2FYb0UyTFFiaDR5UDFiMGp0Q1FyeWx5MHQ5b2s1UVFBZ2RIRHBHbU1x?= =?utf-8?B?OWRESHhsdUFLakc4VHQ1VmUzOXY5aWxlU1BwK0F3TDlNeWxJZTVoNTRmUFp5?= =?utf-8?B?emRGNUN5U0NQYUJqQ1hXRC9NN2tmU0QwSWRUd3l1Qk9rempVYzZzYVpMVjJR?= =?utf-8?B?K0pETExiQ1BUQlo4SU4zem5Da0MxbGc2a1czdWxrdktsTEVpSEJCb0hGMklJ?= =?utf-8?B?ZGJHTnBENnRETFk3MVpFS0d3dnJKSGhQTDRXTmRXM2xwRXkxbVJ4a0JEVXdv?= =?utf-8?B?bktyYU9zaWtWWHYrdWl5R1VXQ1h1ZGFOaUJCV0RYMWIxcmlrd3FZRVo1RFZo?= =?utf-8?B?N2c3bUU4NjJFZkdLdzhhdmxUQy80OFFGWUZmM2FBYWJWQmZUSnhMR1VRcit5?= =?utf-8?B?SEpnUDg0blNUZE40OW81WmxlQitMOUdBamlVMDFYQjZRT2pVTUJLelk4ejlH?= =?utf-8?B?WjRpU1M2bm5ZOUN3S0tyWEYzTWJGdWdVdjNyd2pLWVpQemNVMFAxNlhUL1hv?= =?utf-8?B?NnBHT05uMXRONUlUL1k3OWpRQ0I0clR3Yy81MzRldXJKd25nWlRCNXoxS1pJ?= =?utf-8?B?UlZML0RKNnZtZzZYZmpCWi9CUjNsamlNMHpKd0R0NUVOWTRZd3poQytuTVN4?= =?utf-8?B?VXBaY25aU0Z4WmRQbnBTNUFrNVpucjUrY0VocC83Q1c5R3ZkYU02VmxSRGFG?= =?utf-8?B?LzJSMmNqdnFDNWpnRHdZSjhTYjhwbFpLdUkzaWR3RnFwWmdrQTZsT0UvcGNq?= =?utf-8?B?aGdMcEJIc3Q5M20zSzVKMmVyZU9sVGt0Q0NLL015d3NVcjZPZFpoR015TG1F?= =?utf-8?B?elJiREhEK3dwQ3BmMGJaNk9uU3B0ZmRQVEk2V2JCVFFQUXdkK3hZdjVGRnBl?= =?utf-8?B?eWpmWUNsVUI3TnlsUE1jUEUvNTRneSt1TXNYN2FvM3BpQnR0akVHaGxQcGZZ?= =?utf-8?B?Y09TRUhXaUhVN2R4K08vek4vMUNOUldBeHpRTzhwQUZUOEpLZXRyQ2c5ZTRK?= =?utf-8?B?T1AzeTBYYmtpeXFWNUh0S2wvK04rcGx6UG1Ka2Y0czlYNVNycS82WHMzei85?= =?utf-8?B?TTNFY2VkWUVYVTBpeXIvbi95TnF3bmUzWWRtQlcvNDQ1TlhpUjZnMnJjL2Fz?= =?utf-8?B?b3RnZGR5c1RMTXBUSzNSV3YxdnRWaVhQVk1Sc2tKcUMya3owWW5mRFF2Q0Ru?= =?utf-8?B?d1VjWVIvdXBVQnE0dy8rdkVXVmNPRTdoNGJtUFE2Y0tkdTRjdmZXd0d3TGJ0?= =?utf-8?B?Y0dqSVd1VFdkSHVueTlIK1Z6UzA3dkNsSmIycGZveWVWUC9uQjF5aXZaWG5J?= =?utf-8?B?TGhxejhhRjlsR1pkaXVST3BWYnZ2N0IyUzZhcEIvTThuTnJLYzR5OEovYkhj?= =?utf-8?B?TzdVVmZzZkRtOEdsWmoyem1NcXJ6WTdzOWg0VFozeUQ4MTdwNUVZc2Y3L0o2?= =?utf-8?B?YzQrZUJ4Qk9FU1FpZjQ2dHlkS21hWGNFN3FYU0w3WUUvVklzRVhpemtwcFFp?= =?utf-8?B?UFE0ajVUNzhBa3E5UXZlK1JRZFUvcE04UnI0QzZWQy9jTXBERVpjOGp3M1o1?= =?utf-8?B?dFZ1S1dKODA0NDlZbkppWm1NU2xzRGxacHdnTlRTdmN5L2dWSW0xRDdBMWlP?= =?utf-8?B?NUZrNFl5RkFzbmFkNWM4NmtmNGY3VUpXa0J5cTdHdzIvbXlGRVBlZTFqcXRW?= =?utf-8?B?MGQza1kzSW9VY0JteDhJb2tEdkhuRnZPd3ZqVDdCWmZ4K3N0WnpWL0ZvZEQy?= =?utf-8?B?MDYwK25SNW1FWU56Ny9EMHhrMXpaQUtDWUtIN0JYU3ZWTUtCTjZJcjd3ZXFX?= =?utf-8?B?NHBXZWRwRmtlVXR2UWFVRWppOVVLRlIzcW1FeUwxTkd4MWVlWkh5dHJvblFk?= =?utf-8?B?bStuSHlMRCtoT0RSSlJkM0dpL2xXYTZFak12bU9tT1cwTEROOWNRM0FjVnVU?= =?utf-8?B?QVozaWhiai9yTmVqR0dTR0crU011SWNMTzQ4K2xXVC9jcUdsaWUvUVRYcmxM?= =?utf-8?Q?ojQlSWWpvKV7pg/Xljz2xQRP9?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2dc0518-cc7b-4df0-5aa4-08dbf731ccd3 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 14:35:46.7697 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gMqtIsEM1w50uJ0Z1xH3G3qNSWBgNDWh2mL4EyoT+Re36FgddDFdaHiC0uI0Xz1n X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB7074 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/7/2023 8:53 AM, Kaiwen Deng wrote: > IEEE 802 packets may have a minimum size limit. The data fields > should be padded when necessary. In some cases, the padding data > is not zero. Testpmd does not trim these IP packets to the true > length of the frame, so errors will occur when calculating TCP > or UDP checksum. > > This commit fixes this issue by triming IP packets to the true > length of the frame in testpmd. > > Fixes: 03d17e4d0179 ("app/testpmd: do not change IP addrs in checksum engine") > Cc: stable@dpdk.org > > Signed-off-by: Kaiwen Deng > I think decision was to fix 'rte_ipv4_udptcp_cksum_mbuf()' & 'rte_ipv6_udptcp_cksum_mbuf()'.