From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE71FA04AB; Wed, 6 Nov 2019 14:54:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A811E1C1CC; Wed, 6 Nov 2019 14:54:50 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 726161C1C2 for ; Wed, 6 Nov 2019 14:54:49 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 05:54:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,274,1569308400"; d="scan'208";a="196214164" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.92]) ([10.237.220.92]) by orsmga008.jf.intel.com with ESMTP; 06 Nov 2019 05:54:44 -0800 To: Thomas Monjalon , David Marchand Cc: "Damjan Marion (damarion)" , Shahaf Shuler , Ray Kinsella , dev , Neil Horman , John McNamara , Marko Kovacevic , Bruce Richardson References: <911c9f45-ef00-0a9c-1e03-473ccbc89b9c@intel.com> <3750436.TWYBYb0nSM@xps> From: "Burakov, Anatoly" Message-ID: Date: Wed, 6 Nov 2019 13:54:44 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <3750436.TWYBYb0nSM@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] vfio: remove deprecated DMA mapping functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 06-Nov-19 1:50 PM, Thomas Monjalon wrote: > 06/11/2019 14:48, David Marchand: >> On Fri, Oct 25, 2019 at 2:23 PM Burakov, Anatoly >> wrote: >>> >>> On 25-Oct-19 12:13 PM, Damjan Marion (damarion) wrote: >>>> >>>> >>>>> On 25 Oct 2019, at 00:32, Thomas Monjalon wrote: >>>>> >>>>> 24/10/2019 21:09, David Marchand: >>>>>> On Thu, Oct 24, 2019 at 2:18 PM Anatoly Burakov >>>>>> wrote: >>>>>>> >>>>>>> The rte_vfio_dma_map/unmap API's have been marked as deprecated in >>>>>>> release 19.05. Remove them. >>>>>>> >>>>>>> Signed-off-by: Anatoly Burakov >>>>>>> --- >>>>>>> >>>>>>> Notes: >>>>>>> Although `rte_vfio_dma_map` et al. was marked as deprecated in our documentation, >>>>>>> it wasn't marked as __rte_deprecated in code. Should we still remove it? >>>>>> >>>>>> I can see that vpp is still using this api. >>>>>> I would prefer we get some ack from their side. >>>>>> >>>>>> Shahaf? >>>>>> Ray? >>>>>> >>>>>> Do you guys have contact with VPP devs? >>>>> >>>>> +Cc Damjan >>>> >>>> Thanks for looping me in. If I remember correctly that was used only to get mlx PMDs working. >>>> We can remove that calls but then mlx PMDs will stop working unless there is alternative solution. >>>> >>>> From my perspective it is not big issue as we already have native rdma based mlx support, but i would expect that other people will complain. >>>> >>>> Is there alternative way to tell DPDK about DMA mapping? >>> >>> The rte_vfio_container_dma_map(VFIO_DEFAULT_CONTAINER, ...) is the exact >>> equivalent of the functions being removed. Also, rte_dev_dma_map() is >>> supposed to be the more general DMA mapping API that works with VFIO and >>> with any other bus/device-specific DMA mapping. >>> >>> So yes, a simple search and replace for "rte_vfio_dma_(un)?map(" to >>> "rte_vfio_container_dma_(un)?map(VFIO_DEFAULT_CONTAINER, " should >>> trigger exactly the same behavior. >> >> The issue on VFIO_DEFAULT_CONTAINER seems fixed. >> The deprecation had been announced (even if it was for 20.02) and we >> have a replacement. >> >> So I am for taking this patch. >> Any objection? > > I agree to remove these functions. > Nuke them from orbit :) -- Thanks, Anatoly