From: huangdengdui <huangdengdui@huawei.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>,
<liuyonglong@huawei.com>
Subject: Re: [PATCH 1/3] net/hns3: fix inconsistent lock
Date: Tue, 9 Sep 2025 09:53:11 +0800 [thread overview]
Message-ID: <a3541da6-780a-4e6a-a31e-31611032a961@huawei.com> (raw)
In-Reply-To: <9500985.CDJkKcVGEf@thomas>
On 2025/9/9 4:20, Thomas Monjalon wrote:
> 08/09/2025 21:58, Stephen Hemminger:
>> On Mon, 08 Sep 2025 13:53:38 +0200
>> Thomas Monjalon <thomas@monjalon.net> wrote:
>>
>>> 13/08/2025 23:06, Stephen Hemminger:
>>>> On Wed, 13 Aug 2025 15:33:15 +0800
>>>> Dengdui Huang <huangdengdui@huawei.com> wrote:
>>>>
>>>>> The hns3 driver supports configuring RSS through both ops API and
>>>>> rte_flow API. The ops API uses spink lock, while the rte_flow API uses
>>>>> pthread mutex lock. When concurrent calls occur, issues may arise.
>>>>> This patch replaces the lock in the flow API with spink lock.
>>>>>
>>>>> Fixes: 1bdcca8006e4 ("net/hns3: fix flow director lock")
>>>>> Cc: stable@dpdk.org
>>>>>
>>>>> Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
>>>>> ---
>>>>
>>>> With that mutex removed, you can also go farther and remove all references to pthread.
>>>
>>> This patch was (probably by mistake) in the next-net/for-main branch.
>>> I've dropped it when pulling in main.
>>>
>>
>> I went ahead and fixed the original patch to drop pthread references
>> and fix wording in commit message; and put it back in next-net.
>
> There are 2 other patches to consider in this series.
> We should not break series if no urgency.
>
>
I also found this patch in the next-net/for-main branch, and I created the V2 patch after reverting.
next prev parent reply other threads:[~2025-09-09 1:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 7:33 [PATCH 0/3] net/hns3: bugfix for hns3 Dengdui Huang
2025-08-13 7:33 ` [PATCH 1/3] net/hns3: fix inconsistent lock Dengdui Huang
2025-08-13 21:06 ` Stephen Hemminger
2025-08-21 12:20 ` huangdengdui
2025-09-08 11:53 ` Thomas Monjalon
2025-09-08 19:58 ` Stephen Hemminger
2025-09-08 20:20 ` Thomas Monjalon
2025-09-09 1:53 ` huangdengdui [this message]
2025-08-21 12:24 ` David Marchand
2025-08-22 4:00 ` huangdengdui
2025-08-13 7:33 ` [PATCH 2/3] net/hns3: fix unrelease VLAN resource when init fail Dengdui Huang
2025-08-13 14:51 ` Stephen Hemminger
2025-08-21 12:16 ` huangdengdui
2025-08-13 7:33 ` [PATCH 3/3] net/hns3: fix overwrite mbuf in vector path Dengdui Huang
2025-08-22 6:04 ` [PATCH v2 0/4] net/hns3: bugfix for hns3 Dengdui Huang
2025-08-22 6:04 ` [PATCH v2 1/4] net/hns3: fix inconsistent lock Dengdui Huang
2025-08-22 6:04 ` [PATCH v2 2/4] net/hns3: enable lock annotations check Dengdui Huang
2025-08-22 6:04 ` [PATCH v2 3/4] net/hns3: fix unrelease VLAN resource when init fail Dengdui Huang
2025-08-22 6:04 ` [PATCH v2 4/4] net/hns3: fix overwrite mbuf in vector path Dengdui Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3541da6-780a-4e6a-a31e-31611032a961@huawei.com \
--to=huangdengdui@huawei.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=lihuisong@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).