From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, Wei Dai <wei.dai@intel.com>
Cc: dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v14] ethdev: new Rx/Tx offloads API
Date: Mon, 14 May 2018 15:46:38 +0100 [thread overview]
Message-ID: <a3733305-5af6-4d1b-e903-197736b6c20f@intel.com> (raw)
In-Reply-To: <1833263.kcaJZ8Err9@xps>
On 5/14/2018 3:11 PM, Thomas Monjalon wrote:
> 14/05/2018 15:20, Wei Dai:
>> Signed-off-by: Wei Dai <wei.dai@intel.com>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>
> [...]
>> * hasn't been set in the input argument eth_conf->rxmode.offloads
>> * to rte_eth_dev_configure(), it is a new added offloading, it must be
>> * per-queue type and it is enabled for the queue.
>> + * No need to repeat any bit in rx_conf->offloads which has already been
>> + * enabled in rte_eth_dev_configure() at port level. An offloading enabled
>> + * at port level can't be disabled at queue level.
>
> OK
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
Squashed into relevant commit in next-net, thanks.
>
> Thanks a lot Wei!
>
>
next prev parent reply other threads:[~2018-05-14 14:46 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 13:53 [dpdk-dev] [PATCH] ethdev: check consistency of per port offloads Wei Dai
2018-03-28 8:57 ` [dpdk-dev] [PATCH v2] ethdev: check Rx/Tx offloads Wei Dai
2018-04-13 17:31 ` Ferruh Yigit
2018-04-15 10:37 ` Thomas Monjalon
2018-04-16 3:06 ` Dai, Wei
2018-04-25 11:26 ` [dpdk-dev] [PATCH] " Wei Dai
2018-04-25 11:31 ` [dpdk-dev] [PATCH v3] " Wei Dai
2018-04-25 11:49 ` Wei Dai
2018-04-25 11:50 ` [dpdk-dev] [PATCH v4] " Wei Dai
2018-04-25 17:04 ` Ferruh Yigit
2018-04-26 7:59 ` Zhang, Qi Z
2018-04-26 8:18 ` Thomas Monjalon
2018-04-26 8:51 ` Zhang, Qi Z
2018-04-26 14:45 ` Dai, Wei
2018-04-26 14:37 ` [dpdk-dev] [PATCH v5] " Wei Dai
2018-04-26 15:50 ` Ferruh Yigit
2018-04-26 15:56 ` Thomas Monjalon
2018-04-26 15:59 ` Ferruh Yigit
2018-04-26 16:11 ` Ferruh Yigit
2018-05-03 1:30 ` [dpdk-dev] [PATCH v6] " Wei Dai
2018-05-04 11:12 ` Ferruh Yigit
2018-05-04 14:02 ` [dpdk-dev] [PATCH v7] " Wei Dai
2018-05-04 14:42 ` Ferruh Yigit
2018-05-04 14:45 ` Ferruh Yigit
2018-05-05 18:59 ` Shahaf Shuler
2018-05-07 7:15 ` Dai, Wei
2018-05-08 10:58 ` Ferruh Yigit
2018-05-08 10:05 ` [dpdk-dev] [PATCH v8] " Wei Dai
2018-05-08 10:41 ` Andrew Rybchenko
2018-05-08 11:02 ` Ferruh Yigit
2018-05-08 11:22 ` Andrew Rybchenko
2018-05-08 11:37 ` Andrew Rybchenko
2018-05-08 12:34 ` Dai, Wei
2018-05-08 12:12 ` Ferruh Yigit
2018-05-09 12:45 ` Dai, Wei
2018-05-10 0:49 ` [dpdk-dev] [PATCH v9] ethdev: new Rx/Tx offloads API Wei Dai
2018-05-10 0:56 ` [dpdk-dev] [PATCH v10] " Wei Dai
2018-05-10 1:28 ` Ferruh Yigit
2018-05-10 2:35 ` Thomas Monjalon
2018-05-10 11:27 ` Dai, Wei
2018-05-10 9:25 ` Andrew Rybchenko
2018-05-10 19:47 ` Ferruh Yigit
2018-05-10 11:30 ` [dpdk-dev] [PATCH v11] " Wei Dai
2018-05-10 11:56 ` [dpdk-dev] [PATCH v12] " Wei Dai
2018-05-10 21:39 ` Thomas Monjalon
2018-05-14 8:37 ` Thomas Monjalon
2018-05-14 11:19 ` Dai, Wei
2018-05-10 21:48 ` Ferruh Yigit
2018-05-14 12:00 ` [dpdk-dev] [PATCH v13] " Wei Dai
2018-05-14 12:54 ` Thomas Monjalon
2018-05-14 13:26 ` Dai, Wei
2018-05-14 13:20 ` [dpdk-dev] [PATCH v14] " Wei Dai
2018-05-14 14:11 ` Thomas Monjalon
2018-05-14 14:46 ` Ferruh Yigit [this message]
2018-05-10 21:08 ` [dpdk-dev] [PATCH v10] " Ferruh Yigit
2018-05-08 10:10 ` [dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads Wei Dai
2018-05-08 17:51 ` Andrew Rybchenko
2018-05-09 2:10 ` Dai, Wei
2018-05-09 14:11 ` Ferruh Yigit
2018-05-09 22:40 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3733305-5af6-4d1b-e903-197736b6c20f@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=thomas@monjalon.net \
--cc=wei.dai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).