From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E686A04A5; Wed, 17 Jun 2020 14:59:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C85121E2B; Wed, 17 Jun 2020 14:59:35 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 9A269100C for ; Wed, 17 Jun 2020 14:59:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592398774; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3y5nzKbJVNrZ31GTGVP4a6nrIQJz3iiNgSzqC3f4XGA=; b=PxZy4AyY+fz6HbqvCbcy2mc9MDy9qmEKvqZrAfhLJTFYcl9hjxRc9eUalRr7w97qkScAfL 2NlA5YQrpfTERzx4+UkSyY4l+35yy9tZwQRhMgU4dTNxno1gqnJWvMBrqCMG/8uYMxH0nZ yxj+Egfli4PHOC9ONY/ZHJ+6hJLv0I4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-500-CAB0k0GfOlWDPvwJP-NABQ-1; Wed, 17 Jun 2020 08:59:30 -0400 X-MC-Unique: CAB0k0GfOlWDPvwJP-NABQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AFDAB1940923; Wed, 17 Jun 2020 12:59:28 +0000 (UTC) Received: from [10.33.36.205] (unknown [10.33.36.205]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4A28910246E2; Wed, 17 Jun 2020 12:59:27 +0000 (UTC) To: Matan Azrad , Ferruh Yigit , Raslan Darawsheh , Dekel Peled , Slava Ovsiienko Cc: "dev@dpdk.org" References: <6dd4f7a13e375c743e77555a6360e7bfa9b9aba5.1591795480.git.dekelp@mellanox.com> <3be96603-42c7-d4a9-6718-930019be10aa@intel.com> <985aa47c-6855-0218-ca2d-d6af60a1386e@intel.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= mQINBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABtCNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPokCTgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71uQINBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABiQI2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Message-ID: Date: Wed, 17 Jun 2020 13:59:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 17/06/2020 12:43, Matan Azrad wrote: > > > From: Ferruh Yigit: >> On 6/16/2020 5:23 PM, Matan Azrad wrote: >>> >>> >>> From: Ferruh Yigit >>>> On 6/16/2020 5:06 PM, Matan Azrad wrote: >>>>> Hi >>>>> >>>>> Ferruh, Raslan >>>>> >>>>> This patch is not a fix, we don't need to backport it. >>>> >>>> Why not backport it? >>> >>> There is no a bug fix. >>> The behavior will not be changed. >>> >>> It is just for comfort. >> >> It is not fix in the functionality, yes. But since it is merged into master, why >> not backport it, backporting reduces possible conflicts in related code later. > > We can say it for any patch in master. > >> Also if this increases the readability of the code, why not stable trees benefit >> from it too? > > It is not too important in some cases, therefore doesn't worth the potential effort of backporting. > > I think this is grey case, maybe one thing we can let the maintainer to decide... > > I will not insist... > In this case it is changing a "non-fix" commit in v20.05. So, in reality it's not relevant to existing maintained stable branches with or without the tag. Wrt letting stable maintainer decide, in general stable maintainer won't look at patches without the tags, so better to tag if there's a doubt. >>>>> I don't think we need fixes and cc stable here. >>>>> >>>>> Matan >>>>> >>>>> From: Raslan Darawsheh >>>>>> Hi, >>>>>> >>>>>>> -----Original Message----- >>>>>>> From: Ferruh Yigit >>>>>>> Sent: Tuesday, June 16, 2020 1:28 PM >>>>>>> To: Dekel Peled ; Matan Azrad >>>>>>> ; Slava Ovsiienko >>>> ; >>>>>>> Raslan Darawsheh >>>>>>> Cc: dev@dpdk.org >>>>>>> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to >>>>>>> correct location >>>>>>> >>>>>>> On 6/10/2020 2:25 PM, Dekel Peled wrote: >>>>>>>> Recent patch [1] added definition of mask >> MLX5_GTP_FLAGS_MASK, >>>> just >>>>>>>> above function flow_dv_validate_item_gtp(), where it is used. >>>>>>>> >>>>>>>> Patch was applied together with other patches which modified the >>>>>>>> same file, so the mask was located further away from the function >>>>>>>> it is used in. >>>>>>>> >>>>>>>> This patch moves the mask definition to the proper location. >>>>>>>> >>>>>>>> Signed-off-by: Dekel Peled >>>>>>>> Acked-by: Matan Azrad >>>>>>>> >>>>>>>> [1] Commit 563ac307a46b ("net/mlx5: support match on GTP flags") >>>>>>> >>>>>>> >>>>>>> Better to add this as 'Fixes', instead of reference, so this way >>>>>>> it helps for the backporting etc.. >>>>>>> >>>>>>> Fixes: b88341ca35fc ("net/mlx5: convert flow dev handle to >> indexed") >>>>>>> Cc: stable@dpdk.org >>>>>> >>>>>> I'll change it in next-net-mlx accordingly, >>>>>> >>>>>> Kindest regards, >>>>>> Raslan Darawsheh >>> >