From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D091DA0093; Tue, 8 Nov 2022 14:49:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7BD05400D4; Tue, 8 Nov 2022 14:49:48 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4607D4003C for ; Tue, 8 Nov 2022 14:49:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667915386; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gbl8lmzgjbHt4bbe/Zthg6FL6GXipHWp2IQe2lpmG2s=; b=cZCjMw3FtQyXNuoQxnUygxMRpdZrCrLR11hOm71ZLtS4tsLEpOh7DOkbhrUXPtzuaFQeGd gJO0ll4cE4+1fxGtLg6ssX06y18FvMIs+PTq3+lj0LanGtHPVCBRSDzi1+oahDOSKPQLu/ 6/Em8oxxD3rZtXuACGTXWRSCZPG0zWw= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-149-DFBTM2KqNTi9nnUYTaG9oA-1; Tue, 08 Nov 2022 08:49:43 -0500 X-MC-Unique: DFBTM2KqNTi9nnUYTaG9oA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D23651C07594; Tue, 8 Nov 2022 13:49:42 +0000 (UTC) Received: from [10.39.208.36] (unknown [10.39.208.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9EDC040C947B; Tue, 8 Nov 2022 13:49:41 +0000 (UTC) Message-ID: Date: Tue, 8 Nov 2022 14:49:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 To: Taekyung Kim , dev@dpdk.org Cc: chenbo.xia@intel.com, andy.pei@intel.com, stable@dpdk.org, xiao.w.wang@intel.com References: <20221108085624.53989-1-kim.tae.kyung@navercorp.com> From: Maxime Coquelin Subject: Re: [PATCH v4] vdpa/ifc: fix update_datapath error handling In-Reply-To: <20221108085624.53989-1-kim.tae.kyung@navercorp.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Taekyung, On 11/8/22 09:56, Taekyung Kim wrote: > Stop and return the error code when update_datapath fails. > update_datapath prepares resources for the vdpa device. > The driver should not perform any further actions > if update_datapath returns an error. > > Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver") > Cc: stable@dpdk.org > > Signed-off-by: Taekyung Kim > --- > v4: > * Add rte_vdpa_unregister_device in ifcvf_pci_probe > > v3: > * Fix coding style > > v2: > * Revert the prepared resources before returning an error > * Rebase to 22.11 rc2 > * Add fixes and cc for backport > > --- > drivers/vdpa/ifc/ifcvf_vdpa.c | 27 +++++++++++++++++++++++---- > 1 file changed, 23 insertions(+), 4 deletions(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime