From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B3735A0C44;
	Mon, 12 Apr 2021 14:59:29 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 95E21141188;
	Mon, 12 Apr 2021 14:59:29 +0200 (CEST)
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by mails.dpdk.org (Postfix) with ESMTP id 8EA6E141187;
 Mon, 12 Apr 2021 14:59:26 +0200 (CEST)
IronPort-SDR: MzQVgVicuIiscUsWBVvHBaQWT4X8R/d7RWB3fT40jwcQ5GmkWhYDrNtr58Ok1PV6iZWgKCC/92
 iiZQEHVZLy3g==
X-IronPort-AV: E=McAfee;i="6000,8403,9952"; a="181700417"
X-IronPort-AV: E=Sophos;i="5.82,216,1613462400"; d="scan'208";a="181700417"
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 12 Apr 2021 05:59:26 -0700
IronPort-SDR: qQVO03P6hK8dX3J3MG+7dbz/ZgoDM7gE4cHY7NqRWfH+ZdwjRG7Kt983I9guxkNPCW7l9kCMIV
 YMy1H7MrJopg==
X-IronPort-AV: E=Sophos;i="5.82,216,1613462400"; d="scan'208";a="460154937"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.203.254])
 ([10.213.203.254])
 by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 12 Apr 2021 05:59:24 -0700
To: Raslan Darawsheh <rasland@nvidia.com>, Tal Shnaiderman
 <talshn@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>,
 NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
Cc: Matan Azrad <matan@nvidia.com>, Asaf Penso <asafp@nvidia.com>,
 Wisam Monther <wisamm@nvidia.com>, "stable@dpdk.org" <stable@dpdk.org>
References: <20210411122136.2560-1-talshn@nvidia.com>
 <SN6PR12MB2750A29D422DE720B920218CCF709@SN6PR12MB2750.namprd12.prod.outlook.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
X-User: ferruhy
Message-ID: <a3b6adeb-ee92-d141-d149-11bd8d7638fc@intel.com>
Date: Mon, 12 Apr 2021 13:59:20 +0100
MIME-Version: 1.0
In-Reply-To: <SN6PR12MB2750A29D422DE720B920218CCF709@SN6PR12MB2750.namprd12.prod.outlook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] common/mlx5: fix missing
 __rte_internal tags in exported functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/12/2021 12:25 PM, Raslan Darawsheh wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Tal Shnaiderman <talshn@nvidia.com>
>> Sent: Sunday, April 11, 2021 3:22 PM
>> To: dev@dpdk.org
>> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Matan Azrad
>> <matan@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>; Asaf Penso
>> <asafp@nvidia.com>; Wisam Monther <wisamm@nvidia.com>;
>> stable@dpdk.org
>> Subject: [PATCH] common/mlx5: fix missing __rte_internal tags in exported
>> functions
>>
> Removed __ from the commit title to fix wrong headline format issue.
> 
>> Several functions introduced in the addition of the Windows support to
>> mlx5 were missing the __rte_internal tag although being exported.
>>
>> Fixes: 1552fb287166 ("common/mlx5: add alloc/dealloc PD on Windows")
>> Fixes: 1969ee424405 ("common/mlx5: add UMEM reg/dereg functions on
>> Windows")
>> Fixes: ba420719823c ("common/mlx5: add reg/dereg MR on Windows")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> 
> Patch applied to next-net-mlx,
> 

Can we merge this directly to main repo?
Since debug build is broken without it.