From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47F17A0C4E; Tue, 2 Nov 2021 15:09:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0AAA741139; Tue, 2 Nov 2021 15:09:56 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id BD09E4068F for ; Tue, 2 Nov 2021 15:09:53 +0100 (CET) Received: from [192.168.1.71] (unknown [188.170.83.209]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 977727F6D2; Tue, 2 Nov 2021 17:09:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 977727F6D2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1635862193; bh=R0ONzyUzYg1qnq2JGG+CRnipPht6b1FPr+jHMtaXGiI=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=CFiL3lO9SPZFdR1huH6iyDRxDM9hj8ZKxnia+Z/6XhLlWAj/ihqwEsjx8RaRs6/zY YKZZGfuJ8gjXrVgWnwOxnE0wkhxqAMZEL7it5zKXmO4qFLtjMW5OTtE67kwJ8aARtP n2tfFCp3jApyRptHkfByc/kzfhKxNU+hz8T0T73A= To: Ferruh Yigit , Thomas Monjalon , Jerin Jacob Cc: dev@dpdk.org, David Marchand , Ivan Malov References: <20211102125058.3872552-1-andrew.rybchenko@oktetlabs.ru> From: Andrew Rybchenko Message-ID: Date: Tue, 2 Nov 2021 17:09:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] doc: cleanup flow mark Rx offload deprecation notice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/2/21 4:47 PM, Ferruh Yigit wrote: > On 11/2/2021 12:50 PM, Andrew Rybchenko wrote: >> The problem is solved using Rx metadata delivery negotiation API [1]. >> > > Can this API replace RX_OFFLOAD_RSS_HASH too? It can, but it should not. RSS hash is an offload since it is a calculation of the hash in HW and delivery of the result to SW. Like checksums: check in HW and delivery of the result to SW. > >> [1] commit f6d8a6d3fad7 ("ethdev: negotiate delivery of packet >> metadata from HW to PMD") >> >> Signed-off-by: Andrew Rybchenko >> --- >>   doc/guides/rel_notes/deprecation.rst | 8 -------- >>   1 file changed, 8 deletions(-) >> >> diff --git a/doc/guides/rel_notes/deprecation.rst >> b/doc/guides/rel_notes/deprecation.rst >> index 4366015b01..ec5073908f 100644 >> --- a/doc/guides/rel_notes/deprecation.rst >> +++ b/doc/guides/rel_notes/deprecation.rst >> @@ -69,14 +69,6 @@ Deprecation Notices >>     and the related structures (``rte_fdir_*`` and ``rte_eth_fdir_*``), >>     will be removed in DPDK 20.11. >> -* ethdev: New offload flags ``RTE_ETH_RX_OFFLOAD_FLOW_MARK`` will be >> added in 19.11. >> -  This will allow application to enable or disable PMDs from updating >> -  ``rte_mbuf::hash::fdir``. >> -  This scheme will allow PMDs to avoid writes to ``rte_mbuf`` fields >> on Rx and >> -  thereby improve Rx performance if application wishes do so. >> -  In 19.11 PMDs will still update the field even when the offload is not >> -  enabled. >> - >>   * ethdev: Announce moving from dedicated modify function for each >> field, >>     to using the general ``rte_flow_modify_field`` action. >>