From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B599C1BA4B for ; Thu, 26 Oct 2017 14:30:53 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Oct 2017 05:30:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,434,1503385200"; d="scan'208";a="914004706" Received: from rnicolau-mobl.ger.corp.intel.com (HELO [10.237.221.73]) ([10.237.221.73]) by FMSMGA003.fm.intel.com with ESMTP; 26 Oct 2017 05:30:49 -0700 To: David Marchand , "Ananyev, Konstantin" Cc: "dev@dpdk.org" , "Doherty, Declan" , "De Lara Guarch, Pablo" , Hemant Agrawal , "borisp@mellanox.com" , "aviadye@mellanox.com" , Thomas Monjalon , "sandeep.malik@nxp.com" , Jerin Jacob , "Mcnamara, John" , "shahafs@mellanox.com" , Olivier Matz , Akhil Goyal References: <1509013365-13819-1-git-send-email-radu.nicolau@intel.com> <1509013365-13819-3-git-send-email-radu.nicolau@intel.com> <36c6304e-cd1b-9bd9-2c5d-c6e20eff85e8@intel.com> <2601191342CEEE43887BDE71AB9772585FAAF5A7@IRSMSX103.ger.corp.intel.com> From: Radu Nicolau Message-ID: Date: Thu, 26 Oct 2017 13:30:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2017 12:30:54 -0000 On 10/26/2017 12:39 PM, David Marchand wrote: > On Thu, Oct 26, 2017 at 1:30 PM, Ananyev, Konstantin > wrote: >>> -----Original Message----- >>> From: Nicolau, Radu >>> It can be disabled in the code, but as far as I know there is a general >>> push back against having conditionally compiled code. I originally had >>> the security sections in ixgbe PMD isolated, but the feedback was to >>> have them always on. >>> An alternative solution will be to remove the option altogether and >>> always build rte_security library. >> My vote would be to have it a mandatory library for ixgbe. >> Add it into DEPDIRS-ixgbe inside drivers/net/Makefile or so. > And then librte_security needs librte_crypto (if I am not mistaken). > So if we go this way, we must ensure the same is done in librte_security. > > It is already there: DEPDIRS-librte_security += librte_cryptodev