From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9943C43709;
	Sat, 16 Dec 2023 11:08:06 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 858E740691;
	Sat, 16 Dec 2023 11:08:06 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 5260B402AA
 for <dev@dpdk.org>; Sat, 16 Dec 2023 11:08:05 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id C5C8F66;
 Sat, 16 Dec 2023 13:08:04 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru C5C8F66
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1702721284;
 bh=c2Ve2cBh7D1aSrZkrpDWAeCIS4KoGBksKlueoGdv/Gs=;
 h=Date:Subject:From:To:Cc:References:In-Reply-To:From;
 b=a6UmLp3uNZSkNYwkDvnTQIMDTiZ4BjcDAMR9f73Pa9Vixz0mgM86/CcWCGa6QamZk
 rhCPNduHH0RLUrwRlTN2+pXHJbqMHTnGbN5vl6/NeXRaI2WRPQ227/68bOfBZDEWxI
 iTuuvR0IKGsETiUTBuEZEjC/z0IV8ITjsTYN4Bt8=
Message-ID: <a3f00a3d-760b-41ac-952b-bf58276c483a@oktetlabs.ru>
Date: Sat, 16 Dec 2023 13:08:04 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 2/5] ethdev: check return result of rte_eth_dev_info_get
Content-Language: en-US
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Cc: Sinan Kaya <okaya@kernel.org>, =?UTF-8?Q?Morten_Br=C3=B8rup?=
 <mb@smartsharesystems.com>, Thomas Monjalon <thomas@monjalon.net>,
 Ferruh Yigit <ferruh.yigit@amd.com>
References: <20230120044140.95975-1-okaya@kernel.org>
 <20230710170800.12478-1-stephen@networkplumber.org>
 <20230710170800.12478-3-stephen@networkplumber.org>
 <05b81908-75e3-4b4e-a317-e3fc39c10fd3@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <05b81908-75e3-4b4e-a317-e3fc39c10fd3@oktetlabs.ru>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 12/16/23 13:06, Andrew Rybchenko wrote:
> On 7/10/23 20:07, Stephen Hemminger wrote:
>> From: Sinan Kaya <okaya@kernel.org>
>>
>> rte_class_eth: eth_mac_cmp: The status of this call to 
>> rte_eth_dev_info_get
>> is not checked, potentially leaving dev_info uninitialized.
>>
>> Signed-off-by: Sinan Kaya <okaya@kernel.org>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>> Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
> 
> Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

except of patch summary which should not mention function name