From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 628D6A0C43; Tue, 16 Nov 2021 10:14:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E66D440141; Tue, 16 Nov 2021 10:14:29 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id D26B340040 for ; Tue, 16 Nov 2021 10:14:28 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10169"; a="220541730" X-IronPort-AV: E=Sophos;i="5.87,238,1631602800"; d="scan'208,217";a="220541730" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2021 01:14:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,238,1631602800"; d="scan'208,217";a="506351190" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga008.jf.intel.com with ESMTP; 16 Nov 2021 01:14:27 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 16 Nov 2021 01:14:27 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 16 Nov 2021 01:14:27 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 16 Nov 2021 01:14:26 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jV37JwtXJpMjxCCRorHWAPGPLMRuOA3NvDMeV3tCkxEA6kysua0Pvo/TBIDdecDnMXk44EAX71SDz99QCkdiVgPMg7ijOjzUNyMWw4ch76r+Vjw+82J4ygzm2LI6vLHVlIzZA4nNtIQnl1zQ4ck6Ab6BQxyBFnqQwW0LPXvJMatawkVpvLKOBpwfyKfjt+9pQ6vmh254SWX9XQkl1FA6txZZLEkzKcjFHOjp2ZP0TQvEkSPBz+k9qk3DuChHA4urT1MQ1NwVW/gqnD4/g9B/UFr+nN8WYJOQY1tclK51CLqJxICSzli/S7obUavcZmEFEuZd7Lp5HTsMJYy2nthTRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gdFFLrN3C0c8XLpAlyXBHMZCiqUA/TPVHtsshfn3yCA=; b=DtiTVub7zB0fHaezeWpsYXY0WwqAvwHx/lWqPTF8YakccduNhicxa5wFrfhVsRVh6B76vPFwWs0QKcwj29MJ6JhcjLl7tlrv20ASTglB8Y3DtxTSuQN+IrIYJ+qr//0jRn2qElXEktgULw91I9RThYmNjBsohRTwai9MU4oEnpqgn2h7nmeF5mV0+NrFoZbPbHq0uSbDjF/J0LU/WiFm0JJ+Eyeynl0PlGFFup9sZGC72Tb7cO+7A2ESvf+NK4vIePD++IReBaVjWFRw6on3vv2JzK3U8Vy+Sl3I23DK+qM3z7YeRw2YIUvFYIOu57yTXwcJbuaKyjqJfrVvH5ykjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gdFFLrN3C0c8XLpAlyXBHMZCiqUA/TPVHtsshfn3yCA=; b=u7cMHni/Nxhj7FvYebW8ngYCDLAdhwWYC5KwnRoDBxnxQhteBxgjvvy33jF1AclbPMxTrBv9ueQVO4vJqzFDfd/DDfRkpVwDGTwNCwp6Ptbi4R+aNZG2revPE9vxn73oA0dMnoB80d5HvzJTLbDlxxMOc5bY2aV6frMK/5A9DyE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5047.namprd11.prod.outlook.com (2603:10b6:510:3c::18) by PH0PR11MB4933.namprd11.prod.outlook.com (2603:10b6:510:33::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.27; Tue, 16 Nov 2021 09:14:26 +0000 Received: from PH0PR11MB5047.namprd11.prod.outlook.com ([fe80::f1a0:809a:3d2e:e13c]) by PH0PR11MB5047.namprd11.prod.outlook.com ([fe80::f1a0:809a:3d2e:e13c%9]) with mapi id 15.20.4690.027; Tue, 16 Nov 2021 09:14:26 +0000 Subject: Re: [PATCH v1] examples/l3fwd-power: add wakeup log To: Miao Li , References: <20211116130013.146137-1-miao.li@intel.com> From: David Hunt Message-ID: Date: Tue, 16 Nov 2021 09:14:21 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.14.0 In-Reply-To: <20211116130013.146137-1-miao.li@intel.com> Content-Type: multipart/alternative; boundary="------------924097D01DECC9C8E2712C45" Content-Language: en-GB X-ClientProxiedBy: DBBPR09CA0023.eurprd09.prod.outlook.com (2603:10a6:10:c0::35) To PH0PR11MB5047.namprd11.prod.outlook.com (2603:10b6:510:3c::18) MIME-Version: 1.0 Received: from [192.168.1.2] (86.42.124.153) by DBBPR09CA0023.eurprd09.prod.outlook.com (2603:10a6:10:c0::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.16 via Frontend Transport; Tue, 16 Nov 2021 09:14:25 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 24bfa52f-9076-4bb8-c956-08d9a8e17c92 X-MS-TrafficTypeDiagnostic: PH0PR11MB4933: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GkMo2U0DYegYQ+h1REKlvarUsYuQ1b8HrO1fu/u65hdQEjPHHsEM2oIZiTJywW+owA1Zy2u+XxUtwq+rTxZ80mh4SSEtIQqKuYSC0H4crIpSaavd0SldyATrfWxHeUHI3EDwVwrcFA9Wq9mXPA9ShRPoHI4nTylosRLCW7Of0QQbcAcrH1qDoUnDvY7/gBGU5LJZ9ZHfp0fnpo2hqMkA96jkvyJXP/Xv2G/t9o/SBTuIL2dGQs6nTqeFZSSA9BcJNSoJC71g3hDKTH27yT8AXopAJB91y5LxfabU7nRRQHwQ1cn3QYYVBq266EG/Wlaqi1c+9WIhUkNs73zWfUzpYeNPACAXsb1bNkZxdtyBHwZKVSW14A+brCedL3OD0YSd+kL7BYrzcjAz7ctBq5SxVDCVEnAaVyVu/Ozkfq///aZ2yqAtTJY9ixaz5p+mq34IJxFUJZH5vQRA502ZDFkmrZxc7+uY0uVk2f01DP5dOWx2hzdjA0WYaC0N55hishHB2Gd4UBsjSoEntD2Ye5niCGBKons6F4S8DpaTcsYnpqwNU4wAqpzFnh+pI75fnATFED4w3Twq/sH6JOTrcNWQGcnJ21mozo/pDfycVD7A7FwEN58FTswPd007A4PR0aVFK1sUoEK+ByqKsx+hSkXies3ubcXj3t1E5m5bwcNKrW9UjNo5RXqF3YMoMA/ZBx1r7WvBsXk9V5vrbMJj9i7pWcia7oPVNnUdGH5/L2zpmyc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5047.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(44832011)(5660300002)(31686004)(8676002)(31696002)(33964004)(16576012)(8936002)(53546011)(316002)(26005)(86362001)(2616005)(83380400001)(66476007)(66556008)(82960400001)(508600001)(956004)(66946007)(186003)(6486002)(6666004)(38100700002)(36756003)(2906002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WmNPaGRMNlVNMVZoOGZDdUdWZ0hYYXE0OFVVRVhkT0dOQi9oeUFpb25ReUFp?= =?utf-8?B?UHhCOGFIKzByZDNUUXRkd09JcEpVNzN6akcvUGo4L2NiSVJZTHpINFdBTzU1?= =?utf-8?B?SWg3R1JwNHhFQm9qWmVhMTZPNzNPb1JGcWo5bndrTTg2WUhvK3ZxMm9ySmVU?= =?utf-8?B?S3AxcmhZMEsxKzRsalpmNlVQbU1KNitlWDhkVVpHWVdXV1BwNS9KcVU3enpT?= =?utf-8?B?TVhXTjJoeEJqQ2pQWlhoQ3pkY0tZU0lVbi9HV0ZhNzBRSVFoYlpRanZBRDJJ?= =?utf-8?B?Njk1ZXpZbVF1RzVCSjBDRU9nNVBxVzJEK3MzM2x5MU1xYS9wRldMektHTjRG?= =?utf-8?B?KzRwaVJ1ak1ScDZDV3ZidW95RW5OdE80eGV0Y3h5d3pNdG9XdHJQcUw3dVAw?= =?utf-8?B?UENSY1NRMFhhRDhPMXdlMi84QXJMemErU3ZHNHJuN0J1Ujh1ZWZkd0swdVB3?= =?utf-8?B?NEtBVFloUnNCYmhjT0xLd2NXMUNvdGxQK0hKNVdqVUIxK3FPbG5LTzM2ZVAw?= =?utf-8?B?NW9HUDJjY3FBZ1R5RWtuY3c2dEcycGwxSXdwc2gyTDk1VkRNdW9MT0V6a2JI?= =?utf-8?B?OVpVcUFxZ0hhUUw2d1N2K0pCdXFHWkh6ZjRXdHVSS3lZSFpZNGtPdGxvV1ZU?= =?utf-8?B?cHZ1Yzd0aFdoaC8wMzJ3YWlrMGFOZSt5amtGOVFuTXg5RkUxTmplMWUwbFY5?= =?utf-8?B?SzYwWTR6NEVCNU94OVJ2MjZGejloblk0cFgzK0NhM2t0YlJ4MjNKSmU2Q1hG?= =?utf-8?B?UCtnNzlTbHdFU3BCeVlNUXVtdnUrQlRmbEZMM1J3bUpnUW4weUFabDVzTTdF?= =?utf-8?B?RFVLN003WHlWeUIrajRUdVF5Mlh1cDRHTHBQajV6cXM3b2p0MjlUTkxzY3RN?= =?utf-8?B?VE1SSFFKTDNsNFp2cTR1V3lvODhPTWFzWHd1TEx0S1hwa0hEa29lNkZJUzMy?= =?utf-8?B?WWM2L29Td3o0cU9jMGhaTzZidTNtM3c1UXpXMGR2UTB3Mm5Ebk5kSDNFMDJK?= =?utf-8?B?eVFDQzFQVjNIbDhoQkZIQVV3Mm9HN3o4WTBLZnhYT3pmRks1ckM3RGRrUGo2?= =?utf-8?B?VktxclJJOC9NQjc2dWpsUnhUT1JjUTAvQ2JsVnJMQ25EYjFIYXBacXVPWEhs?= =?utf-8?B?T0hXTGVadHpROWpDWkl5YktIcDdEWWNlZkZ5eTgzSno4clpaOVpac3dCNEpK?= =?utf-8?B?UDVlK1Q4YjQ0WERPb3NIMGJ5UGppMnhQK2w4cGx5bUk4Ky9yZ3BKSjFZMEVj?= =?utf-8?B?MDBHaWdib3NRTnhRamFCcGhRUmtJSTlEc1FaajhuazBhZlowMVlBeFZ5U1Bv?= =?utf-8?B?RXZ1Z2FYQWpBSXhCTjdKVENFeGc1cTBpLzcxMjNVUE9BbnltNGVJWlVsZGlB?= =?utf-8?B?RkpYYlppVGtLU3YrRzJ1K0M3dHVZRkZLRng5ckJRZHdvS1B5dU9TaEF5L0dn?= =?utf-8?B?a0llR0JEd000czVZR2ZMc2s5QnBrUGN1K1hqcFhWWUJUSzNWQkd3dTN1L0sx?= =?utf-8?B?am43eGtJeDAxT084a05RV1ZmYys1Z3JRQ2hRZEM2RVp0eXdQUnRCSUFuZGd0?= =?utf-8?B?T1RzTkdBS3h3aXQrVDJJSDBnMEN0WWRGOEFFNlJkTWVRWUgvT1E5NUd0VnVK?= =?utf-8?B?STBGZHpZTmlKUXp4S2ptbDlUS2FjakR6MDMwa05oa3dUVzFDbGtUNlBmWWZJ?= =?utf-8?B?R3ZwYWVyVjNWTitrYjJQQ0xPcnA0VnQ1TEFHa2JQaUZuaXR4S3IvR05wdW1r?= =?utf-8?B?M0RqOVVqVWtoVit0ZUh4YW5KSzd4ZmNtQ1BuYlFvcVN6SExBTVhIa3gzRVRo?= =?utf-8?B?cGd2eEVNb2FnK1ppdWpOMm90T1h1UFNIU1RkN29nRFFCZElpKzdJMGg2eE0r?= =?utf-8?B?dmsxQlcrbXozYXlRdDFBblRmT1VmUFIxYkhZQ292eVNCaXJGc0pmYTlPeExt?= =?utf-8?B?TWloUDV4RGN3UTVwZU9kNklJaVhvS0IvWnlHaXhQOXV1bnB2YkVQN1ZqMjQy?= =?utf-8?B?djNzNEI0QnIvM0JmcElyYnNVZVpCdDlLWlIwaEtydjVQdUl6cXlMZHhXWGEr?= =?utf-8?B?WWlIMVNPV3J0bytLOThXcEZpZHpXS25VWGxCVDFtc1BtZ2ZvZklnSFI2RHNv?= =?utf-8?B?UzExbVl1UFppS1NtSm0zZjdIOWFFZElSaVVlUWtGSS9aYUZvalU0R2xqZTJU?= =?utf-8?Q?LCLrKV66qJtZjYg6Ql/ywYE=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 24bfa52f-9076-4bb8-c956-08d9a8e17c92 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5047.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2021 09:14:26.2799 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RJvs49Ng/5Moo7JgjCDOmMDcsjjt8MVzhoY5gQ3dmIZz2Zyoz56ssbhxmbVV9q3pUNR+ZXRcV4ZVhCV+36jd5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4933 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --------------924097D01DECC9C8E2712C45 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi Li, On 16/11/2021 1:00 PM, Miao Li wrote: > This patch adds a log in main telemetry loop to show the thread is > waked up and begins to send and receive packets. > > Signed-off-by: Miao Li > --- > examples/l3fwd-power/main.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c > index 6988a0ed34..b8c020fb91 100644 > --- a/examples/l3fwd-power/main.c > +++ b/examples/l3fwd-power/main.c > @@ -1156,6 +1156,9 @@ main_telemetry_loop(__rte_unused void *dummy) > ep_nep[nb_rx == 0]++; > fp_nfp[nb_rx == MAX_PKT_BURST]++; > poll_count++; > + RTE_LOG(INFO, L3FWD_POWER, > + "lcore %u is waked up on port %d queue %d\n", > + rte_lcore_id(), portid, queueid); > if (unlikely(nb_rx == 0)) > continue; > It's probably better to say "lcore %u is *reading *port %d queue %d". Regards, Dave. --------------924097D01DECC9C8E2712C45 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

Hi Li,

On 16/11/2021 1:00 PM, Miao Li wrote:
This patch adds a log in main telemetry loop to show the thread is
waked up and begins to send and receive packets.

Signed-off-by: Miao Li <miao.li@intel.com>
---
 examples/l3fwd-power/main.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index 6988a0ed34..b8c020fb91 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -1156,6 +1156,9 @@ main_telemetry_loop(__rte_unused void *dummy)
 			ep_nep[nb_rx == 0]++;
 			fp_nfp[nb_rx == MAX_PKT_BURST]++;
 			poll_count++;
+			RTE_LOG(INFO, L3FWD_POWER,
+				"lcore %u is waked up on port %d queue %d\n",
+				rte_lcore_id(), portid, queueid);
 			if (unlikely(nb_rx == 0))
 				continue;


It's probably better to say "lcore %u is reading port %d queue %d".

Regards,
Dave.

--------------924097D01DECC9C8E2712C45--