From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7788FA046B for ; Wed, 26 Jun 2019 11:47:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 30E481E25; Wed, 26 Jun 2019 11:47:44 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 16C551D7 for ; Wed, 26 Jun 2019 11:47:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jun 2019 02:47:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,419,1557212400"; d="scan'208";a="337154036" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.101]) ([10.237.220.101]) by orsmga005.jf.intel.com with ESMTP; 26 Jun 2019 02:47:39 -0700 To: David Marchand , dev@dpdk.org Cc: thomas@monjalon.net, aconole@redhat.com, msantana@redhat.com References: <1559638792-8608-1-git-send-email-david.marchand@redhat.com> <1559638792-8608-12-git-send-email-david.marchand@redhat.com> From: "Burakov, Anatoly" Message-ID: Date: Wed, 26 Jun 2019 10:47:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <1559638792-8608-12-git-send-email-david.marchand@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 11/14] test/eal: check number of cores before running subtests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 04-Jun-19 9:59 AM, David Marchand wrote: > From: Michael Santana > > The eal flags unit test assumes that a certain number of cores are > available (4 and 8 cores), however this may not always be the case. > Individual developers may run the unit test on their local desktop > which typically have 2 to 4 cores, in said case the test is bound > to fail for lacking 4 or 8 cores. > > Additionally, as we push forward introducing CI into DPDK we are limited > to the hardware specification of CI services (e.g. Travis CI) that only > have 2 cores on their servers, in which case the test would fail. > > To fix this we check available cores before running a subtest. This > applies to subtests that are dedicated to test that the -l and --lcore > flags work correctly. If not enough cores are available the subtest is > simply skipped, otherwise the subtest is run. > > Signed-off-by: Michael Santana > Signed-off-by: David Marchand > --- While i think it's OK to skip tests we *can't* run without having many cores, maybe we should also look into reducing core consumption in our tests - i'm pretty sure we'll find cases where we don't really need those 8+ cores running our tests. Acked-by: Anatoly Burakov -- Thanks, Anatoly