From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 03C762C4B
 for <dev@dpdk.org>; Mon, 13 Feb 2017 17:46:11 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga105.jf.intel.com with ESMTP; 13 Feb 2017 08:46:10 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.35,156,1484035200"; d="scan'208";a="43796007"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.137])
 ([10.237.220.137])
 by orsmga002.jf.intel.com with ESMTP; 13 Feb 2017 08:46:08 -0800
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
 "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
References: <3EB4FA525960D640B5BDFFD6A3D891265274BEE4@IRSMSX108.ger.corp.intel.com>
 <1593922.H4Bo57569h@xps13>
Cc: dev@dpdk.org, "Richardson, Bruce" <bruce.richardson@intel.com>,
 "Wiles, Keith" <keith.wiles@intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <a4045879-5362-91e8-4e18-156938c74ea1@intel.com>
Date: Mon, 13 Feb 2017 16:46:06 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <1593922.H4Bo57569h@xps13>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] doc: deprecation notice for ethdev ops?
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Feb 2017 16:46:13 -0000

On 2/13/2017 4:09 PM, Thomas Monjalon wrote:
> 2017-02-13 16:02, Dumitrescu, Cristian:
>> Hi Thomas,
>>
>> When a new member (function pointer) is added to struct eth_dev_ops (as the last member), does it need to go through ABI chance process (e.g. chance notice one release before)?
>>
>> IMO the answer is no: struct eth_dev_ops is marked as internal and its instances are only accessed through pointers, so the rte_eth_devices array should not be impacted by the ops structure expanding at its end. Unless there is something that I am missing?
> 
> You are right, it is an internal struct.
> So no need of a deprecation notice.

When dpdk compiled as dynamic library, application will load PMDs
dynamically as plugin.
Is this use case cause ABI compatibility issue?

I think drivers <--> libraries interface can cause ABI breakages for
dynamic library case, although not sure how common use case this is.


> 
> We must clearly separate API and internal code in ethdev.
> 
>> My question is in the context of this patch under review for 17.5 release: http://www.dpdk.org/ml/archives/dev/2017-February/057367.html.
> 
> I did not look at it yet. Will do after the release.
> 
>