From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BAFFAA0352; Fri, 8 May 2020 22:35:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 596681DA4B; Fri, 8 May 2020 22:35:06 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id B03791DA45 for ; Fri, 8 May 2020 22:35:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588970104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=C9rhv091Jl9Y32FNVEGKrjoCWFb0xydazovsMZJwrdg=; b=ccZcWjzKmJrFyk9txLsv8HKHy7K7IqayiRim8k0/V7Rv4MrpcOBSdw2GVRJopA0Xyf6ehw GCFSv/php1/d82HDsn/r00xtG9W+jZBojNWQUe0Mo8HGkfj0TVsF29aYxJEeygL0oonsVO 0+DJqkq7p9MNb4S3hcSpF2XAX67eaNo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-396-L9iK7UDMOny5-Hcr_VU4Ig-1; Fri, 08 May 2020 16:34:59 -0400 X-MC-Unique: L9iK7UDMOny5-Hcr_VU4Ig-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DDBC3475; Fri, 8 May 2020 20:34:57 +0000 (UTC) Received: from [10.33.36.238] (unknown [10.33.36.238]) by smtp.corp.redhat.com (Postfix) with ESMTP id 348901002380; Fri, 8 May 2020 20:34:53 +0000 (UTC) To: dev@dpdk.org, hemant.agrawal@nxp.com, g.singh@nxp.com, akhil.goyal@nxp.com Cc: david.marchand@redhat.com, thomas@monjalon.net, bruce.richardson@intel.com, stable@dpdk.org References: <20200508162755.7114-1-ktraynor@redhat.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= mQINBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABtCNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPokCTgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71uQINBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABiQI2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Message-ID: Date: Fri, 8 May 2020 21:34:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200508162755.7114-1-ktraynor@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] drivers/crypto: fix gcc 10 fno-common errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" https://travis-ci.com/ovsrobot/dpdk/builds/164784623 looks to be travis run issue passing on my travis https://travis-ci.org/github/kevuzaj/dpdk-master/builds/684814829 On 08/05/2020 17:27, Kevin Traynor wrote: > gcc 10 defaults to -fno-common and as a result when linking > with crypto drivers: > > drivers/librte_pmd_dpaa_sec.a(crypto_dpaa_sec_dpaa_sec.c.o): > (.bss+0x4): multiple definition of `rta_sec_era'; > drivers/librte_pmd_caam_jr.a(crypto_caam_jr_caam_jr.c.o): > (.bss+0x0): first defined here > > drivers/librte_pmd_dpaa2_sec.a(crypto_dpaa2_sec_dpaa2_sec_dpseci.c.o): > (.data+0x0): multiple definition of `rta_sec_era'; > drivers/librte_pmd_caam_jr.a(crypto_caam_jr_caam_jr.c.o): > (.bss+0x0): first defined here > > This is a blunt fix for the issue by enabling fcommon for > dpaa_sec/dpaa2_sec/caam_jr. > > Bugzilla ID: 469 > Cc: stable@dpdk.org > > Signed-off-by: Kevin Traynor > > --- > Reverting to fcommon for crypto so it can build cleanly for rc2 as per: > http://inbox.dpdk.org/dev/4010985e-6c80-2e82-dad2-73970f89b79e@intel.com/ > --- > drivers/crypto/caam_jr/Makefile | 7 +++++++ > drivers/crypto/caam_jr/meson.build | 5 +++++ > drivers/crypto/dpaa2_sec/Makefile | 7 +++++++ > drivers/crypto/dpaa2_sec/meson.build | 5 +++++ > drivers/crypto/dpaa_sec/Makefile | 7 +++++++ > drivers/crypto/dpaa_sec/meson.build | 5 +++++ > 6 files changed, 36 insertions(+) > > diff --git a/drivers/crypto/caam_jr/Makefile b/drivers/crypto/caam_jr/Makefile > index 89d323817..10848884c 100644 > --- a/drivers/crypto/caam_jr/Makefile > +++ b/drivers/crypto/caam_jr/Makefile > @@ -15,4 +15,11 @@ CFLAGS += -O3 > CFLAGS += $(WERROR_FLAGS) > > +# FIXME: temporary solution for Bugzilla 469 > +ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > +ifeq ($(shell test $(GCC_VERSION) -ge 100 && echo 1), 1) > +CFLAGS += -fcommon > +endif > +endif > + > CFLAGS += -I$(RTE_SDK)/drivers/bus/dpaa/include > CFLAGS += -I$(RTE_SDK)/drivers/common/dpaax > diff --git a/drivers/crypto/caam_jr/meson.build b/drivers/crypto/caam_jr/meson.build > index f8b5250a9..551b13632 100644 > --- a/drivers/crypto/caam_jr/meson.build > +++ b/drivers/crypto/caam_jr/meson.build > @@ -13,4 +13,9 @@ sources = files('caam_jr_capabilities.c', > 'caam_jr.c') > > +# FIXME: temporary solution for Bugzilla 469 > +if (toolchain == 'gcc' and cc.version().version_compare('>=10.0.0')) > + cflags += '-fcommon' > +endif > + > includes += include_directories('../../bus/dpaa/include/') > includes += include_directories('../../common/dpaax/') > diff --git a/drivers/crypto/dpaa2_sec/Makefile b/drivers/crypto/dpaa2_sec/Makefile > index a0a279557..8ce637db6 100644 > --- a/drivers/crypto/dpaa2_sec/Makefile > +++ b/drivers/crypto/dpaa2_sec/Makefile > @@ -20,4 +20,11 @@ endif > endif > > +# FIXME: temporary solution for Bugzilla 469 > +ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > +ifeq ($(shell test $(GCC_VERSION) -ge 100 && echo 1), 1) > +CFLAGS += -fcommon > +endif > +endif > + > CFLAGS += -I$(RTE_SDK)/drivers/common/dpaax > CFLAGS += -I$(RTE_SDK)/drivers/common/dpaax/caamflib > diff --git a/drivers/crypto/dpaa2_sec/meson.build b/drivers/crypto/dpaa2_sec/meson.build > index cb1c2d049..505ad9414 100644 > --- a/drivers/crypto/dpaa2_sec/meson.build > +++ b/drivers/crypto/dpaa2_sec/meson.build > @@ -11,3 +11,8 @@ sources = files('dpaa2_sec_dpseci.c', > 'mc/dpseci.c') > > +# FIXME: temporary solution for Bugzilla 469 > +if (toolchain == 'gcc' and cc.version().version_compare('>=10.0.0')) > + cflags += '-fcommon' > +endif > + > includes += include_directories('mc', '../../common/dpaax', '../../common/dpaax/caamflib') > diff --git a/drivers/crypto/dpaa_sec/Makefile b/drivers/crypto/dpaa_sec/Makefile > index ea266962a..6cf392cb3 100644 > --- a/drivers/crypto/dpaa_sec/Makefile > +++ b/drivers/crypto/dpaa_sec/Makefile > @@ -14,4 +14,11 @@ CFLAGS += -O3 > CFLAGS += $(WERROR_FLAGS) > > +# FIXME: temporary solution for Bugzilla 469 > +ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > +ifeq ($(shell test $(GCC_VERSION) -ge 100 && echo 1), 1) > +CFLAGS += -fcommon > +endif > +endif > + > CFLAGS += -I$(RTE_SDK)/drivers/bus/dpaa > CFLAGS += -I$(RTE_SDK)/drivers/bus/dpaa/include > diff --git a/drivers/crypto/dpaa_sec/meson.build b/drivers/crypto/dpaa_sec/meson.build > index 7d422d8d5..f5e660457 100644 > --- a/drivers/crypto/dpaa_sec/meson.build > +++ b/drivers/crypto/dpaa_sec/meson.build > @@ -10,4 +10,9 @@ deps += ['bus_dpaa', 'mempool_dpaa', 'security'] > sources = files('dpaa_sec.c') > > +# FIXME: temporary solution for Bugzilla 469 > +if (toolchain == 'gcc' and cc.version().version_compare('>=10.0.0')) > + cflags += '-fcommon' > +endif > + > includes += include_directories('../../bus/dpaa/include') > includes += include_directories('../../common/dpaax') >