From: Ferruh Yigit <ferruh.yigit@intel.com>
To: David Liu <dliu@iol.unh.edu>
Cc: dev@dpdk.org, lylavoie@iol.unh.edu, thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH V1] testpmd: add eeprom/module eeprom display
Date: Thu, 10 Sep 2020 12:47:14 +0100 [thread overview]
Message-ID: <a416274e-387a-a714-bfa7-49b948d4e595@intel.com> (raw)
In-Reply-To: <20200910060025.23838-1-dliu@iol.unh.edu>
On 9/10/2020 7:00 AM, David Liu wrote:
> Add module EEPROM/EEPROM dump command
> "show port <port_id> (module_eeprom|eeprom)"
> Commands will dump the content of the
> EEPROM/module EEPROM for the selected port.
Hi David,
When sending a new version, can you please increase the verstion tag in the
title, V1 -> V2 -> ... -> vN
Also sending new patch as reply to previos one keep all versions in same email
thread and helps reviewers also people who later checks from archives for a feature.
For both above you can find more details in the contribution guide, please check
https://doc.dpdk.org/guides/contributing/patches.html#sending-patches
And there are a few errors below that this patch shouldn't be compiling
successfully, you can verify the build error from lab reports :)
<...>
> /* *** SHOW QUEUE INFO *** */
> struct cmd_showqueue_result {
> cmdline_fixed_string_t show;
> @@ -19325,6 +19373,8 @@ cmdline_parse_ctx_t main_ctx[] = {
> (cmdline_parse_inst_t *)&cmd_load_from_file,
> (cmdline_parse_inst_t *)&cmd_showport,
> (cmdline_parse_inst_t *)&cmd_showqueue,
> + (cmdline_parse_inst_t *)&cmd_showeeprom,
> + (cmdline_parse_inst_t *)&cmd_showmoduleeeprom,
This shouldn't compile because 'cmd_showmoduleeeprom' no more exists ...
<...>
> +
> +void
> +port_module_eeprom_displao(portid_t port_id)
> +{
There is a typo in the function name.
> + struct rte_eth_dev_module_info minfo;
> + struct rte_dev_eeprom_info einfo;
> + int ret;
> +
> + if (port_id_is_invalid(port_id, ENABLED_WARN)) {
> + print_valid_ports();
> + return;
> + }
> +
> +
> + ret = rte_eth_dev_get_module_info(port_id, &minfo);
> + if (ret != 0) {
> + switch (ret) {
> + case -ENODEV:
> + printf("port index %d invalid\n", port_id);
> + break;
> + case -ENOTSUP:
> + printf("operation not supported by device\n");
> + break;
> + case -EIO:
> + printf("device is removed\n");
> + break;
> + default:
> + printf("Unable to get module EEPROM: %d\n", len_eeprom);
I guess this is copy/paste error 'len_eeprom' is not defined in this function.
There is one more occurance below.
<...>
next prev parent reply other threads:[~2020-09-10 11:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 6:00 David Liu
2020-09-10 11:47 ` Ferruh Yigit [this message]
2020-09-10 18:48 ` David Liu
2020-09-14 15:11 ` [dpdk-dev] [PATCH V2] " David Liu
2020-09-14 16:48 ` Ferruh Yigit
2020-09-15 14:22 ` David Liu
2020-09-10 20:00 ` [dpdk-dev] [PATCH V1] " David Liu
2020-09-15 15:42 ` [dpdk-dev] [PATCH] [PATCH V2] " David Liu
2020-09-15 17:24 ` David Liu
2020-09-15 17:27 ` David Liu
2020-09-22 9:13 ` Phil Yang
2020-09-24 10:57 ` Phil Yang
2020-09-24 15:26 ` Ferruh Yigit
2020-09-10 20:12 ` [dpdk-dev] [PATCH V1 2/2] Fix coding style issues David Liu
-- strict thread matches above, loose matches on Subject: below --
2020-09-01 19:07 [dpdk-dev] [PATCH V1] testpmd: add eeprom/module eeprom display David Liu
2020-09-02 10:00 ` Ferruh Yigit
2020-09-03 16:40 ` David Liu
2020-09-03 18:40 ` Ferruh Yigit
2020-09-01 18:56 David Liu
2020-08-26 19:00 David Liu
2020-08-26 22:46 ` Ferruh Yigit
2020-08-28 13:46 ` David Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a416274e-387a-a714-bfa7-49b948d4e595@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=dliu@iol.unh.edu \
--cc=lylavoie@iol.unh.edu \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).