From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <arybchenko@solarflare.com>
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id D52911B277
for <dev@dpdk.org>; Mon, 7 Jan 2019 15:47:18 +0100 (CET)
X-Virus-Scanned: Proofpoint Essentials engine
Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
(No client certificate requested)
by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id
2066B6C00A2; Mon, 7 Jan 2019 14:47:17 +0000 (UTC)
Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com
(10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 7 Jan 2019
14:47:11 +0000
To: Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>, Thomas Monjalon
<thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@intel.com>, "Andrew
Rybchenko" <arybchenko@solarflare.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, Jerin Jacob Kollanukkaran
<jerinj@marvell.com>
References: <20190107143951.30076-1-ndabilpuram@marvell.com>
From: Andrew Rybchenko <arybchenko@solarflare.com>
Message-ID: <a43c46bf-af7d-649a-8b19-d703e1f1dd9f@solarflare.com>
Date: Mon, 7 Jan 2019 17:47:08 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <20190107143951.30076-1-ndabilpuram@marvell.com>
Content-Language: en-GB
X-Originating-IP: [91.220.146.112]
X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To
ukex01.SolarFlarecom.com (10.17.10.4)
X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24342.003
X-TM-AS-Result: No-15.646700-8.000000-10
X-TMASE-MatchedRID: HXSqh3WYKfsOwH4pD14DsPHkpkyUphL9TJDl9FKHbrn9NNg12JqGtfcI
FgSnJUR7xxL5hQ2RIPjmDTS+93Loega1NXbjqus0HcQQBuf4ZFsK3iJpXUOQQ1AoBBK61BhcyU7
XgTs6W4JR9AAfNgbn8OGEuhchvL8o8lEDYmoBkrPbH8WaUL9qjJv8tNLRPUrWv8M96e6S1b0sWV
dl3YcDsO3zSoJhBLBNn3f6KpEAv9T8/41WtiUgQwcbMHjYNxGhhZApJAdFDDabKItl61J/ycnjL
TA/UDoAoTCA5Efyn8AiEOZmeUqhz8pVBYXobMHtl5auhPfJei6d0eefv335HKWvZXSpLEcBB4gf
xqQhZBq58sdS6tZKxoXTyvQ2/c2MJW0IPVM/gsmKjmnKZg+XoDZFEgw6u+Np
X-TM-AS-User-Approved-Sender: Yes
X-TM-AS-User-Blocked-Sender: No
X-TMASE-Result: 10--15.646700-8.000000
X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24342.003
X-MDID: 1546872437-no_Tu0zRirBK
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH] ethdev: report error on name truncation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jan 2019 14:47:19 -0000
On 1/7/19 5:40 PM, Nithin Kumar Dabilpuram wrote:
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> ---
> lib/librte_ethdev/rte_ethdev.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
> index 9d5107d..bd45445 100644
> --- a/lib/librte_ethdev/rte_ethdev.c
> +++ b/lib/librte_ethdev/rte_ethdev.c
> @@ -3588,9 +3588,17 @@ rte_eth_dma_zone_reserve(const struct rte_eth_dev *dev, const char *ring_name,
> {
> char z_name[RTE_MEMZONE_NAMESIZE];
> const struct rte_memzone *mz;
> + int rc;
>
> - snprintf(z_name, sizeof(z_name), "eth_p%d_q%d_%s",
> - dev->data->port_id, queue_id, ring_name);
> + rc = snprintf(z_name, sizeof(z_name), "%s_%s_%d_%d",
> + dev->device->driver->name, ring_name,
> + dev->data->port_id, queue_id);
> +
> + if (rc >= RTE_MEMZONE_NAMESIZE) {
> + RTE_LOG(ERR, EAL, "%s(): truncated name\n", __func__);
> + rte_errno = ENAMETOOLONG;
> + return NULL;
> + }
>
> mz = rte_memzone_lookup(z_name);
> if (mz)
It is good to report an error in the case of name truncation, but the patch
does more. It changes format of the memzone name, adds the driver name
in it (what is bad since testpmd has commands to find the memzone by name
and read descriptors (hack, but sometimes very useful)).
Also I'm not sure about function name in the log message. Other places
do not have it.