From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA30045974; Fri, 13 Sep 2024 04:55:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 890854025E; Fri, 13 Sep 2024 04:55:21 +0200 (CEST) Received: from lf-2-37.ptr.blmpb.com (lf-2-37.ptr.blmpb.com [101.36.218.37]) by mails.dpdk.org (Postfix) with ESMTP id 259BC40156 for ; Fri, 13 Sep 2024 04:55:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=feishu2403070942; d=yunsilicon.com; t=1726196111; h=from:subject: mime-version:from:date:message-id:subject:to:cc:reply-to:content-type: mime-version:in-reply-to:message-id; bh=s1oK2q3m7SKKUFrUc0YW4iwsjLAPQo7jSXM+oseQqvw=; b=VpOqCOvB1gbXgOIpw8deDwOkKVDxUt7CUkC9vaKqOF4v4wbWR/SjerXRBsFfVnZ54j7s0X 04Y4WayUmqmbPH6aexbAdmbRuw873IgJAPS6LUqULJ893OdLs/+qJ+I4zUmJMg8US+Lf9e cOkomFqosoLhMNw/1/0cHn9mQbzW3bR5gqdcV7fPDgh9U995vPh7eFEESeey2KPznWlMtY 99YnnvZFH4zgIX1YqvwunUvxXhSc9m09xzztnPAbZI8X7103looCfQcEPgPrgYtIBj5XQu DAncQgsQ2qRRfvXCiW4TOBJs4Lrw9YO96N+xiBd7/m88+84vj0yQiyXjTEC/Dw== Subject: Re: [PATCH v2 05/19] net/xsc: add ioctl command interface Message-Id: Mime-Version: 1.0 X-Original-From: WanRenyong User-Agent: Mozilla Thunderbird From: "WanRenyong" Date: Fri, 13 Sep 2024 10:55:08 +0800 X-Lms-Return-Path: In-Reply-To: <7c5d74b1-2d69-4595-b966-4044b6f7c698@huawei.com> Cc: , , Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable References: <20240911020740.3950704-6-wanry@yunsilicon.com> <20240910205058.25bf5f8c@hermes.local> <8cf9b5e8-cab4-45e6-b959-1d87f8a8ea99@yunsilicon.com> <20240911225021.16839cb2@hermes.local> <1ff7f17e-181b-49da-8f84-bf430f449dec@yunsilicon.com> <7c5d74b1-2d69-4595-b966-4044b6f7c698@huawei.com> To: "fengchengwen" , "Stephen Hemminger" Received: from [127.0.0.1] ([222.64.242.227]) by smtp.feishu.cn with ESMTPS; Fri, 13 Sep 2024 10:55:09 +0800 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024/9/12 17:18, fengchengwen wrote: > On 2024/9/12 16:19, WanRenyong wrote: >> On 2024/9/12 13:50, Stephen Hemminger wrote: >>> On Thu, 12 Sep 2024 12:14:08 +0800 >>> "WanRenyong" wrote: >>> >>>>> =20 >>>>>> +}; >>>>>> + >>>>> Does this device driver depend on some upstr >>>> Yes, it depends on linux kernel driver of the device. >>>> >>>> Hello, Stephen, >>>> >>>> Thanks for your review,=C2=A0 please see above. >>> What is the driver? I don't see in the current kernel.org tree. >>> >>> >>> My concern is that if the driver is not upstream, it is probably not >>> going to pass the review of kernel developers. This means security and >>> API changes would be required. >>> >>> Ioctl's are considered the worst API to the kernel and unlikely >>> to be accepted. >> Hello, Stephen, >> >> Thank you for reply.Our kernel driver is being prepared to open source. >> >> Our PMD is going to coexist with kernel driver to support flow >> bifurcation feature. > It seemed uacce bus could handle this, so that you could use several queu= es on DPDK, and > steer flows to these queues by bifurcation feature. > >> Ioctl API is used for interaction between PMD and kernel driver. As you >> said, ioctl is >> >> the worst API, should I consider using read and write instead? > It seemed the ioctl couldn't handle VF located in VM, and interact=20 > with PF driver which run in host kernel. >> If not, could you please give me some advice? > If your NIC support firmware, could consider use firmware as mid-man betw= een DPDK and kernel. > >> Hello, fengchenwen, Thanks for your reply. Sorry for not describing it clearly. We know how to implement the=20 bifurcation functionality. The main issue is that ioctl is used=20 forcommunication with the kernel driver by PMD, but ioctl is not=20 considered a good API, we need to find a better approach. Implemented=20 via firmware might be a good idea, but it's complex, we can think about=20 it in the further.Recently shoud I consider using read and write=20 instead?=C2=A0 Is there any advise? --=20 Thanks, WanRenyong