From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20680432E9; Thu, 9 Nov 2023 19:51:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF60A4064A; Thu, 9 Nov 2023 19:51:07 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2066.outbound.protection.outlook.com [40.107.223.66]) by mails.dpdk.org (Postfix) with ESMTP id B21594026B for ; Thu, 9 Nov 2023 19:51:05 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KqAFsGogWiooeKh/cbdtDLafgfQqP56LNAsC6+sg0taRvvvve7sGuKBdysh9FajDcsKlnYhFC9TjrlGIQutr5ACngk/HNSOzEnJte4Uzu1Gc4UiMhB399YjHDrp5V2PS6M2G54jPLUQY1AfqFFs3fNbLnWHd3eJgZqiVNS5G0qdN0SbDdLwwcp+4yYVIEX0Oi0vjIMsZS1IUYOD0A3ogQsN5EfsfJEsr4Kxn6AKNqRsoQJ4WM7SYT6Ug5mIXX6wxlwv6r5HXQaP4+f1bxbRxpOHG0Tt9jY+1eih83tWvgiledEZaXPiArCEEs8qUzKL/86vtYAM5wPmOpGLU9Yc5qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WEpL9dVAsq/Xth4ExGj5ApVonuqHl9NWPCG0ul/RhCU=; b=cLyyNAtTee+MnKB/0Q30+yvHHtNt7S5DENAQeBPnCLPW6IJkpVK9mk0Q7LL4Pivs4VI8Xt9eCCWyXimQF9OU9Zc2lSxrKE6URqkqTiRCtTBfSdEdmH1Lk48ibPSNqUWdABOseDP9hlicEnM7rE6tV1QTN8jnpehpMrfj7MVk1bWtFUGrPC5QH5QJI+t3CD86zrlH0LpPx90txkuLTt1N3yK/oJw5NB64CP9+wbQY/1A+e8GQaKndIkXj/eeHHmNIUcaKkap7KpmewkvMzyHj3C4+3Blx50bRMsVmL6UNQcDAih0HkbdjFB4edp5TKqOc7QA8kgmYp/F8THvagDYhVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WEpL9dVAsq/Xth4ExGj5ApVonuqHl9NWPCG0ul/RhCU=; b=Mw+9+xH5bKsKYMjGX0x8IvKOw2cfiQFsL8uxul4JF7eTntYDMzxgkO/1JebmsqO6wl9YERISmxYILVUbT1QP5dzlekO10cPhDiYUtu0K9ldhlaKDh+fRAQvHIey69uELCfHB2qNt4azULSlPWLCNS1IGN7im6XCp5x4fOy6XxkQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB6441.namprd12.prod.outlook.com (2603:10b6:510:1fb::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.29; Thu, 9 Nov 2023 18:51:01 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.6954.029; Thu, 9 Nov 2023 18:51:00 +0000 Message-ID: Date: Thu, 9 Nov 2023 18:50:39 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] net/hns3: fix and refactor mailbox code Content-Language: en-US To: Jie Hai , dev@dpdk.org References: <20231108034434.559030-1-haijie1@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231108034434.559030-1-haijie1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0259.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b5::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB6441:EE_ X-MS-Office365-Filtering-Correlation-Id: 79e57fa5-9711-4579-9a8b-08dbe154d12a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /8L9mOjxObSN/wb4H+pczZZr+01L32D4WgsPvPuysvVmC5HTF7lnaB/wPA5DDgmaCCuUu6MpMfmVRJeYoMrG1HKQGVu2j4X9wFnM8REmwir/dCy2O0U+Ye9h9P7bffPcs40lMzvtrfZaKPK174aiC8lgnBKxqoM1hw8ZfK/5L+/kDjJbrFTZCsiJtdLZ2t0KmQIfOLBJQCTv0uPHvJkNfr3HR/Y5sdP6CgQ+T1eCfwdktXeiKGYgxiLnfXyHrr8rlbA9L2tL6VztU9EihMQljT3xj5sxHQLJH7nRc5bLCLGfeTcoR1j/IQs0JaP6Z/3IV4Kfv/kvDlMJVRrifuQuG5th6O8W9GJmZ4sEvWGG/GMy/ps1joKzf4Psi61KwUQuccseZkTXyY5X7JiSrbKm/PUXhwGZq4/D15WBNyalcIDZopZPcdgngrIQFkKF3mHRjsOX6je/x34cXNx3lW2cBm/p7LIjBtR4/H360BAvguVnBnvoepJER7q6NRs5D5NZbV2AT1JbCHqB6Eqv+kZwkTtqQLMlDeMlqLRY3y+cEfzMBBuMqfS7Cjw58LdLe/zZNm6TVkq3nJ90Rzu1Pxpi0HMS/fWOqXyFZntZvEn1hfKwI+NcXtHV+0vA0EnuJ/BxrdJRRnCw/EKwV8aBzmiOBWsrJluJTzNRqzOxq4Hk3lGnHZ+sS1bE97NCE8two1o+LZOY5q87nKZ9uVMTFETdag== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(230273577357003)(230922051799003)(230173577357003)(1800799009)(186009)(451199024)(2906002)(31686004)(44832011)(5660300002)(15650500001)(8936002)(6666004)(6486002)(4744005)(66556008)(66946007)(66476007)(508600001)(8676002)(53546011)(6512007)(26005)(2616005)(6506007)(83380400001)(36756003)(38100700002)(31696002)(86362001)(21314003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RTFZWkVBVmZKVVJDQU1vRHRmOWdVeFRMSW5KZEZocUkvUE9HVndQSU54VGs4?= =?utf-8?B?QkE2empQcmIyY2ZyN0pwVWNEZ1MvbVFjdnZaRnR4b1kzZ1B6cUFlQWZJVVBT?= =?utf-8?B?N2hPdElvZ2Z4UVB6Z1NUTk43Q1hyclVaRW5EYzc1R2NCSERQcENoTlU0cVU3?= =?utf-8?B?TFZ2UnhPSG1GNVEraWZ2eU5BS2w5OEMwZmxsMzBNekxhaGdtUUtPWXRBVUZi?= =?utf-8?B?QkE4bnpjTmVHSEtkQlRqQnR2am9FcXEwMGRoMGFNaXduRjdWOTZZbFczRC9q?= =?utf-8?B?aWQ2QTRSRExKYXU3VFB0NHlQMlFHOUpSbVNrZjd0aHhKSm5Gbk5QT1ZINFcy?= =?utf-8?B?V21JdVdYMWM0RXhXVjFhWlROU1Vjc3NHN2xuZVhsbCtxZFMyY0dPUTdVWmth?= =?utf-8?B?ZkpVeXFtNkc2NURLV255T1U4MXNtcGNKdHMzZEJ4c1l3TFZZeXpKUHlNUG44?= =?utf-8?B?cEo3WitwWCt4Zjc3VUJjMndsbUR1eGtodE12Z0ZrZHRDU1IvMTY4UE9jRisv?= =?utf-8?B?K2Jjc2p2Q08vYzljbTExZjJtUzQxVTdJenowSEVrcFZDODRGN3NydGNmRnZC?= =?utf-8?B?ZS9IZ3pjT04zSHl6TTArbTBBUXE2VlZVVi9Wem9TYTNFMEhvdnNnSTljQjZG?= =?utf-8?B?eTMyQU9WNlZVRzc2QnJmQUlHdmFQZTgzUVU3MkFiTytxcWpFVVoxSk0zTEFv?= =?utf-8?B?dlV5QmxpUllMZVZXeC9pUkV5WVYxS3FkT3lMQzVWWHJneUdkRE5KaEVROFFs?= =?utf-8?B?SWNNOEFiSHZBWUhkYklGWGRUS2xpTCtTeWt6cVRWS3FKT1BYc2J6ZW1MQ2NY?= =?utf-8?B?ZDgvUGZ3cWMvS1pWdWhJM2p3aEtVWDhIbm5JTGVBUzdWZWVRczhTNUVnMGN4?= =?utf-8?B?b0JPMmV3VTFjMmM4YnFLemF0L20zMWFaVjgvb1NMSUdaeFkyU1Q3TStKaXor?= =?utf-8?B?ZTMxVkFhMzJLWVpUQnVTSUxYT05aaUhieFRCNFd4RWV4ZlgyQk5Od1B0R3lm?= =?utf-8?B?QkowL05KVXhOeTdqN1RrdUcwZnJCaStkWFB0UTZKZC84Mk9uNEEwZVhGYVB3?= =?utf-8?B?TjdDNDJsTEl1SkorWW1XcU11TnZpMzJWc2NMaUlJWGxZdTQrQVRPazFIT21X?= =?utf-8?B?SEw1amFxUm1Qb1k2U1VjSXJnTDNVRzczODRFY0J3ZXkyM0czejhrM2VuaFZQ?= =?utf-8?B?bVFsN2U0QWRIYVNtVTU2M1ZVd29nTDNVQWY3aWFTbEhwZmpmVEwwVmdWZHkv?= =?utf-8?B?NmN3N21lbXdENEJQck01N3I1Yy8wVWd6QUcwVXRSNUpZclR0VEFwWjVLNXM1?= =?utf-8?B?bm9BeE4yTlk4MEJOMzBWc2U1cmVIdkxOckVuVk9OWklwY0E2Sy9LWXcySXhL?= =?utf-8?B?SXlWM00zRnc3VGF4dVhWQ0ppYU1RSU5JT2srd2kxWWZsbHpoMFlvVnRMNlIv?= =?utf-8?B?WTcxckJYcWwwbW1QSHZSL0lhSG85WVlWWGFaVTVGYTU0ZHJTbkJqazYzbkNY?= =?utf-8?B?Y2Z6ci9heGtjVFp3Wk0xN0NuUGNZTmhsYkU2R2t4b1BkZHprTm5pTEtCZUJp?= =?utf-8?B?Y3BxVVBVdnhtSGRoT0ZnSlVYYk1DbGorUnlHT2FsTDJWdkhJckU0N2xjM0Iz?= =?utf-8?B?QXZQT1liU1RkeVpCQitXQkc0NmdkcTJ2TFN6MS81MGYvektQYkxTdDJobFNJ?= =?utf-8?B?VUNNTURFUUFvRmxYU01hWndoR0Q0emVUREphaVNsS3plN0JtMk5WK1NseVRS?= =?utf-8?B?bnFpSzJaMnY2b1hSZjg3YmZCUmprczhRQmlsaVpOeVI0akRMeVlXRTE3ZW9N?= =?utf-8?B?bHRiMnhaWTYxaUJrS0lBMTZlTEI0RWtJN2s0MjhXMjBXc3Y2aDd6d0h5SjZT?= =?utf-8?B?eDhacWU1bEowS1oyRlo5Z1RuZWlnaXNFemtHZVJidERtL2RkN3FkeHJQNHho?= =?utf-8?B?K2dJaWZ2eUNLUk96V2xMZHdxdENRSTR6V0FsMU92UWp3d1JnWGczbmRDWm5F?= =?utf-8?B?Y09Rb2syU1k4VitNT2szMVhqR2pjZ1lvQ25KdEZyRHJsRUtsN3NDc2RiVmFF?= =?utf-8?B?VWF4MFozYi9FbTE4Ymtjc2d1OGQ4bUdBR3Vlc0pYb1FQYjFvKzhsdktVdVp5?= =?utf-8?Q?G1S8=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79e57fa5-9711-4579-9a8b-08dbe154d12a X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2023 18:51:00.8702 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OO+/sYYAVNgq0CdIhJlahNYeNyeqGJ7yY0dKF55VcNGztvJzjR03+FuG0n81xQhO X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6441 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/8/2023 3:44 AM, Jie Hai wrote: > This patchset fixes failure on sync mailbox and refactors some codes on mailbox. > > Dengdui Huang (5): > net/hns3: fix sync mailbox failure forever > net/hns3: refactor VF mailbox message struct > net/hns3: refactor PF mailbox message struct > net/hns3: refactor send mailbox function > net/hns3: refactor handle mailbox function > Hi Jie, Overall patchset looks good with minor issue below [1], but this set has high impact and not solving a critical defect etc, but mainly refactoring. We are very close to the release, there won't be enough time to fix any issue caused by this refactoring. My suggestion is to postpone the refactoring to next release, maybe get only the first fix patch in this release, what do you think? [1] Can you please fix the checkpatch warning: ### [PATCH] net/hns3: refactor handle mailbox function Warning in drivers/net/hns3/hns3_mbx.c: Using __atomic_xxx/__ATOMIC_XXX built-ins, prefer rte_atomic_xxx/rte_memory_order_xxx