From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 044DFE5D
 for <dev@dpdk.org>; Mon,  4 Dec 2017 20:53:46 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 04 Dec 2017 11:53:45 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.45,361,1508828400"; 
   d="scan'208";a="8987357"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.178])
 ([10.241.225.178])
 by FMSMGA003.fm.intel.com with ESMTP; 04 Dec 2017 11:52:59 -0800
To: Jingjing Wu <jingjing.wu@intel.com>, dev@dpdk.org
Cc: wenzhuo.lu@intel.com
References: <1508488012-82704-1-git-send-email-jingjing.wu@intel.com>
 <1511505206-97333-1-git-send-email-jingjing.wu@intel.com>
 <1511505206-97333-3-git-send-email-jingjing.wu@intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <a46baac5-7193-cc52-0a4e-2ab2e146bbce@intel.com>
Date: Mon, 4 Dec 2017 11:52:59 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <1511505206-97333-3-git-send-email-jingjing.wu@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v2 02/14] net/avf: initilization of avf PMD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Dec 2017 19:53:47 -0000

On 11/23/2017 10:33 PM, Jingjing Wu wrote:
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>

<...>

> @@ -37,6 +37,7 @@ ifeq ($(CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD),d)
>  endif
>  
>  DIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += af_packet
> +DIRS-$(CONFIG_RTE_LIBRTE_AVF_PMD) += avf

Can you please add this alphabetically?

<...>

> +OBJS_BASE_DRIVER=$(patsubst %.c,%.o,$(notdir $(wildcard $(SRCDIR)/base/*.c)))
> +$(foreach obj, $(OBJS_BASE_DRIVER), $(eval CFLAGS_$(obj)+=$(CFLAGS_BASE_DRIVER)))

There is no CFLAGS_BASE_DRIVER yet, you can add these lines when some
CFLAGS_BASE_DRIVER added.

<...>

> @@ -37,7 +37,7 @@
>  extern int avf_logtype_init;
>  #define PMD_INIT_LOG(level, fmt, args...) \
>  	rte_log(RTE_LOG_ ## level, avf_logtype_init, "%s(): " fmt "\n", \
> -		__func__, ##args)
> +		__func__, ## args)

Can you please squash this one to previous patch?

<...>

> +/**
> + * avf_check_api_version
> + * @dev: pointer to eth device

There is no "dev" parameter to the API.

<...>

> @@ -120,6 +120,7 @@ _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_STACK)  += -lrte_mempool_stack
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET)  += -lrte_pmd_af_packet
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_ARK_PMD)        += -lrte_pmd_ark
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_AVP_PMD)        += -lrte_pmd_avp
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_AVF_PMD)        += -lrte_pmd_avf

Can you please add this alphabetically?