From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id A5BC51B7A0 for ; Wed, 11 Apr 2018 10:43:26 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Apr 2018 01:43:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,435,1517904000"; d="scan'208";a="31215917" Received: from dhunt5-mobl2.ger.corp.intel.com (HELO [10.237.221.55]) ([10.237.221.55]) by fmsmga007.fm.intel.com with ESMTP; 11 Apr 2018 01:43:24 -0700 To: Thomas Monjalon , Ferruh Yigit , "Mcnamara, John" Cc: dev@dpdk.org, "shreyansh.jain@nxp.com" References: <1495788764-37652-2-git-send-email-david.hunt@intel.com> <1709610.YWM5RO7iyE@xps> From: "Hunt, David" Message-ID: Date: Wed, 11 Apr 2018 09:44:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1709610.YWM5RO7iyE@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v3 3/3] doc: update build-sdk-quick txt file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Apr 2018 08:43:27 -0000 Hi Thomas On 13/2/2018 11:41 PM, Thomas Monjalon wrote: > 13/02/2018 13:18, Ferruh Yigit: >> On 6/12/2017 1:50 PM, Mcnamara, John wrote: >>>> -----Original Message----- >>>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Hunt >>>> Sent: Wednesday, June 7, 2017 3:38 PM >>>> To: dev@dpdk.org >>>> Cc: thomas@monjalon.net; shreyansh.jain@nxp.com; Hunt, David >>>> >>>> Subject: [dpdk-dev] [PATCH v3 3/3] doc: update build-sdk-quick txt file >>>> >>>> * Add in information about 'make defconfig' >>>> * Add in information about RTE_TEMPLATE environment variable >>>> * Explain the default directory for 'O=' a bit better >>>> * Clean up text alignment >>>> >>>> Signed-off-by: David Hunt >>> Acked-by: John McNamara >> Acked-by: Ferruh Yigit > I made some comments in patch 2 about RTE_TEMPLATE and got no reply > (in August). Since you correctly point out that "make install T=" is an old syntax, and this variable only encourages this, let's drop this patch altogether. There are two patches in patchwork relevant to this cahange, one is the change, and the other is the docs update. There was a third part, which was for the "make defconfig" functionality, which has already been merged, including a portion of 25113, so both of the following can be closed off. http://dpdk.org/dev/patchwork/patch/25112/ http://dpdk.org/dev/patchwork/patch/25113/ > This patch is dependent on RTE_TEMPLATE. > > One more nit: the indent is broken for T variable explanation.