From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 1D2847D4E for ; Wed, 17 Oct 2018 19:08:09 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Oct 2018 10:08:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,393,1534834800"; d="scan'208";a="273253918" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49]) ([10.237.221.49]) by fmsmga006.fm.intel.com with ESMTP; 17 Oct 2018 10:08:08 -0700 To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= Cc: Stephen Hemminger , Adrien Mazarguil , thomas@monjalon.net, dev@dpdk.org References: <20181011175940.6800-1-stephen@networkplumber.org> <98717fc3-c3dd-cc4f-e5ff-b5310e47d6ee@intel.com> <696e6f90-3d0c-acd4-d72d-bbebe1ff6f54@intel.com> <20181012124357.GR18937@6wind.com> <20181012075424.79383f32@xeon-e3> <2ed85850-f6f3-1f99-375b-85910479a9a2@intel.com> <20181017092631.bklpipmyfeatvotv@bidouze.vm.6wind.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= xsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsGVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBNI2U4dCLsKE45mBx/kz60PfE2EfBQJbughWBQkHwjOGAAoJEPkz60Pf E2Eft84QAIbKWqhgqRfoiw/BbXbA1+qm2o4UgkCRQ0yJgt9QsnbpOmPKydHH0ixCliNz1J8e mRXCkMini1bTpnzp7spOjQGLeAFkNFz6BMq8YF2mVWbGEDE9WgnAxZdi0eLY7ZQnHbE6AxKL SXmpe9INb6z3ztseFt7mqje/W/6DWYIMnH3Yz9KzxujFWDcq8UCAvPkxVQXLTMpauhFgYeEx Nub5HbvhxTfUkapLwRQsSd/HbywzqZ3s/bbYMjj5JO3tgMiM9g9HOjv1G2f1dQjHi5YQiTZl 1eIIqQ3pTic6ROaiZqNmQFXPsoOOFfXF8nN2zg8kl/sSdoXWHhama5hbwwtl1vdaygQYlmdK H2ueiFh/UvT3WG3waNv2eZiEbHV8Rk52Xyn2w1G90lV0fYC6Ket1Xjoch7kjwbx793Kz/RfQ rmBY8/S4DTGn3oq3dMdQY+b6+7VMUeLMMh2CXYO9ErkOq+qNTD1IY+cBAkXnaDbQfz0zbste ZGWH74FAZ9nCpDOqbRTrBL42aMGhfOWEyeA1x7+hl6JZfabBWAuf4nnCXuorKHzBXTrf7u7p fXsKQClWRW77PF1VmzrtKNVSytQAmlCWApQIw20AarFipXmVdIjHmJPU611WoyxZPb4JTOxx 5cv9B+nr/RIB+v5dcStyHCCwO1be7nBDdCgd4F6kTQPLzsFNBFfWTL4BEACnNA29e8TarUsB L5n6eLZHXcFvVwNLVlirWOClHXf44o2KnN3ww+eBEmKVfEFo9MSuGDNHS8Zw1NiGMYxLIUgd U6gGrVVs/VrQWL82pbMk6jCj98N+BXIri+6K1z+AImz7ax7iF1kDgRAnFWU0znWWBgM2mM8Y gDjcxfXk4sCKnvf6Gjo08Ey5zmqx7dekAKU2EEp8Q1EJY3jbymLdZWRP4AFFMTS1rGMk0/tt v71NBg1GobCcbNfn9chK/jhqxYhAJqq86RdJQkt3/9x1U1Oq0vXCt4JVVHmkxePtUiuWTTt+ aYlUAsKYZsWvncExvw77x2ArYDmaK0yfjh37wp0lY7DOJHFxoyT8tyWZlLci/VMRG2Ja33xj 0CN4C1yBg+QDeV3QFxQo42iA/ykdXPUR3ezmsND3XKvVLTC4DNb3V/EZQ7jBj64+bEK0VW4G B31VP00ApNQvSoczsIOAKdk97RNbpmPw6q10ILIB+9T1xbnFYzshzGF17oC0/GENIHATx8vZ masOZoDiOZQpeneLgnFE9JfzhLTxv6wNZcc/HLXRQVTkDsQr8ERtkAoHCf1E5+b5Yr7pfnE4 YuhET746o25S53ELUYPIs49qoJsEJL34/oexMfPGyPIlrbufiNyty5jc/1MRwUlhJlJ5IOHy ZUa+6CLR7GdImusFkPJUJwARAQABwsF8BBgBAgAmAhsMFiEE0jZTh0IuwoTjmYHH+TPrQ98T YR8FAlu6CHAFCQXE7zIACgkQ+TPrQ98TYR9nXxAAqNBgkYNyGuWUuy0GwDQCbu3iiMyH1+D7 llafPcK4NYy1Z4AYuVwC9nmLaoj+ozdqS3ncRo57ncRsKEJC46nDJJZYZ5LSJVn63Y3NBF86 lxQAgjj2oyZEwaLKtKbAFsXL43jv1pUGgSvWwYtDwHITXXFQto9rZEuUDRFSx4sg9OR+Q6/6 LY+nQQ3OdHlBkflzYMPcWgDcvcTAO6yasLEUf7UcYoSWTyMYjLB4QuNlXzTswzGVMssJF/vo V8lD1eqqaSUWG3STF6GVLQOr1NLvN5+kUBiEStHFxBpgSCvYY9sNV8FS6N24CAWMBl+10W+D 2h1yiiP5dOdPcBDYKsgqDD91/sP0WdyMJkwdQJtD49f9f+lYloxHnSAxMleOpyscg1pldw+i mPaUY1bmIknLhhkqfMmjywQOXpac5LRMibAAYkcB8v7y3kwELnt8mhqqZy6LUsqcWygNbH/W K3GGt5tRpeIXeJ25x8gg5EBQ0Jnvp/IbBYQfPLtXH0Myq2QuAhk/1q2yEIbVjS+7iowEZNyE 56K63WBJxsJPB2mvmLgn98GqB4G6GufP1ndS0XDti/2K0o8rep9xoY/JDGi0n0L0tk9BHyoP Y7kaEpu7UyY3nVdRLe5H1/MnFG8hdJ97WqnPS0buYZlrbTV0nRFL/NI2VABl18vEEXvNQiO+ vM8= Message-ID: Date: Wed, 17 Oct 2018 18:08:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181017092631.bklpipmyfeatvotv@bidouze.vm.6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] ethdev: add function name to log message X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2018 17:08:10 -0000 On 10/17/2018 10:26 AM, Gaëtan Rivet wrote: > Hi Ferruh, > > On Tue, Oct 16, 2018 at 04:55:43PM +0100, Ferruh Yigit wrote: >> On 10/12/2018 3:54 PM, Stephen Hemminger wrote: >>> On Fri, 12 Oct 2018 14:43:57 +0200 >>> Adrien Mazarguil wrote: >>> >>>> On Fri, Oct 12, 2018 at 11:45:01AM +0100, Ferruh Yigit wrote: >>>>> On 10/12/2018 11:42 AM, Ferruh Yigit wrote: >>>>>> On 10/11/2018 6:59 PM, Stephen Hemminger wrote: >>>>>>> @@ -161,8 +161,9 @@ extern "C" { >>>>>>> >>>>>>> extern int rte_eth_dev_logtype; >>>>>>> >>>>>>> -#define RTE_ETHDEV_LOG(level, ...) \ >>>>>>> - rte_log(RTE_LOG_ ## level, rte_eth_dev_logtype, "" __VA_ARGS__) >>>>>>> +#define RTE_ETHDEV_LOG(level, fmt, ...) \ >>>>>>> + rte_log(RTE_LOG_ ## level, rte_eth_dev_logtype, \ >>>>>>> + "%s():" fmt, __func__, ## __VA_ARGS__) >>>>>> >>>>>> +1 to adding function name, but >>>>>> >>>>>> failsafe is giving build error [1] with clang because of ## usage [2], that is >>>>>> why I add this as ` "" __VA_ARGS__` at first place but you can't do this trick >>>>>> if __VA_ARGS__ used after fmt. >>>>>> >>>>>> I am not aware of a solution for this, __VA_OPT__(,) also didn't worked with clang. >>>>> >>>>> +cc Adrien & Gaetan, >>>>> >>>>> I saw Adrien put some "workaround" to this for mlx5 >>>> >>>> Yes, through RTE_FMT() (rte_common.h). Something like this: >>>> >>>> #define RTE_ETHDEV_LOG(level, fmt, ...) \ >>>> rte_log(RTE_LOG_ ## level, \ >>>> rte_eth_dev_logtype, \ >>>> "%s():" fmt, \ >>>> __func__, \ >>>> ## __VA_ARGS__) >>>> >>>> Can be rewritten like that: >>>> >>>> #define RTE_ETHDEV_LOG(level, ...) \ >>>> rte_log(RTE_LOG_ ## level, \ >>>> rte_eth_dev_logtype, \ >>>> RTE_FMT("%s():" RTE_FMT_HEAD(__VA_ARGS__,), \ >>>> __func__, \ >>>> RTE_FMT_TAIL(__VA_ARGS__,))) >>>> >>>> Although not too pretty and convenient, it does the job. In short: >>>> >>>> - Remove "fmt" argument from prototype. >>>> - Enclose format string and its arguments in RTE_FMT(). >>>> - Replace "fmt" with RTE_FMT_HEAD(__VA_ARGS__,). >>>> - Replace "## __VA_ARGS__" with RTE_FMT_TAIL(__VA_ARGS__,). >>>> - Yes, trailing commas are mandatory in RTE_FMT_(HEAD|TAIL)(). >>>> - Note it quietly appends a dummy "%.0s" argument to the format string. >>>> >>>>>> [1] >>>>>> .../build/include/rte_ethdev.h:166:26: error: token pasting of ',' and >>>>>> __VA_ARGS__ is a GNU extension [-Werror,-Wgnu-zero-variadic-macro-arguments] >>>>>> "%s():" fmt, __func__, ## __VA_ARGS__) >>>>>> ^ >>>>>> >>>>>> [2] >>>>>> This seems because of "-pedantic" argument driver uses, and other PMDs using >>>>>> "-pedantic", like mlx, will have same error although they are disable by >>>>>> default and error not observed in default build. >>>>>> >>>>> >>>> >>> >>> Since zero varadic macros is a GNU extension, maybe just adding GNU source? >> >> I think `-pedantic` is preventing using extension whether we have `_GNU_SOURCE` >> or not. >> >> Gaetan, >> >> Why we have `-pedantic` option enabled for failsafe? > > Because I wanted to enforce it in failsafe, and core DPDK headers were > compatible so it wasn't too much of a hassle. > > If rte_ethdev.h is meant to lose this compatibility, then pedantic will > be disabled upon including it. But I guess if it was kept compatible > until now, then it was a deliberate effort? I think it is deliberate effort, I remember Adrien put some patches in the past to make DPDK headers pedantic compatible by adding __extension__ keywords. I tried to use __extension__ for ## but not able to make it work, is there a way to do this? And I see the reasoning of making DPDK headers pedantic compatible, I think we should keep them compatible.