DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
To: "jerinj@marvell.com" <jerinj@marvell.com>,
	"jay.jayatheerthan@intel.com" <jay.jayatheerthan@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"ganapati.kundapura@intel.com" <ganapati.kundapura@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eventdev: fix Rx adapter stalls on event device backpressure
Date: Mon, 8 Nov 2021 13:43:34 +0000	[thread overview]
Message-ID: <a49c44fc-7eba-920e-8f58-6a98dcc4a8bc@ericsson.com> (raw)
In-Reply-To: <20211108132558.28748-1-mattias.ronnblom@ericsson.com>

On 2021-11-08 14:25, Mattias Rönnblom wrote:
> In the Eventdev Ethernet RX Adapter, correctly handle the case where
> the circular enqueue buffer head and tail index points to the same
> element (i.e., the buffer is full) and the buffer has wrapped.
>
> This bug may be triggered in case there is backpressure from the event
> device to the RX adapter.
>
> Fixes: 8113fd15e229 ("eventdev/eth_rx: make enqueue buffer circular")
> Cc: ganapati.kundapura@intel.com
> Cc: stable@dpdk.org


Disregard the stable cc. This bug does not appear in any released DPDK 
version (e.g., 21.08).


> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> ---
>   lib/eventdev/rte_event_eth_rx_adapter.c | 22 ++++++++++++++--------
>   1 file changed, 14 insertions(+), 8 deletions(-)
>
> diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
> index 56318b5a6f..809416d9b7 100644
> --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> @@ -777,19 +777,25 @@ rxa_flush_event_buffer(struct event_eth_rx_adapter *rx_adapter,
>   		       struct eth_event_enqueue_buffer *buf,
>   		       struct rte_event_eth_rx_adapter_stats *stats)
>   {
> -	uint16_t count = buf->last ? buf->last - buf->head : buf->count;
> +	uint16_t count = buf->count;
> +	uint16_t n = 0;
>   
>   	if (!count)
>   		return 0;
>   
> -	uint16_t n = rte_event_enqueue_new_burst(rx_adapter->eventdev_id,
> -					rx_adapter->event_port_id,
> -					&buf->events[buf->head],
> -					count);
> -	if (n != count)
> -		stats->rx_enq_retry++;
> +	if (buf->last)
> +		count = buf->last - buf->head;
> +
> +	if (count) {
> +		n = rte_event_enqueue_new_burst(rx_adapter->eventdev_id,
> +						rx_adapter->event_port_id,
> +						&buf->events[buf->head],
> +						count);
> +		if (n != count)
> +			stats->rx_enq_retry++;
>   
> -	buf->head += n;
> +		buf->head += n;
> +	}
>   
>   	if (buf->last && n == count) {
>   		uint16_t n1;



  reply	other threads:[~2021-11-08 13:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-08 13:25 Mattias Rönnblom
2021-11-08 13:43 ` Mattias Rönnblom [this message]
2021-11-09  6:26   ` Kundapura, Ganapati
2021-11-09  8:28     ` Mattias Rönnblom
2021-11-09 11:09       ` Kundapura, Ganapati
2021-11-09 11:43         ` Mattias Rönnblom
2021-11-10  8:26       ` Kundapura, Ganapati
2021-11-10 10:08         ` Jayatheerthan, Jay
2021-11-10 11:11           ` Mattias Rönnblom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a49c44fc-7eba-920e-8f58-6a98dcc4a8bc@ericsson.com \
    --to=mattias.ronnblom@ericsson.com \
    --cc=dev@dpdk.org \
    --cc=ganapati.kundapura@intel.com \
    --cc=jay.jayatheerthan@intel.com \
    --cc=jerinj@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).