From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 074364CA6 for ; Fri, 21 Sep 2018 03:21:43 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Sep 2018 18:21:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,282,1534834800"; d="scan'208";a="71695485" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.22.231]) ([10.252.22.231]) by fmsmga007.fm.intel.com with ESMTP; 20 Sep 2018 18:21:42 -0700 To: Yogev Chaimovich , "dev@dpdk.org" References: <1537170493-83190-1-git-send-email-yogev@cgstowernetworks.com> <1537425577-86337-1-git-send-email-yogev@cgstowernetworks.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: Date: Fri, 21 Sep 2018 02:21:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1537425577-86337-1-git-send-email-yogev@cgstowernetworks.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] vmxnet3: stats_reset implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2018 01:21:44 -0000 On 9/20/2018 7:37 AM, Yogev Chaimovich wrote: > 'stats_reset()' callback was missing because the device backend doesn’t support it. > This commit adds a workaround to this and implements the callback by taking a snapshot of the stats (SNAPSHOT) each time 'stats_reset()' is called. > When getting stats with 'stats_get()', hw stats which always increase reduce SNAPSHOT stats. That's how we get the "real" stats since the last 'stats_reset()'. > > Signed-off-by: yogev ch Acked-by: Yong Wang Applied to dpdk-next-net/master, thanks.