From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A6897A0C4E;
	Wed,  7 Jul 2021 15:48:37 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 7DD78413B6;
	Wed,  7 Jul 2021 15:48:37 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id A4531413A8
 for <dev@dpdk.org>; Wed,  7 Jul 2021 15:48:36 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 396707F553;
 Wed,  7 Jul 2021 16:48:36 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 396707F553
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1625665716;
 bh=LY8sVki7OukrGJP+c22VAmKVVjyLKnypQEn+lYV/UOI=;
 h=Subject:To:References:From:Date:In-Reply-To;
 b=Vu/OTLa13vqIFQKUqDViE7X/CPnx40raaHzrer/3oSiZjgnsTjQO97H9Z2rdCNKZR
 XQMfXCpr1R4kzre+b+q58oZAiEJLJZXubGHgRcebPWTNAMSOZR2iAvwWif9sFozhbZ
 ZR9IIlRecxy7pdxHlR6pQMfQw9r5m/DRg+A9BXO8=
To: Jiawen Wu <jiawenwu@trustnetic.com>, dev@dpdk.org
References: <20210706095545.10776-1-jiawenwu@trustnetic.com>
 <20210706095545.10776-3-jiawenwu@trustnetic.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <a4ce81b6-7a6a-5ade-ea55-cff6428dfc68@oktetlabs.ru>
Date: Wed, 7 Jul 2021 16:48:35 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210706095545.10776-3-jiawenwu@trustnetic.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v7 02/19] net/ngbe: support probe and remove
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 7/6/21 12:55 PM, Jiawen Wu wrote:
> Add device IDs for Wangxun 1Gb NICs, map device IDs to register ngbe
> PMD. Add basic PCIe ethdev probe and remove.
> 
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>

[snip]

>  
>  RTE_PMD_REGISTER_PCI(net_ngbe, rte_ngbe_pmd);
> +RTE_PMD_REGISTER_PCI_TABLE(net_ngbe, pci_id_ngbe_map);
> +RTE_PMD_REGISTER_KMOD_DEP(net_ngbe, "* igb_uio | uio_pci_generic | vfio-pci");
> +
> 

Please, remove trailing empty line.