From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Shah, Rahul R" <rahul.r.shah@intel.com>,
"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] port: Eventdev port support added in the rte_port library
Date: Tue, 5 Nov 2019 15:59:17 +0000 [thread overview]
Message-ID: <a4e11e60-e9d2-3677-591a-e9c0925e3afd@intel.com> (raw)
In-Reply-To: <4DAF8D815EA7614683D9B9071A032C699742B2F4@fmsmsx122.amr.corp.intel.com>
On 11/4/2019 11:24 AM, Shah, Rahul R wrote:
> Hi Ferruh,
>
> I was checking the lib/Makefile for cryptodev example which is similar to eventdev patch I have added (i.e. there is a dependency on librte_cryptodev library)
>
> DIRS-$(CONFIG_RTE_LIBRTE_PORT) += librte_port
> DEPDIRS-librte_port := librte_eal librte_mempool librte_mbuf librte_ethdev
> DEPDIRS-librte_port += librte_ip_frag librte_sched
> ifeq ($(CONFIG_RTE_LIBRTE_KNI),y)
> DEPDIRS-librte_port += librte_kni
> Endif
>
> This is how it is added in lib/Makefile. I don’t see cryptodev added here.
Hi Rahul,
I didn't get your point, is cryptodev dependency also missing?
If so can you please fix that too?
>
>
> Thanks,
> Rahul
>
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Thursday, October 31, 2019 10:33 PM
> To: Shah, Rahul R <rahul.r.shah@intel.com>; Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com>; Thomas Monjalon <thomas@monjalon.net>; Richardson, Bruce <bruce.richardson@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v3] port: Eventdev port support added in the rte_port library
>
> On 10/1/2019 7:05 PM, Rahul Shah wrote:
>> Adding a new port type called eventdev to the rte_port library.
>>
>> Signed-off-by: Rahul Shah <rahul.r.shah@intel.com>
>> ---
>> lib/librte_port/Makefile | 4 +-
>> lib/librte_port/meson.build | 8 +-
>> lib/librte_port/rte_port_eventdev.c | 585
>> +++++++++++++++++++++++++++ lib/librte_port/rte_port_eventdev.h | 100 +++++
>> lib/librte_port/rte_port_version.map | 9 +
>> 5 files changed, 702 insertions(+), 4 deletions(-) create mode
>> 100644 lib/librte_port/rte_port_eventdev.c
>> create mode 100644 lib/librte_port/rte_port_eventdev.h
>>
>> diff --git a/lib/librte_port/Makefile b/lib/librte_port/Makefile index
>> 1b83f6f2b..de6f0428a 100644
>> --- a/lib/librte_port/Makefile
>> +++ b/lib/librte_port/Makefile
>> @@ -11,7 +11,7 @@ ifeq ($(CONFIG_RTE_PORT_PCAP),y) LDLIBS += -lpcap
>> endif LDLIBS += -lrte_eal -lrte_mempool -lrte_mbuf -lrte_ethdev
>> -LDLIBS += -lrte_ip_frag -lrte_sched -lrte_cryptodev
>> +LDLIBS += -lrte_ip_frag -lrte_sched -lrte_cryptodev -lrte_eventdev
>
> This creates a dependency form 'librte_port' to 'librte_eventdev', this dependency should be reflected to the build system, so that 'librte_eventdev'
> have built before 'librte_port'
> This is done via 'lib/Makefile' in make build but not sure how to do in meson.
>
> Can you please send a fix for this?
>
next prev parent reply other threads:[~2019-11-05 16:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 18:05 Rahul Shah
2019-10-25 15:35 ` Thomas Monjalon
2019-10-25 15:40 ` Dumitrescu, Cristian
2019-10-25 15:39 ` Dumitrescu, Cristian
2019-10-25 16:29 ` Thomas Monjalon
2019-10-31 17:03 ` Ferruh Yigit
2019-11-04 11:24 ` Bruce Richardson
2019-11-04 12:03 ` Shah, Rahul R
2019-11-04 11:24 ` Shah, Rahul R
2019-11-05 15:59 ` Ferruh Yigit [this message]
2019-11-05 16:13 ` Shah, Rahul R
2019-11-05 16:22 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4e11e60-e9d2-3677-591a-e9c0925e3afd@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bruce.richardson@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=rahul.r.shah@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).