From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kevin.laatz@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id A58D64D3A
 for <dev@dpdk.org>; Wed, 24 Oct 2018 17:05:58 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 24 Oct 2018 08:05:49 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.54,420,1534834800"; d="scan'208";a="98200450"
Received: from klaatz-mobl.ger.corp.intel.com (HELO [10.237.220.107])
 ([10.237.220.107])
 by fmsmga002.fm.intel.com with ESMTP; 24 Oct 2018 08:05:47 -0700
From: "Laatz, Kevin" <kevin.laatz@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: =?UTF-8?Q?Ga=c3=abtan_Rivet?= <gaetan.rivet@6wind.com>, dev@dpdk.org,
 harry.van.haaren@intel.com, stephen@networkplumber.org,
 shreyansh.jain@nxp.com, mattias.ronnblom@ericsson.com,
 bruce.richardson@intel.com
References: <20181022110014.82153-1-kevin.laatz@intel.com>
 <20181024132725.5142-2-kevin.laatz@intel.com>
 <20181024140156.x4vyur6zxtbrrtny@bidouze.vm.6wind.com>
 <29630789.dO8WeQshWb@xps> <217b61fe-e0bd-3acf-8306-2537c7d2f1c9@intel.com>
Message-ID: <a4f20c1c-d0a0-10fd-2da4-9c465ce77c2e@intel.com>
Date: Wed, 24 Oct 2018 16:05:47 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <217b61fe-e0bd-3acf-8306-2537c7d2f1c9@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH v7 01/13] eal: add option register
	infrastructure
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Oct 2018 15:05:59 -0000

On 24/10/2018 15:52, Laatz, Kevin wrote:
> On 24/10/2018 15:33, Thomas Monjalon wrote:
>> 24/10/2018 16:01, Gaëtan Rivet:
>>> Hi Kevin,
>>>
>>> On Wed, Oct 24, 2018 at 02:27:13PM +0100, Kevin Laatz wrote:
>>>> This commit adds infrastructure to EAL that allows an application to
>>>> register it's init function with EAL. This allows libraries to be
>>>> initialized at the end of EAL init.
>>>>
>>>> This infrastructure allows libraries that depend on EAL to be 
>>>> initialized
>>>> as part of EAL init, removing circular dependency issues.
>>>>
>>>> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
>>>> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
>>> I think this is good enough,
>>>
>>> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
>> Yes it looks good enough.
>> And it compiles fine in my test.
>>
>>> The only remaining issue is rte_option_init().
>>> Sorry I missed your previous message and did not respond in time, I
>>> would have opted for leaving a return value to at least be able to stop
>>> the init on error. It is possible to force the callback type to return
>>> an error value along with a string / hint describing the error. It
>>> should not be hard to add it later, so not blocking IMO.
> Agree this can be added in the future.
>> I think you need to set this API as experimental.
> Will do, thanks.
Correction: This is an internal function (eal_private.h), so no need to 
mark as experimental. rte_option_register() is marked as experimental.