From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <gaetan.rivet@6wind.com>
Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com
[209.85.128.195]) by dpdk.org (Postfix) with ESMTP id 4D7F01BA6D
for <dev@dpdk.org>; Thu, 26 Oct 2017 00:39:38 +0200 (CEST)
Received: by mail-wr0-f195.google.com with SMTP id z55so1455332wrz.1
for <dev@dpdk.org>; Wed, 25 Oct 2017 15:39:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=from:to:cc:subject:date:message-id:in-reply-to:references
:in-reply-to:references;
bh=fjgwDdGUM6+Bj/+zcOjyfvyFglx59Df3fuiEnsOY7mE=;
b=pladIE/fgengVb8XvlVPGxpsnQKnVQJ3/lT8OLhHxN8BOL0FC+nmc98s/BOff5zJfR
KjPqDVljech8YO0+BBHeQo/CiQSxC2JMedm/zPBnKYPbg3LvEROsoaJSe5sAkkqTXAsB
q0ofpi55ZxhuK+7k1ZaoYO43KQT6weJStFKxDBgdXzb2LlEWIL0t8ZfTvsVbCkhso4wZ
XemERy2q0bO7G5nCFMvRzDXQWVCpBIkcmr74zUctBV3v7OXMc1AGct9+kQPjWn0PABbr
43rUZZoavaAVjqP9nmiydGlNcfg35x8yOOxFSIf1RUtHSNzDBxYOuwxcerI1590Mu4GR
0Zag==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references:in-reply-to:references;
bh=fjgwDdGUM6+Bj/+zcOjyfvyFglx59Df3fuiEnsOY7mE=;
b=QQRL2rIXBMHUQpvp3+YPLMhlncaKxLLgFDlMQVXlFmt1Cw8dVgNdrPennq1wEAP8eu
L3ikZg+0CbBzM8G9/KalFwT/I06WR7vxTwQbqE6ghFbrbxUzOwDfT+upZXzvHfLGhMHI
JTPRVsb8cOyOaKRFY+Fp2fO/MrrTWtaSUYdVci7Ciq/MDLJcGRG1UnUk3NRVr7S0vxrt
GP8AiqsPaT2Gz1C3Wsf9b5/DYTdjwr51mUxQlsu6GecNPIWkSu6ZMPSuKQCkw9Ktg7Tt
30EF+T5W1W4TG635tMw/le3ZPez4IwLLd3inqWWYu3gLYJIQ2S2LCYU0Q6dXofVzRGRp
eT3Q==
X-Gm-Message-State: AMCzsaVeIOhEXUZFmmHzOsZ3xVpeAGKZalhv2XCKhq0p31SQzhw3YgWx
KtMxTbBnZNLRtMUo6bRqb6bLceKs
X-Google-Smtp-Source: ABhQp+R4p1G3uCfPAAE5BLKivk/LeFZ0E3Qdc4/5DbjRO+TE0T1N6opkjG3ZtcHkzIWrtDoj1iBQmg==
X-Received: by 10.223.148.38 with SMTP id 35mr3784584wrq.49.1508971176656;
Wed, 25 Oct 2017 15:39:36 -0700 (PDT)
Received: from bidouze.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com.
[62.23.145.78])
by smtp.gmail.com with ESMTPSA id r63sm4466124wmg.13.2017.10.25.15.39.35
(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
Wed, 25 Oct 2017 15:39:35 -0700 (PDT)
From: Gaetan Rivet <gaetan.rivet@6wind.com>
To: dev@dpdk.org
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>
Date: Thu, 26 Oct 2017 00:38:44 +0200
Message-Id: <a506a79aa1d819f1f3ee5160991aab60354d603c.1508970254.git.gaetan.rivet@6wind.com>
X-Mailer: git-send-email 2.1.4
In-Reply-To: <cover.1508970254.git.gaetan.rivet@6wind.com>
References: <cover.1507804944.git.gaetan.rivet@6wind.com>
<cover.1508970254.git.gaetan.rivet@6wind.com>
In-Reply-To: <cover.1508970254.git.gaetan.rivet@6wind.com>
References: <cover.1508970254.git.gaetan.rivet@6wind.com>
Subject: [dpdk-dev] [PATCH v7 22/25] net/bonding: use local prefix for local
function
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Oct 2017 22:39:38 -0000
The current name conflicts with the librte_pci naming convention.
Additionally, it is easier to use gdb when having prefixed even private
functions.
Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
---
drivers/net/bonding/rte_eth_bond_args.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bonding/rte_eth_bond_args.c b/drivers/net/bonding/rte_eth_bond_args.c
index c4dcefa..ebbcc5b 100644
--- a/drivers/net/bonding/rte_eth_bond_args.c
+++ b/drivers/net/bonding/rte_eth_bond_args.c
@@ -89,7 +89,7 @@ find_port_id_by_dev_name(const char *name)
}
static inline int
-pci_addr_cmp(const struct rte_device *dev, const void *_pci_addr)
+bond_pci_addr_cmp(const struct rte_device *dev, const void *_pci_addr)
{
struct rte_pci_device *pdev;
const struct rte_pci_addr *paddr = _pci_addr;
@@ -118,7 +118,7 @@ parse_port_id(const char *port_str)
/* try parsing as pci address, physical devices */
if (pci_bus->parse(port_str, &dev_addr) == 0) {
- dev = pci_bus->find_device(NULL, pci_addr_cmp, &dev_addr);
+ dev = pci_bus->find_device(NULL, bond_pci_addr_cmp, &dev_addr);
if (dev == NULL) {
RTE_LOG(ERR, PMD, "unable to find PCI device\n");
return -1;
--
2.1.4