From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60513428E5; Fri, 7 Apr 2023 11:26:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE4B240E03; Fri, 7 Apr 2023 11:26:24 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2059.outbound.protection.outlook.com [40.107.237.59]) by mails.dpdk.org (Postfix) with ESMTP id 0FFE340150 for ; Fri, 7 Apr 2023 11:26:23 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NzD7x/+uIIQDgkfzrU8t/QQPUJfsakT8+9GN1qCvWJG5QELSrxQg+YkrInwHe6x37DB3PUUgR/Sks0UoLF0TmzCD5GDfxsQqoHnaV3xs2ZKQM5Tc368Y4r11NCR0F42cMnfFEicpYDDdJUAuEvb4ono9pNO27G62MqONiCeJlz06HQZlWXQv8LXsVZ7oh+uTFeub4kMcwZY9JpUT2mwqsqN530KeIEgjmeAWvSemCc+Kcoe9FVbmNblBCbmqeNmB6P/gbjI0fvEj1r75taq1Hhevd3a69MwUK5/E8Esln+N0g5uEGfhV15uvEqlVAhx0pgmnGlPBxdVx4RfjL9U2gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ODa4kSFHvaumDPzZE3X8SGVptswxbkWSj0XqVWpvr1c=; b=AGbklO6ujISX9px4R1ZLXV7gXrQudpVu7oNjccKAJllGzX4KnnwIafrUuS6/IFPVLMZ7KbUD83LNrLjQkY8Ypyw8uRXJ3IKjBOkUq5xunDtzrqPJoqSSXIIKRRa3Pf7q9514lSOrVnoEG5QHudmvGIcXfC4hkfIIxdSXuShoZIwZFIiy5K/sFhXO+izh84LkJlEiMATsyPjP6t0ZgBYXXNfTmH8zEY351sBp8Lu6bR401xvpttWNwzLuXzMdkdK+LTF05D0xmwpJWycQRQnSNiN9V6NpHEyfLgXJmS5VcybGXNDHEoyzrjSE3fdRDTeI1cwzudtilk90P1jSVz3wFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ODa4kSFHvaumDPzZE3X8SGVptswxbkWSj0XqVWpvr1c=; b=nNu5Sz/opteE+ebf45hK551PzXCLqbs/yozvWDyDa3rBLigZhiHsalUKL6jT6YknYxoCn68SUExzEGsGudPMoWVr8V02ZEj+Rqv5Qrp+H+sXKOqHRe5We4BiO7vjphzmdNjOSg1qWB6sP/cuzqQ4Hi/5045Y/ZPoe9/b+vElH04= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CY8PR12MB7610.namprd12.prod.outlook.com (2603:10b6:930:9a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.34; Fri, 7 Apr 2023 09:26:20 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::5e2c:c0ed:88a6:a4c7]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::5e2c:c0ed:88a6:a4c7%6]) with mapi id 15.20.6277.034; Fri, 7 Apr 2023 09:26:19 +0000 Message-ID: Date: Fri, 7 Apr 2023 10:24:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] common/sfc_efx/base: support link status change v2 events To: Andrew Rybchenko , Ivan Malov , dev@dpdk.org Cc: Andy Moreton References: <20230328165112.6535-1-ivan.malov@arknetworks.am> <89267f8e-67fd-2858-44f3-d330933b7350@oktetlabs.ru> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <89267f8e-67fd-2858-44f3-d330933b7350@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO3P123CA0030.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:388::13) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CY8PR12MB7610:EE_ X-MS-Office365-Filtering-Correlation-Id: 2d6cd25c-7186-46dc-0fd6-08db374a252a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /nFk8tGpw4DWrHREFOfoKjwBu6kkfmjrYCLkUXsfAvawcBYQuCjKmw+7NwtSrnLHdA1g93tMEsPaDrc3Jh9PVvEiY1yC1FUYYGgwQhziL+h95K0L/+a7BGGYayJvpEI6cjHgIJpLbJhDWnR12x7LEfc2WgqJz30MLTmhQHRInxblLqjItgHq3ALfV/snv7TCBSSk6CeorEjE/nCrnEOMQrZQ57TLSHc6P5op6/YPhYg+vSJdljyICyFUNBHrIIUILl8WzN6z9+MUvitPkqZJA3Ax3SCI0nBQAm3xcCWBMxtWF4XVKSjnscrQggiSRJ9MWvkNLldCTyN2pjeeGUQ8L2d+qfk4ioWPh4uHL1KgraNhAvOJaAcEgh3/wLn68AHdbUy2LLtAJqZ4GtMdC5SOxwEiY9Wyznkl1lm+7ZkkLTgezi4skIgSBSQujejx4eRZa06Dp+MNyOQ9un4TnuJhq8zd4QmInoOZF2259keDrw9wvDwjThVDdWKqx/wBm+o5NsCb0MxZrB24mqLEtl9OrjsYgHi+NG+JGm4xieEmdXLcjKcE7nTpM+WcFbUwEtUv7fL3uq93wPs4PESdX4UOO4W6my3KNbDEeQphqPtPBEccywP42jG9duLjB9K1ZPHxQoX4AsHyQDVKoOPx0ZaQ6w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(366004)(136003)(376002)(39860400002)(346002)(451199021)(83380400001)(5660300002)(44832011)(4744005)(86362001)(31696002)(2906002)(38100700002)(36756003)(110136005)(316002)(478600001)(8936002)(66556008)(6506007)(66476007)(8676002)(26005)(6512007)(53546011)(66946007)(186003)(6666004)(4326008)(31686004)(2616005)(41300700001)(6486002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SEdpeGE2UWxaSWJGc3hTdk1Ob3NNZTltQUVmLzdsV0ExRUZFZWZWRlFLZHBp?= =?utf-8?B?Z09vK1A5MU5SUTZBSlpnV3d4dnZ4ZmV2dUNaek45K3lodGlkYnNxNFFMbTZ1?= =?utf-8?B?dFNSR0ErUE9sYW9jZ1VRQmJvcVJvSHlXc3lxZWFWVWZaTjNleGljUXVxTDBF?= =?utf-8?B?SXVTa2hhVm1naHAwUWtCNjYyWWhVRkIrSmtYajdKVTRqa2gwWXZ1cFI5bnBP?= =?utf-8?B?TlB1TjdkZFk0VndCK2JzTmtyZGxkUlZXZ1lCejl2NndhZjAvbTJXWjF2TmdZ?= =?utf-8?B?Wmd4SG1qUVA1UW9ZWE9uSk9rMVpLNmt5dVo3bENaRFFRVWozMEJWWm9SSVh4?= =?utf-8?B?alp4K3FzSHlxRDgxQTZWcy9kVXZuRUdVU1ZZdGtwNTJPRXlkME1nQURieXFO?= =?utf-8?B?OGFMTmNJbHhFKzJnN3lLSTc3YnBtQjlKUVd4aUtlSDNmTnhqVDZMVjhDaDcx?= =?utf-8?B?YkVHYTZFN3ZRMktXRUVVQkQybTMvV0ZsdXcwd3Y4cGxHY1NBM1hURnN4Sy80?= =?utf-8?B?WE9mWllzU1FXZG5ORG1Saml3dXJ2YWZKc1pFdDQvY0RDT1Z2d2tVOGtyc3VX?= =?utf-8?B?OU01dkdiZm9lQlhxZXJIVjJJVmd4bG5iL3JHc1BSbTBxTjJnbWIrRHFqWDVM?= =?utf-8?B?Skx4R3hOTGM0c0liWWhpcnZEUUdMNHJNR3ROU01hSnZxcHkvcHBaTEhGaWor?= =?utf-8?B?a3pjRHI3dDl1eHRtUEtrWUJqVWRnQVFiZW5USGJPczhIM0M0SHV4SFhBTk5H?= =?utf-8?B?S2s2OUxDbU1nYzBRVGJaeU5OQlJnb0lzUzNZUnJXTkRZaDY2OS9ZSzdmZ0Vp?= =?utf-8?B?RDVXMlNjR3F1N09USlJRa3M2SXVocWtNZTZVSTBqT3k2c3NZcUxDTXkxMTZL?= =?utf-8?B?VWhBa3M4SWg1bSsva1I1VkF4TDNUWGo2bUU1S3BoaHNsYXF3YXRIYTJpV1Zp?= =?utf-8?B?QU5HdEFJZG9EVWJLd29TR1VNVGNBWmtVNlJHYjVqWEprMHNrZnR3TVFnS01l?= =?utf-8?B?aGtRb3pHbHpuTDA0dG1RUnVKdWxiV2dOOWtTWVZGZVduV2lDTytWbTF4OTRo?= =?utf-8?B?bGxjZ2wxSUY1cHF4TEhad25KcjIrblh6V1hxR3A2cnp2S1JoeXBwbWlWeDVB?= =?utf-8?B?eEhxbnFQYTAzcENPT1ppbnZsOUdqekhPZThWM2RBYkFiYldkaXFRandYWlo5?= =?utf-8?B?cm14WFNGN2cxWmsrUFpnVzhVeElSQnJYTjJHRGt1Mk4yYlZacWNRa2VsUFBG?= =?utf-8?B?UWJQQU5CN1I5QTNOZnQvN0tBNkhmSkE4MjAxWXZtTVRhRm5SbUFKeG5JVktR?= =?utf-8?B?Zm92Ump5bVdNZm1CWW1JcUo4bXhXUXJ0K2xyWklkdWViaFBDL3FkeEtCZ2Q1?= =?utf-8?B?cEEwQzJaOGZtUW5GWXBuc1BJdSsvczcwUDNwdWU0OExjbmdaSmRNSmJSUFkv?= =?utf-8?B?Q1NudytrNlhYazE1ME13ejd1amova1JORnlkOGFzOEhTNnVBZFdXa01JUStn?= =?utf-8?B?VDdRa0lxNHFvVTlWdjdoRDhVazgveDdSNytSbGRoaGh1alQ2Ny82YXpIemVU?= =?utf-8?B?TnY5dFoxQXRQVUVidTcxQUJqL0NMV1JFL3FJWG9ZdnBQejEyZFcvcWxlcDhy?= =?utf-8?B?OWsza0VNc0VEU1VvT0pUY0xPUk5xY3NFWW1EZytBSlY5R1NHRHVWdVZuTE9v?= =?utf-8?B?Y3YxbnVyZFV3WWZ5RWkyOE1YVVFWSXU2Tm5DWk45N293TTlEVUVmekwzYUJx?= =?utf-8?B?ekdKT003QkE2RzdxeXZHY0JhMTBKNHNhVWVjL3JIZy85a2FmdE0vVDlJSHlO?= =?utf-8?B?bWFhbXVNd0YzMG1KY0tDeTlWTkFTYjFheUZOMnJoUFh2V2VyWU5EeUtiZ3JT?= =?utf-8?B?dU80cXVlbkI4QTltelZIOCtibm1pMGZsZytUTzlXc0NvUUUwN3A1RmpLVk1u?= =?utf-8?B?cVFxdncrZlM3c0NRNk81SXBSY3dkYmFRcERuTTMzaFJnSVh5ZmQ5Z2pYQzFk?= =?utf-8?B?RTBmajNSVHhYcmFsZHJVQUtLeHJSWWRUT2xEWjZvQzJGWjJvZE9lVG4wOUps?= =?utf-8?B?emtJRzNEd1BtK0hMRXozeUFibEFCdWhVaFlMU2c5YitrTmJaTEc4VFdkeCtJ?= =?utf-8?Q?fSSpPXyVrFzrKjOu8n6HK/rVs?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2d6cd25c-7186-46dc-0fd6-08db374a252a X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2023 09:26:19.6289 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Kfwz9zTRzgh5hnKTZd0Km5ocrf+ABbP74zsDmL1P/fSxJttkKhpoG8wsoHITMF6V X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7610 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/30/2023 8:16 AM, Andrew Rybchenko wrote: > On 3/28/23 19:51, Ivan Malov wrote: >> FW should send link status change events in either v1 or >> v2 format depending on the preference which the driver >> can express during CMD_DRV_ATTACH stage. At the moment, >> libefx does not request v2, so v1 events must arrive. >> However, FW does not honour this choice and always >> sends v2 events. So teach libefx to parse such and >> add v2 request to CMD_DRV_ATTACH, correspondingly. >> >> Signed-off-by: Ivan Malov >> Reviewed-by: Andy Moreton > > Acked-by: Andrew Rybchenko > > Applied to dpdk-next-net/main, thanks.