From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF433A04B7; Sun, 20 Sep 2020 10:47:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DE1061D9AA; Sun, 20 Sep 2020 10:47:33 +0200 (CEST) Received: from huawei.com (szxga06-in.huawei.com [45.249.212.32]) by dpdk.org (Postfix) with ESMTP id 8B6B31C1A2 for ; Sun, 20 Sep 2020 10:47:31 +0200 (CEST) Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 8C6CFBA7BA9082D2FFF8; Sun, 20 Sep 2020 16:47:29 +0800 (CST) Received: from [127.0.0.1] (10.65.81.238) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.487.0; Sun, 20 Sep 2020 16:47:22 +0800 To: Ferruh Yigit , References: <1592483709-7076-1-git-send-email-tangchengchang@huawei.com> <1599296854-56620-1-git-send-email-tangchengchang@huawei.com> <1599296854-56620-3-git-send-email-tangchengchang@huawei.com> <54de0895-da1a-79d5-2962-c4fab3972ac7@intel.com> CC: , , , , From: Chengchang Tang Message-ID: Date: Sun, 20 Sep 2020 16:47:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <54de0895-da1a-79d5-2962-c4fab3972ac7@intel.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.65.81.238] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v4 2/5] app/testpmd: add Rx buffer size display in queue info query X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2020/9/18 16:54, Ferruh Yigit wrote: > On 9/5/2020 10:07 AM, Chengchang Tang wrote: >> Add Rx buffer size to queue info querry cmd so that the user can get the >> buffer length used by HW queue for receiving packets. >> >> Signed-off-by: Chengchang Tang >> Reviewed-by: Wei Hu (Xavier) >> --- >> app/test-pmd/config.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c >> index 30bee33..b432ac6 100644 >> --- a/app/test-pmd/config.c >> +++ b/app/test-pmd/config.c >> @@ -452,6 +452,7 @@ rx_queue_infos_display(portid_t port_id, uint16_t queue_id) >> (qinfo.conf.rx_deferred_start != 0) ? "on" : "off"); >> printf("\nRX scattered packets: %s", >> (qinfo.scattered_rx != 0) ? "on" : "off"); >> + printf("\nRX buffer size: %hu", qinfo.rx_buf_size); > > Since this field is optional for PMD to fill, it may be confusing to display buffer size as "0". > What do you think print this value when "qinfo.rx_buf_size != 0"? Agree, it will be modified in the next version. > > . >