From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 365CEA0C46; Mon, 27 Sep 2021 17:26:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EABA0410DA; Mon, 27 Sep 2021 17:26:07 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 4408340E3C for ; Mon, 27 Sep 2021 17:26:06 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10120"; a="310047549" X-IronPort-AV: E=Sophos;i="5.85,326,1624345200"; d="scan'208";a="310047549" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2021 08:26:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,326,1624345200"; d="scan'208";a="561252985" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga002.fm.intel.com with ESMTP; 27 Sep 2021 08:26:00 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 27 Sep 2021 08:26:00 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 27 Sep 2021 08:26:00 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 27 Sep 2021 08:25:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nYM0BpjkoJwdnrX2ZYbT1RcmcOGwg5p6F1tbuXVSnMJpOttYQ7xAxLco3ogKOZzMM5jfcLnw+ofS0zwPrSJujSLTvJpcy8YLXY3fT0pvaA0LXINsflfqCN4sG6eZmXINbsq8kb1m8N5h9OU1LQJPy5BXBRpDP8ezcpEoUNNeskzPgVJuqz1QhHGBR4sM1Zym9QglCPMHILNS4ls/0+TEujCJ4LqllVcf85/Yt4O4wfId9qTrfoiGqUr3wKW0ljKZGWQsPNv74opqFZYV6bZoZmL3EQ1uhNiVo2yi+afneGTXMie3Nzi6CiQGAks6tW1frWK+LyO4HkHk5HQfI4b7Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=esCPE/Ze0gt/G97nvsLTeAqZyX+HmSuiGx05fAF20E8=; b=nUzw7I0+DzOsMZW8FxE/uV10niz2b8yTCabuEjmZkh+nBji5/CNB2leVRGcKPQlps6tcE5kF7GMdMAjpYo2siCML8BJh/mz10u/0GJMi5VqNyaWuP/hpwOsxoskvcjRXVzEvCTsL5UQu5NnoCY7W6c8Tlq0BhhSII2xP4VRROfbyOrCFqFYAQV97xIgEBP1GBrR8DNNykgUW1kKdAWLurlfbHCiMLywUl/QWjh3gPOwdQBdZn9UvSrchAXYYrqrvrNOreJhyCXAM2YvjsQ9JAHAntt6sXEx5MiQMAOwfJ5WrDewje1TxamrRIXzDrLuukYXO2ZgeyZ3SE2Qa/qFChQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=esCPE/Ze0gt/G97nvsLTeAqZyX+HmSuiGx05fAF20E8=; b=YEoMc/d05hFeCQZIe1U5yiCt1c6S4tD+M4DwcsZ1dE7KbutdJO0peXHXYNEJeQFszyIvN/5JfGTQpTgjjKLjsVfbJLI7A39c40qI80k2tXD9u3nBa+r32DRv14/5rJfl2dChsInynWbFvjTHi7xTO49LEXvQacSURTpiBvDKWqU= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5095.namprd11.prod.outlook.com (2603:10b6:510:3b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15; Mon, 27 Sep 2021 15:25:58 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4544.021; Mon, 27 Sep 2021 15:25:58 +0000 To: "Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)" , Junxiao Shi CC: "dev@dpdk.org" References: <973f32e49849ad68@cs.arizona.edu> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Mon, 27 Sep 2021 16:25:53 +0100 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB9PR01CA0003.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::8) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB9PR01CA0003.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.17 via Frontend Transport; Mon, 27 Sep 2021 15:25:57 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2b97ab85-66db-40f8-4779-08d981cb1b22 X-MS-TrafficTypeDiagnostic: PH0PR11MB5095: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2150; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5GQrCg/x8v4HblSftFF6vd/baztrfh76QuqAIh6fRzfhtCKL5RGomljZ2H+hB+bXNKchBLM623y4Usra4MPvuBsg4/yTq7mGpsB1gxCKbj9EabVsB50CWLV2AYltSKllaOfEZjBVWRJfdG+KJZSVAqhDAiHmzk2ekc1vDwniIalgxMGMGdejok++v4q+CQdbNhs89qJPAfSoGo2zXpow41gE0KTXVtQXB9wUA1I9xT85pkCxfUN1qNNw5EyLpsKQng8O6772UMYX3W+xkWaE4LSjCDKXJdELyWU3jMfR4WKygMRN8uzwa54q83z/BvIQcuu9HYu4EVTJF4CGoBCYkxl1RkYBeDrFANfiCSsoA4KyV0jkMk3SEMZPmYmQTOkiJfIYJiHFo2f8EMVfUWjp4l5nqulMj4kex4xpjiU7Wx8aNtgOR6D43axTS0qKEodDU7HnDmuVu6FlVcoLIwqj7kJ/y2ZBadDxAoowXCQiq4lxlitEyTz6H4G4bPytiDwaJCk9aIDc3RnWU5n4NAQ/YJNH/3SZtL8ho64O13H8nY9qwLqyye9DgSYxi5YULdk5cuxsl2UUN3bR59PZJ47DV5Q/seasxdZ6gR2mQnVMjs1ZP/sKFZamhfTk5jNA8ZQPHGtCNV9BHQW06OkQsGZq9A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6666004)(2906002)(66946007)(8936002)(31686004)(38100700002)(110136005)(5660300002)(83380400001)(53546011)(6486002)(508600001)(16576012)(956004)(26005)(36756003)(44832011)(186003)(66556008)(66476007)(316002)(8676002)(31696002)(86362001)(2616005)(4326008); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGZQaXJmVW9zdzBwcHhKSjU4Z1NiaGtBRldpNHAyWmQzTCtzMUdzWkI0a3gz?= =?utf-8?B?eWdObjhJRlhmVDJzWUZNY0VaYnpkUUhMdDRFRTA3Vk1rWm5acVdCaDJzQlBy?= =?utf-8?B?bkZCYzN4dnJja0tnaXhuM2c0UTlGY1dGalo0cUF1Qm9PcE5jL2JsNnFuZlpR?= =?utf-8?B?VjIrcGFac1MyY21DQzlVdG9OY0pXemZZY0gzTXhESmx4cE9sRmpsSVpNb2pi?= =?utf-8?B?N1pOL2wxbWV2YW1FSmEyMVhaemIzdytydGlkc250bThaaDF0c3Iva3lyQ1VE?= =?utf-8?B?RHlzUzdYcXBCUEZPNTdIelA0a2hLN2Z6Ni9vRnFhWmZ1ek5JUXFNWDdhcUhU?= =?utf-8?B?UUJxOGMvYTVObzRBMDU3YmdMQ0dsNElJVExCU3JIN3crdGdpUDVmMjd1Tlg0?= =?utf-8?B?UGlYR3BpaUM3NDVOYk1ZbWpRdXlFSDVsclR5SlZkR05mcGRkancwbFZBdEVI?= =?utf-8?B?eGpYZlpPT2dPYXNrZVA5TWZMQTNSclZOSzd5dVNEckR3THRHV2wrMVM5ZXRZ?= =?utf-8?B?KzNwSGJQc3oyWk9sM1R2Z0w1aElhMzNVVktsWDdsVVZ1cG5sazJzSWxHMGxt?= =?utf-8?B?UEt5aHNYMmxrWVhvNzRPZmdnVHhhNXF3SlFBTHVLeitKTXdYZ28xaFlzQXlY?= =?utf-8?B?c1NyNlRBb0dOS0p1TmhOS2gvL2FkQ0RURklOVVIxVkJmSkx0ZTFPM3VYL1dI?= =?utf-8?B?N3Nuc3J2Z3R1SFFJbkJYak1xS3FBdXNZcFZNbFI0MjJTUHYvSURuaUNzR01J?= =?utf-8?B?QWoxTVFJOFJZZTQzZVJ0ZENkbkJYNUUrVFFZMVNHUmlVVnNzS3hsNGRFbFBS?= =?utf-8?B?eVA4YXZ5UEw4QkRJbFh3MDNPN0FuSmREMWNlSWwxeFdJSzE1S0ozMlpNQmdh?= =?utf-8?B?UnhUTXJGM3h1bFNWaUJlRnRJRTV1NFN0S1ZhRVJ3QllLOWNkdkNsT1FvcEk4?= =?utf-8?B?aUNtQnlmQUx3TFVpZ0h4QjgvQTRicjR0a0c3STV3enpJNzJpeEhsV0UvWEhT?= =?utf-8?B?RDBoaVBZZ2pyWUVIenk4Y1FHQ1I5eUxiOEFPWGV6S2lydWJBcXZIeEJ3SUVk?= =?utf-8?B?VkU1V1orZUYvMEIyeUlXd0hkZ3hUN0xSZStyWnB2QWtJUkNrMUUwT0h6V3ZJ?= =?utf-8?B?WGtSYXVFZG1Dc29sVjQrOTFEb1p2SisvVWdOQXQxZ2dScHd0YUR5dlMxTWRH?= =?utf-8?B?TjVlR1FSSkFkZVJjR205VXd3M1hmemlRT3d5dHpWaHNHbXYyczM0UnZMTmla?= =?utf-8?B?b05XNGQ4QklhWUVVUTJhdTlZNmtvbjBmY1F1eXpHVUh0YVR0K2JsNnk0WURO?= =?utf-8?B?S0lXM25oNjlNNVgvWWdLOE9uNGhHZ1ZWQ0plekkzdXJCM0lsbEh0RzhzeUE4?= =?utf-8?B?aHRpdkFxV0RNTDFOWGJrOW9qUFJYeUJlOWpPM0Q0TFdjbGF1eE4xbWZESHBF?= =?utf-8?B?Z0hQNnlGM3JYaCtzeDBBaXZoUkZKZXMxZ0FFQ1E4QzRJWm5scldnWGRNOUhx?= =?utf-8?B?dXVxaFlzUEVvYWlqdDliTHF4NGpwME1YR1VVVVE5MDltd0wwRkdxanFZc09F?= =?utf-8?B?RWFTWXRUbFFKOHNubU1CeXRKSzEwZEk3cGxHRWx2L0xZY3h4VEpWRmtlbHZT?= =?utf-8?B?clI4cEpHSnViVk1LRUZHZGJiL213ZEZoTUxjMU5NL3BtZFQzM2ZLKzBmRzhY?= =?utf-8?B?dGpDbzV1SllIOVhPRnBqcVA0cyszMXZtN25MbWNkREdwcG02Vk0vRk9yYnls?= =?utf-8?Q?T5PEyuEc8IwsRPkHJ6gZcvJUzkHqaIIfu0yvYJH?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2b97ab85-66db-40f8-4779-08d981cb1b22 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 15:25:58.4893 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZiccsDGrN7J6LDDmisYLwmCMunD0+5hRrkbPFGC9Hv1WZ2970hWHtsdm1uKU+2S12h74Nv6J73LKI3pAcxA7XA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5095 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/memif: fix chained mbuf determination X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/22/2021 7:19 AM, Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco) wrote: >>> Previously, TX functions call rte_pktmbuf_is_contiguous to determine >>> whether an mbuf is chained. However, rte_pktmbuf_is_contiguous is >>> designed to work on the first mbuf of a packet only. In case a packet >>> contains three or more segment mbufs in a chain, it may cause >>> truncated packets or rte_mbuf_sanity_check panics. >>> >>> This patch updates TX functions to determine chained mbufs using >>> mbuf_head->nb_segs field, which works in all cases. Moreover, it >>> maintains that the second cacheline is only accessed when chained mbuf >>> is actually present. >>> >>> Signed-off-by: Junxiao Shi > > Looks ok to me. Thanks for the patch! > > Reviewed-by: Jakub Grajciar > Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") Fixes: 43b815d88188 ("net/memif: support zero-copy slave") Cc: stable@dpdk.org Applied to dpdk-next-net/main, thanks.