From: Olivier Matz <olivier.matz@6wind.com>
To: Neil Horman <nhorman@tuxdriver.com>,
"Trahe, Fiona" <fiona.trahe@intel.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
"dev@dpdk.org" <dev@dpdk.org>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-dev] [dpdk-dev, RFC] drivers: advertise kmod dependencies in pmdinfo
Date: Fri, 2 Sep 2016 18:13:03 +0200 [thread overview]
Message-ID: <a51d0d08-0b64-e070-e7fd-308aca25b31d@6wind.com> (raw)
In-Reply-To: <20160902141551.GB980@hmsreliant.think-freely.org>
Hi,
Thank you everyone for all these comments. I'll try to summarize them here:
a- the kmod information should be per-device instead of per-driver
(modalias-like)
b- there is no need to specify kmod dependencies (i.e. "uio_pci_generic"
is enough, not "uio & uio_pci_generic") since it is available via modinfo
c- the syntax with commas and colons is not ideal, we have no better
consensus for now, but maybe "&" and "|" are better.
d- the information provided is not complete:
- some drivers requires module parameters or writing is /sys
- choosing between one kmod or another is a system choice
-> this info could be optional for this reason
e- for usual drivers having a "<generic-uio>" tag instead of a kmod list
may be more simple (I'm not sure of it though)
So we could either:
- drop this RFC, and like today everyone shoule handle the loading of
kmods on its own
- keep the approach of this RFC, enhance it with a- b- c- e-
Examples of string to manage specify the devices wildcards:
/* kmod list for all pci devices */
"pci:v*:d*:sv*:sd*:vfio|uio_pci_generic|igb_uio"
/* if we need device-specific modules: */
"pci:v8086:d1234:sv*:sd*:some_kmod"
"pci:v8086:d4321:sv*:sd*:some_other_kmod"
this is not a perfect solution, but I think it would make the
development of an kmod autoload script easier.
Any other idea?
Thanks,
Olivier
next prev parent reply other threads:[~2016-09-02 16:13 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 13:20 [dpdk-dev] [RFC] " Olivier Matz
2016-08-30 8:40 ` Matej Vido
2016-08-30 8:56 ` Olivier Matz
2016-08-30 13:23 ` [dpdk-dev] [dpdk-dev, RFC] " Neil Horman
2016-08-31 9:21 ` Olivier Matz
2016-08-31 13:27 ` Neil Horman
2016-08-31 13:39 ` Olivier Matz
2016-09-01 12:55 ` Trahe, Fiona
2016-09-01 17:35 ` Neil Horman
2016-09-01 17:41 ` Stephen Hemminger
2016-09-01 19:15 ` Neil Horman
2016-09-02 9:19 ` Trahe, Fiona
2016-09-02 13:33 ` Neil Horman
2016-09-02 13:52 ` Trahe, Fiona
2016-09-02 14:15 ` Neil Horman
2016-09-02 16:13 ` Olivier Matz [this message]
2016-09-02 10:55 ` Thomas Monjalon
2016-09-15 14:22 ` [dpdk-dev] [PATCH] " Olivier Matz
2016-09-16 9:49 ` Trahe, Fiona
2016-09-16 14:26 ` David Marchand
2016-09-19 8:17 ` Bruce Richardson
2016-09-19 12:25 ` Olivier Matz
2016-11-22 9:50 ` [dpdk-dev] [PATCH v2] " Olivier Matz
2016-11-22 10:27 ` Adrien Mazarguil
2016-11-22 10:31 ` Olivier Matz
2016-12-15 13:46 ` [dpdk-dev] [PATCH v3] " Olivier Matz
2016-12-15 14:52 ` Ferruh Yigit
2016-12-16 9:36 ` Olivier Matz
2016-12-19 13:30 ` Thomas Monjalon
2016-12-15 16:09 ` Neil Horman
2016-12-15 17:22 ` Stephen Hemminger
2016-12-16 9:22 ` Olivier Matz
2016-12-16 12:37 ` Neil Horman
2016-12-16 13:04 ` Bruce Richardson
2016-12-16 14:19 ` Ferruh Yigit
2016-12-19 12:42 ` Neil Horman
2016-12-19 14:12 ` Ferruh Yigit
2016-12-16 8:23 ` Adrien Mazarguil
2016-12-20 17:26 ` Thomas Monjalon
2016-12-21 9:21 ` Andrew Rybchenko
2016-12-21 11:37 ` Neil Horman
2016-12-21 11:40 ` Andrew Rybchenko
2016-12-22 11:04 ` Ferruh Yigit
2016-12-22 11:35 ` Andrew Rybchenko
2016-12-22 12:07 ` Ferruh Yigit
2016-12-22 12:08 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a51d0d08-0b64-e070-e7fd-308aca25b31d@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=nhorman@tuxdriver.com \
--cc=stephen@networkplumber.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).