From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 8F4ED2BB3
 for <dev@dpdk.org>; Fri,  2 Sep 2016 18:13:12 +0200 (CEST)
Received: from lfbn-1-8252-96.w81-254.abo.wanadoo.fr ([81.254.151.96]
 helo=[192.168.1.13])
 by mail.droids-corp.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <olivier.matz@6wind.com>)
 id 1bfr8P-0006U2-2s; Fri, 02 Sep 2016 18:16:05 +0200
To: Neil Horman <nhorman@tuxdriver.com>, "Trahe, Fiona" <fiona.trahe@intel.com>
References: <48f9320b-9402-0ecd-8971-c3785778081a@6wind.com>
 <20160831132709.GA32000@hmsreliant.think-freely.org>
 <54a0164e-b242-b930-ec91-60f91b700119@6wind.com>
 <348A99DA5F5B7549AA880327E580B4358909A43A@IRSMSX101.ger.corp.intel.com>
 <20160901173519.GA11132@hmsreliant.think-freely.org>
 <20160901104122.41c131be@xeon-e3>
 <20160901191538.GB11132@hmsreliant.think-freely.org>
 <348A99DA5F5B7549AA880327E580B4358909CE45@IRSMSX101.ger.corp.intel.com>
 <20160902133327.GA980@hmsreliant.think-freely.org>
 <348A99DA5F5B7549AA880327E580B4358909D016@IRSMSX101.ger.corp.intel.com>
 <20160902141551.GB980@hmsreliant.think-freely.org>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
 "dev@dpdk.org" <dev@dpdk.org>, Thomas Monjalon <thomas.monjalon@6wind.com>
From: Olivier Matz <olivier.matz@6wind.com>
Message-ID: <a51d0d08-0b64-e070-e7fd-308aca25b31d@6wind.com>
Date: Fri, 2 Sep 2016 18:13:03 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Icedove/45.2.0
MIME-Version: 1.0
In-Reply-To: <20160902141551.GB980@hmsreliant.think-freely.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [dpdk-dev,
 RFC] drivers: advertise kmod dependencies in pmdinfo
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Sep 2016 16:13:12 -0000

Hi,

Thank you everyone for all these comments. I'll try to summarize them here:

a- the kmod information should be per-device instead of per-driver
(modalias-like)
b- there is no need to specify kmod dependencies (i.e. "uio_pci_generic"
is enough, not "uio & uio_pci_generic") since it is available via modinfo
c- the syntax with commas and colons is not ideal, we have no better
consensus for now, but maybe "&" and "|" are better.
d- the information provided is not complete:
   - some drivers requires module parameters or writing is /sys
   - choosing between one kmod or another is a system choice
  -> this info could be optional for this reason
e- for usual drivers having a "<generic-uio>" tag instead of a kmod list
may be more simple (I'm not sure of it though)


So we could either:

- drop this RFC, and like today everyone shoule handle the loading of
kmods on its own

- keep the approach of this RFC, enhance it with a- b- c- e-

   Examples of string to manage specify the devices wildcards:
     /* kmod list for all pci devices */
     "pci:v*:d*:sv*:sd*:vfio|uio_pci_generic|igb_uio"
     /* if we need device-specific modules: */
     "pci:v8086:d1234:sv*:sd*:some_kmod"
     "pci:v8086:d4321:sv*:sd*:some_other_kmod"

   this is not a perfect solution, but I think it would make the
   development of an kmod autoload script easier.


Any other idea?

Thanks,
Olivier