From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83C1DA034F; Wed, 10 Nov 2021 14:53:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51FE64068B; Wed, 10 Nov 2021 14:53:51 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 3385740683 for ; Wed, 10 Nov 2021 14:53:49 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10163"; a="219564133" X-IronPort-AV: E=Sophos;i="5.87,223,1631602800"; d="scan'208";a="219564133" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2021 05:53:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,223,1631602800"; d="scan'208";a="534052320" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga001.jf.intel.com with ESMTP; 10 Nov 2021 05:53:48 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 10 Nov 2021 05:53:47 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 10 Nov 2021 05:53:47 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 10 Nov 2021 05:53:47 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.176) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 10 Nov 2021 05:53:47 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iiscVhNBAnTV6HRx3008GwIVpneioPOeJuORh6jqLHckAfEXHlgqBw5oCuAExwpJP0tdTuCBWia8CW537+HOiw/nm/SBLCg8YlHOOtIiv0AgOCnjTzwXSCp6fmPOVsWNFH71mtnH3jS6jfqBvA4iq5WlLOf03IbacYnmMaqCDf94yMUdebiw8ClN1PCOHM/jPVECP95YAasF6yhChGFhZ1tsQyHceoBxpyn0jbl0tOjMxJ1bTDyJAl40domDpXmkh3WcvxHl2c1JKUlX8dhSakO0CNru6oWA1nSgmakP13zpOdx1GJ4kZ1rlYj9W9havxYaKqiYIm1eQdsgu9BGiSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xzk4749fdE9TNVj5VaAU1Uc4sJIcqLli9ny1NoBRW2I=; b=bzxLqsYwhx1gqnaXlrTBd1mgVFXXqAGW0qTs9DkUdGr/P7kuXGP3mCHI9PO9z6aVfHvgCZ2k5gxMsEmelgdYTPIGXa+H8RTAptQi3UZk2AOr85aBfuAZQoBPxZQe47wZnxICGDnjFcp7bH+54UkLmdEqMyXoaACd+BXq3qvlBceskdnB1amGQwSVeqEhFL0VWzZnO2Tb5UjsW5cLssmc/KWcTnuo22wLJkjIDiwjYmyuuyc4ccsahiL5BgrVwDfjyE9BlpQBqyBCCasGtvhUAU4r00QV+hsznaDGMDdSd625IJDcuYzqqFT55k+gGZ7gZY6Q4zENdiZxcn6J89J/Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xzk4749fdE9TNVj5VaAU1Uc4sJIcqLli9ny1NoBRW2I=; b=itk376/D9ahnzKNXTEVO04m6sa9+jfcDNPg033zNZuQMhO1YiVih0oGYroMtH4JEEikeQr4U60QJ4Arq1ucdkk7FlO/sDZAs5xbhjv++jFuj0KxmFYDB0xLIO6nHN1yAcBPJ0nBlUqsKKu14cIINzO6P0n7rjoMYmvyL/b+VB/Y= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5159.namprd11.prod.outlook.com (2603:10b6:510:3c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Wed, 10 Nov 2021 13:53:46 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%6]) with mapi id 15.20.4669.017; Wed, 10 Nov 2021 13:53:46 +0000 Message-ID: Date: Wed, 10 Nov 2021 13:53:39 +0000 Content-Language: en-US To: Apeksha Gupta , , CC: , , References: <20211109113432.11876-6-apeksha.gupta@nxp.com> <20211110074829.16654-1-apeksha.gupta@nxp.com> <20211110074829.16654-2-apeksha.gupta@nxp.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211110074829.16654-2-apeksha.gupta@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0280.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::28) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by LO2P265CA0280.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.16 via Frontend Transport; Wed, 10 Nov 2021 13:53:44 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cf01944c-de8a-4d90-bf82-08d9a451839e X-MS-TrafficTypeDiagnostic: PH0PR11MB5159: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cP6vYNybt5IzghmnvvnIlJpGIOVDWJ/MCINvSMeqJdw91MZHEoXE7NssEU97QVyK35gZjuRMlDxkVV3AFqFFJM44/Z3HxNHT/cm/JAkvMyvMSxJ9v1jK5c+tHpVCbCOlr1MrlV5UK/KOwx/UN1iErAZQKx2VGe2QDVT6MRaOFvXcOrRayIBRyNh0PRqoNTqTN8rciMyqWMVK3wFx4Na1Lzz/FsT0+e7A1eeKCK5+ZYEDhhqM7dmYx9SBo152oUqkh8r3euZ+kyWpNYb6LAfoyA1F3/0ZZ3dHOhU9V33G7P++FjhP1JkqelBPYhIPTveRC0uZ3tif6UeO9S2fqMpxHCJ13t8GWGibNFSkZHikh4JMtq0pGaFFtc1Zz1PopyAuodC9kfM41++/PuSRdb4UNSlOhHBNZ3zwIMGW92qUqpXeV8sFBer/8VxrtVjtY/4ehwt2dokJin0bszJqhf0/xjZtRuNyk+2w1/ulzTzDJMTHjkeSJr4/W2O4KjSRndGivuHmdVRYVpCbjIIhjS7KRAZMavotvDpwhTXZvy399eIhHRiSwYR/UCSIVHbMBIIQ3xgVlpmj6XHowQMy6z509DtuBz+6pB7TrNXJaR0qb9n3DxhMCTuQ6rlsgtth3mM2nKsUmLQgaVf/W05uW6TpE0jzuPHAkVm1N4GYAbl4sJ2MQaV68BvCIDmU/nNPXjV+cLZrarpvT781mjZgfCwUd0B0s2d59+ymOprF4Ako2qweUJmwQbGVxnOlkCBbUF0QRGfCHxYF0ScZzgxvRLk3Wvxo0hsJ/kZkHv2XC9OZOn0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6486002)(66556008)(66946007)(66476007)(8676002)(44832011)(82960400001)(2616005)(956004)(38100700002)(6666004)(186003)(31696002)(316002)(26005)(53546011)(36756003)(86362001)(31686004)(508600001)(4326008)(8936002)(2906002)(5660300002)(16576012)(83380400001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z3hQT2djeWJILy9jN1k4WHBkZ29MK3JxQjR3cHhEck95ejRBQnlkRkNvdDZT?= =?utf-8?B?NGQzRVdrajd5SlBsWHFvMlA0RUdabmkxbXpNd1dWVUIvQWVNV2gvSzFQMk5D?= =?utf-8?B?ZnMyZXRqYUpJb2thWDJna080dHIxblVrK3FKdUp6d1dWZ2JkWFdsNXhXZ0Qy?= =?utf-8?B?eHYxVGEzYU5naUovMDJ5aFNSOHhTdmtWVm5NaXNNc01sS20zMHJaMUo4WTho?= =?utf-8?B?RlYxdEMxQXh5OGVKRHhNbjQ3aG9xTDZGajFhMWxESGZlNTZJdkhRQjFsL0Fr?= =?utf-8?B?RDZHK25yaHllcEdvL2tnd3NRU0EyRVZNbzZqS2p1d01zcWxrVU9IdHBPVlF1?= =?utf-8?B?aThvdmt3ZTJZeW1pVGZYWCswbmVKL1c3dXYvL21yWHZiTEErNEZjallkKzA2?= =?utf-8?B?dEpIcmZiWDhHeHZPemR5c3k4QVZlbnRiUUFpOGZ6NXZtZy9xeENTWDNWUlda?= =?utf-8?B?K3RYWDAwam4wemJzQzZSSnNVUjIyWFpYRmNodDk5M3c3OVNKVmN4c2luU3M1?= =?utf-8?B?V21zRlVQRjdkOVVOM1JiVUpQd3hlUjhud2R5T1hueC9VZ244VmM2bXN0UkVT?= =?utf-8?B?VytVNmY3V2p5ZGxJMldXa1RUOGs4citIZURBZk9uVlhmcllwWUYySkU1dWx4?= =?utf-8?B?cFBGaTNvL1N5NGV2QjdtRGxSS0V6bUtGTElJT2w0bFRvVElhcFI0bkx0N3o2?= =?utf-8?B?Z2R0VTRzaWRFckVIOXZIZkV1NXYvRXBMcG9kWjdMazlXTlpZbTBiZmFWYzNj?= =?utf-8?B?aHVUanFLdWRPVWR6YXU0aTE5Vkw1azBvTDZSVE4ydzZEN0Y3dzFBczBzWk8y?= =?utf-8?B?SmxKQ21QU0gwZ0MvRm80UmZzZ3QwZHMwY08wWFR6OThZQTJHWUFZVXdBSVNF?= =?utf-8?B?eHp5YlpCeXJoZ0JNWW5sdFoveWdycm1HSFo3RTk1RVVhbkRHNzgrcDBZT09F?= =?utf-8?B?aVUreWJYZGh4bVVxeHR2NE9uWlFjWUIrZlRIV1d2MGZhcHU2ajhFVTgzOTlt?= =?utf-8?B?SkFBQmp0cTNTV0NMbXRiclZOQzlJRDJiN3BPZWhmR3JTTVRMWW8wZThWakJy?= =?utf-8?B?QjlxNm1BT080d1VNenZ0aVJJM2hUZHRvc2VMTWlyYzJ5TUNkelYwbkNqcm42?= =?utf-8?B?NW0ydW9NNDZFRnNGQjNsQms0Y3dXaUtRWUVXZGZLREw1MHdoVEM0OUZuS2do?= =?utf-8?B?QnR1amx4a0NSRnlCOW5oeHBFVlpncVo3VEZtbXpaNlVtczA1SVFVK0poS3p4?= =?utf-8?B?MlV3ampGZ0s4cWgyRnBxM1J0aXVGdWZXWk50S2xwVFJvL3VaVDNaVkVQY1Iv?= =?utf-8?B?M0gyN1JDRi9TS1JDeGhodTVTZzNwQzNhZk15L1owazh2NWJIbEJGZkVHRVhn?= =?utf-8?B?TEhmOXVHWHBydk1tS0J2NVNweFNQd0RBbDdvKy8xK3l3RmpaRGxsdmhZbnVH?= =?utf-8?B?STc5V1hibzdKdTJscy83U1hQZUpxUVZqWUp3ZmlDTDM4dGs4bGtTREdvamFP?= =?utf-8?B?THdaS2w5WFVGM1JCVFFzczkrcXpxdThQNHlYelVPNEZkR29Ta2o5RWFZT0RL?= =?utf-8?B?dS8xS2pxVVhFb1o5SDczYmVGSmQ3b0d5WDFOam5kM1JyV3lpLzZ1SEIxZ0pr?= =?utf-8?B?QjI4eVlQV1ZzYjFVV1JBVHJrNGNPMnVpZlZlcnFtNE0yN3Q2WVNTb05DaXZC?= =?utf-8?B?UEVNVlZ1WldJcTd4czVlaE9nUXNibEhEWVRKcENUbWVkeEZpcUw1M28xcXRi?= =?utf-8?B?S2lFZlgzaWpOTVRuUE5kNFRUZXZvczFiY2k3VTNCUTB6MVoza1NQMGNaelE5?= =?utf-8?B?blIwaVBSTlJUemdXbmlNc1NUVEtPMEUvbU5GMDI2dnRidng3WGE1SW85VEJ2?= =?utf-8?B?L2ZVVW1iZ2xwZkM3R2lHZENoT0F4eTlBNzFQTTV6MWZQRXFhcUFCbFhzbVEz?= =?utf-8?B?R3dpMGJvcXdQMUs1c2RHUkh3aDZaYks5VzB6UVlRNERibG9lWk1GYVE1a1JM?= =?utf-8?B?bzRKWVk0d3E5SGdlL1ZTZ3h0SVdPMDhsTlk1VkxidStoMDVuMjloK0pBYXdN?= =?utf-8?B?R21FL01Fd09pcjhNMk1KU1lWamJ1MGtvOVRkNjVWaVZHbDYwOGhKdUxrQWJz?= =?utf-8?B?elNtZFAzWFVieTlCK1p3Tlg3dlV1czNZWDF3MGp4bkUvQzR1U09qSkVMQXBL?= =?utf-8?Q?bCqmmHHSmYOTK7bEGgLbuUA=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: cf01944c-de8a-4d90-bf82-08d9a451839e X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 13:53:45.9819 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BHOyNd9DGlZc0VcBhYh6M09qQiAfSZ5hIEmPb+LhCjuaLCV++UpxGuAf6+xDipuir0S41ygX8fuwkzjZbQ42UQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5159 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v9 1/5] net/enetfec: introduce NXP ENETFEC driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/10/2021 7:48 AM, Apeksha Gupta wrote: > ENETFEC (Fast Ethernet Controller) is a network poll mode driver > for NXP SoC i.MX 8M Mini. > > This patch adds skeleton for enetfec driver with probe function. > > Signed-off-by: Sachin Saxena > Signed-off-by: Apeksha Gupta <...> > @@ -0,0 +1,133 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > + Copyright 2021 NXP > + > +ENETFEC Poll Mode Driver > +======================== > + > +The ENETFEC NIC PMD (**librte_net_enetfec**) provides poll mode driver > +support for the inbuilt NIC found in the ** NXP i.MX 8M Mini** SoC. > + > +More information can be found at NXP Official Website > + > + > +ENETFEC > +------- > + > +This section provides an overview of the NXP ENETFEC and how it is > +integrated into the DPDK. Driver is taken as **experimental** as driver > +itself detects the uio device, reads address and mmap them within the > +driver. What about something like: "Driver is taken as **experimental** as driver depends on a Linux kernel module, 'fec-uio', which is not upstreamed yet." <...> > +static int > +pmd_enetfec_probe(struct rte_vdev_device *vdev) > +{ > + struct rte_eth_dev *dev = NULL; > + struct enetfec_private *fep; > + const char *name; > + int rc; > + > + name = rte_vdev_device_name(vdev); > + if (name == NULL) > + return -EINVAL; I am not really sure if this check is required, although it doesn't hurt. Can you please share the call stack, how it can be NULL? <...> > +struct enetfec_private { > + struct rte_eth_dev *dev; > + struct rte_eth_stats stats; > + struct rte_mempool *pool; > + uint16_t max_rx_queues; > + uint16_t max_tx_queues; > + unsigned int total_tx_ring_size; > + unsigned int total_rx_ring_size; > + bool bufdesc_ex; > + int full_duplex; > + uint32_t quirks; > + uint32_t enetfec_e_cntl; > + int flag_csum; > + int flag_pause; > + bool rgmii_txc_delay; > + bool rgmii_rxc_delay; > + int link; > + void *hw_baseaddr_v; > + uint64_t hw_baseaddr_p; > + void *bd_addr_v; > + uint64_t bd_addr_p; > + uint64_t bd_addr_p_r[ENETFEC_MAX_Q]; > + uint64_t bd_addr_p_t[ENETFEC_MAX_Q]; > + void *dma_baseaddr_r[ENETFEC_MAX_Q]; > + void *dma_baseaddr_t[ENETFEC_MAX_Q]; > + uint64_t cbus_size; > + unsigned int reg_size; > + unsigned int bd_size; > + struct enetfec_priv_rx_q *rx_queues[ENETFEC_MAX_Q]; > + struct enetfec_priv_tx_q *tx_queues[ENETFEC_MAX_Q]; What do you think to construct the struct as the fields are used, at this patch only 'dev' seems needed. <...> > diff --git a/drivers/net/enetfec/meson.build b/drivers/net/enetfec/meson.build > new file mode 100644 > index 0000000000..6d6c64c94b > --- /dev/null > +++ b/drivers/net/enetfec/meson.build > @@ -0,0 +1,9 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright 2021 NXP > + > +if not is_linux > + build = false > + reason = 'only supported on linux' > +endif > + > +sources = files('enet_ethdev.c') ./devtools/check-meson.py is failing, can you please fix meson syntax accordingly, not only this patch, in all patches that updates meson file.