From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85E2AA0C43; Mon, 6 Sep 2021 15:29:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A632410EF; Mon, 6 Sep 2021 15:29:01 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 8E955410ED for ; Mon, 6 Sep 2021 15:28:57 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10098"; a="218106221" X-IronPort-AV: E=Sophos;i="5.85,272,1624345200"; d="scan'208";a="218106221" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2021 06:28:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,272,1624345200"; d="scan'208";a="512483659" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga001.jf.intel.com with ESMTP; 06 Sep 2021 06:28:56 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 6 Sep 2021 06:28:56 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 6 Sep 2021 06:28:55 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 6 Sep 2021 06:28:55 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 6 Sep 2021 06:28:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bGmv1mlnQ4x1F97jj3JpKTAvp4Rhm8t54/EAFssMBeHfpqLFtyQMKI+BG5QzAmGk5rTVlHoWwWDDT9cmS/Bs8hAqifnX2xpg9OTGJTKR46OADxmIf1t1oe3HEzBiH1ZYjLJHf5DetTq/dhyA0hlGoZZoUrJrvAAWPCcXd7KY3c22PsVRMpjzlhLX/oG5R1zVendO8hVWEU2ZcmDQ6ZoA6U4LWj+GS+b0A4D09wLZF5/OZDBKhr2r+5ivdzM0S6cgtz7MlR0wSlwBXGcuaQSi9HKXKKYfFWDt4Kxg7nuaPpJ15Qim5a3xIHxY1/6IjjomeRVUX2VLsa5bp3WjD9r4fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=DUj6jEBowc91/qQ2QPxOdhOSOsf+FGG3opIXt1H34a4=; b=aEp/X7r8voxAY7fj1gDsx2lE6HOvTi0cZJ5VyUGpNepFCUBRSVyGl5+XhMIqQsCQSEJzUkTTYmBFKoVI7CmJEh30E41hTz7JvTuDbc6HZEigN+INU4ICiTE4vUtp3od2yZhE/4ef6w0fs7LoFBBC4U6wkfUBLJIMrT/mnSzPxCZh7jcCWWNj7NeBKLGwG5BCQvbfLLAKbsfvHUILBMlt5w64glXkVIA947mtHhNh2WBmHNuAJf5aF021xWS4EtA5beLzVoHykQvA2LekJAKGcMpO7vVl9dgkJVP4FRBmjrGLZApMdwq1+J520x8DHaQV7u11xZFk9jDw5T02v9Fdbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DUj6jEBowc91/qQ2QPxOdhOSOsf+FGG3opIXt1H34a4=; b=iofGIAvoJdVhP2tKIDWxX2KVlRC2EzhGW0IRo80i5pGf6cqCxf5YWbzMo3U5yxV4y8Ge56wUbpDNRcIza789dDWCnkpynb65CseCfqcDuDkPmOh1/rk2Bmc9o7O9Bf67uvxUJRiXif50P3Z721NlSAnoWgng8Zudmp7aLH7XzPA= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from BN6PR11MB1474.namprd11.prod.outlook.com (2603:10b6:405:c::17) by BN6PR11MB1828.namprd11.prod.outlook.com (2603:10b6:404:103::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.25; Mon, 6 Sep 2021 13:28:51 +0000 Received: from BN6PR11MB1474.namprd11.prod.outlook.com ([fe80::31f6:1363:2b26:8a8d]) by BN6PR11MB1474.namprd11.prod.outlook.com ([fe80::31f6:1363:2b26:8a8d%4]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 13:28:50 +0000 To: Bruce Richardson , Ferruh Yigit CC: Stephen Hemminger , References: <20210901061821.5259-1-aman.deep.singh@intel.com> <20210901101253.6991a2f6@hermes.local> <557a6cce-a043-357e-9f00-ea15025bf43f@intel.com> From: "Singh, Aman Deep" Message-ID: Date: Mon, 6 Sep 2021 18:58:39 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: BM1PR0101CA0072.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:19::34) To BN6PR11MB1474.namprd11.prod.outlook.com (2603:10b6:405:c::17) MIME-Version: 1.0 Received: from [192.168.1.18] (223.178.209.11) by BM1PR0101CA0072.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:19::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 13:28:48 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 49d97305-b488-415f-1c5b-08d9713a4369 X-MS-TrafficTypeDiagnostic: BN6PR11MB1828: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1775; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fmTa/ZDhdgkL0dGfLyC372chlzsaci9VLpDI3LOFKJ9e3f4wDpoiuBf/z4TEZW84WZKj4tvnec7d3hn5z1ImGPT82+e4IlDIy84agN/BC003auT4GkySCAwD83y08EX5U3k49FZhc4PXthIFtDdmQB3y70KYt0YEa1v26WpsPJj/39LpmIkPl6EUwld0OgJMyiFlICPqneBUWWn4CvI5CkHnL6PFR5s2NpZP7HZfSCMZq2EJDo0DgJYbmbB3pSSaxUMygh9qpz2fnVVDSjTJzY3bj29p7ScvI4J7LCxBNbP0+sw6yFh14jWSU0ozauc95qzWhOG7qvpNSLUFQd0H3vcnDd8liqoRJNZpWTr56lH/XF/BJewm60d9/PiUJk9gf6rPCf2Sg6SmV03hQfHlI9YGZy6ssAlESl3lNOChbZ259NooTwCTfbbX2FKNB8PhbhcUPEK8D/jIdbeB6yXG18JkWZC5eLXx7iaPXcigaB5MoSkwwYXqFKoxhNH5/OpyGMfP5XPK1/pENpjREhQJ7PTKBDuOlopZb8c89ucuFn4jFV/gO775jST5X5wwnA6Kusyjpk9UPRXr6g7/PHIUniG8dFWS41DBsRNfatZLUonXG3NmgV0SNnjn7PW7eXYT81U8jjFDIaDKvPj0quNyUUQz3i5yh3peIB3NctRVJ2NmW8+OSPoIUukX9ITDBUnnGNn/EGXVbyP5yzkIRklP6GHz2By5u+ONpsjy35Bs/TI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB1474.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(31686004)(83380400001)(6486002)(6666004)(4326008)(508600001)(66476007)(66556008)(2906002)(2616005)(38100700002)(316002)(66946007)(8936002)(16576012)(36756003)(31696002)(86362001)(956004)(53546011)(5660300002)(26005)(186003)(8676002)(6636002)(110136005)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHhPd0JVNGc4MjRBc2F2QnBRcmdkNDU0YTNBWXpmN0NlVW5wSDZ2U3FOUnhT?= =?utf-8?B?b0NkQVRNY1JQTDRSK2ppb2xFUHlhR3RLTW8waFJSZlczTEc3alVYajUwQ25E?= =?utf-8?B?b0pRanM0RXcvdlFXRk94K2lOWlZpVFZKUzczVkM0YVNyKytYeTJ1YTJPT1Na?= =?utf-8?B?OUNGaVNTZ2hBWFRLZXRFREVPUC9vWlNsSHNsaGp5REhQZ3pkT3lqUVVPbEhh?= =?utf-8?B?Yk01RU01N3lTOWN0M1JGRU1BT3BNc1drOUFyRUVIMG9WVDdLZ1dMMm14bENm?= =?utf-8?B?am44TVhodWhUbmRqUEs3Y3U4K0YrZ1NacnF6OEl5UHRyTTVsWHNNaWx1Vkt1?= =?utf-8?B?TEtEYitlWXgxVFBTUVlEY2YzV25jOWdiTTVnZk5MWk9jSW5SK1JQWisxR0wy?= =?utf-8?B?aERja0VRa2E3b0tFL1BpeGZBRGpraHU3SnJaNTR4eW4wSlJsUDZHaWhaU1Z4?= =?utf-8?B?UW9sTU1PSjVOb3dlbitTZWtRZm1IMXJ5UGxMdWYzVVFVQjFQTTNHclduUEhH?= =?utf-8?B?NllBNzY5eFBtUGE0Tmc3aDFGOXRNSHAvQ0RQWWlDYlk4clIyekN1NDNuNVMw?= =?utf-8?B?UE5IQ0tPOC9MQ1hWYzExbEJuVkxiRmhMU2lBNHV5WFZGVGJ6U21ZM1RtcXli?= =?utf-8?B?bmV5VlNVK0s3bWtQOURqRERjalRqK1pLVSt4Z0FXZTFsNDFHd0JnU3F3L25x?= =?utf-8?B?NnFTekh4T0hYQ3ZhbXFNam1YcnNrUmh2RGlnWUp1cDVoQmUyR0VTM3dVdFlv?= =?utf-8?B?N205UmN5TVhDSm45VmxDc2RFQmQwc2QvYk00Y3lUaEpSamtxK2hWaUUyQzdP?= =?utf-8?B?ZVNScnhMejlwaU9QdzliZCtHUmhNM3dJWFZsbm1PbFRHQWFMOGVmd1oxbUk0?= =?utf-8?B?bnpCeS9oSGpkclpGc0lGUVNOOHEwR3hBMGgzOW9CNFBSeFBHZy9HUWY5VS9o?= =?utf-8?B?WnUxYVRTcXFmWmJMQ2RFUUk2eHpTYTFhdFhwczJaakVoZzM1N2s5MzlzUFpT?= =?utf-8?B?WHpyRW13NlNSc1R4UDVQdnNiaFJCOS9FdjI0bGV4N2tubklCN3JKblNicHBk?= =?utf-8?B?aHFuVmZOd1NxSnYzem9XZTBVdFJqdStzZ0pkNGU1NnFPSDJnWHZVSDlEQjli?= =?utf-8?B?R1hjbFV1SVdtckhkNU9rdUh4OVBXaHV5c0tmQ2hGaFpLQ3ZUa1VSY0dKMnlJ?= =?utf-8?B?ajZ4Vk9WZmVFQklPK0ZkcEFkWGlVbmZIbXVRVWNxbFNibG5KYVozS0R3aURT?= =?utf-8?B?UXJCNkIyUE42U2ExWVQ3MElqZmFhRWYyNUhTRDZ3UFdRSWs1eXFkRHlHanFt?= =?utf-8?B?RXNieGszQ0pabEFkeldJRVFsYUh6ekUrM0FEQW9id0g0UUhPMlhsdFUzSnFV?= =?utf-8?B?OXZtYlBOMXIrWGlPeXJwUTU1amhTalIvRUpjNlBweUMwVzErMWpGUlFjWWhu?= =?utf-8?B?bHlwSkpaR0lrMWwxK0x3VnBZV2xVdkQrWjcyUWFxVjhQRW0wYk1qcTkzREFN?= =?utf-8?B?Mm1DZldCSjBidStuU2ljbGpLWXl6OVQxYUdQM0pQNXhCSzVNdnpXbmU0RFcv?= =?utf-8?B?OUNXYU9xNExkK05oQTU5RzZTVittK25RVnpvbVA2NHUyZWpCQ20zSmUzR1Az?= =?utf-8?B?MnlyQldlM2h4ZmJzZHhVRTZheDE4TTRSbDlKK25oQmYzaFBocmZHbHhEVW4w?= =?utf-8?B?a2xLNU9YTDgyT1hwVHBnbTBHc3A2VGJPa0FuTksxWks0OHBHQnZCVklWZlJq?= =?utf-8?Q?/fqFLEok4UYa4IUHHTIEPOb4+dRIww628V3XGgr?= X-MS-Exchange-CrossTenant-Network-Message-Id: 49d97305-b488-415f-1c5b-08d9713a4369 X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1474.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 13:28:50.4368 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JAl97HC6MVJnj/OuWfUA7OLlVKG3I1VB2J2af+ETzZJOlE1ktiPtN0zpwck3Uxpi/qn5PESg8bcQZ5xxvRCTdJRM6QF7+sY12WAd77JOazY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1828 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] eal: add log to print dpdk version at start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/2/2021 3:57 PM, Bruce Richardson wrote: > On Thu, Sep 02, 2021 at 11:11:39AM +0100, Ferruh Yigit wrote: >> On 9/1/2021 6:12 PM, Stephen Hemminger wrote: >>> On Wed, 1 Sep 2021 11:48:21 +0530 >>> Aman Singh wrote: >>> >>>> From the logs it is difficult to get the DPDK version >>>> that was used. So added a debug log to print the same. >>>> The log has been added in eal_init so it gets printed >>>> at startup for any application. >>>> >>>> Signed-off-by: Aman Singh >>>> --- >>>> lib/eal/freebsd/eal.c | 2 +- >>>> lib/eal/linux/eal.c | 2 +- >>>> lib/eal/windows/eal.c | 1 + >>>> 3 files changed, 3 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c >>>> index 6cee5ae369..a14a205f4d 100644 >>>> --- a/lib/eal/freebsd/eal.c >>>> +++ b/lib/eal/freebsd/eal.c >>>> @@ -958,7 +958,7 @@ rte_eal_init(int argc, char **argv) >>>> } >>>> >>>> eal_mcfg_complete(); >>>> - >>>> + rte_log(RTE_LOG_DEBUG, RTE_LOGTYPE_EAL, "DPDK version: %s\n", rte_version()); >>>> return fctret; >>>> } >>>> >>>> diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c >>>> index 3577eaeaa4..a50960cc78 100644 >>>> --- a/lib/eal/linux/eal.c >>>> +++ b/lib/eal/linux/eal.c >>>> @@ -1332,7 +1332,7 @@ rte_eal_init(int argc, char **argv) >>>> } >>>> >>>> eal_mcfg_complete(); >>>> - >>>> + rte_log(RTE_LOG_DEBUG, RTE_LOGTYPE_EAL, "DPDK version: %s\n", rte_version()); >>>> return fctret; >>>> } >>>> >>>> diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c >>>> index 3d8c520412..5e6d5d8930 100644 >>>> --- a/lib/eal/windows/eal.c >>>> +++ b/lib/eal/windows/eal.c >>>> @@ -419,6 +419,7 @@ rte_eal_init(int argc, char **argv) >>>> */ >>>> rte_eal_mp_remote_launch(sync_func, NULL, SKIP_MAIN); >>>> rte_eal_mp_wait_lcore(); >>>> + rte_log(RTE_LOG_DEBUG, RTE_LOGTYPE_EAL, "DPDK version: %s\n", rte_version()); >>>> return fctret; >>>> } >>>> >>> NAK >>> DPDK is already too chatty at startup. >>> >> Is it better if the log is 'debug', so it won't be visible by default? >> This can be useful to support customers, sometimes when there are multiple >> binaries around, it is hard to say version of them. >> As Bruce reminded, '-v' eal option provides this feature, which is better than >> nothing, but it is not as useful if you are looking to an old log without actual >> binary. >> >>> If your application needs it then do-it-yourself. >>> >> Application may have its own versioning, which can be unrelated to the DPDK >> version numbers, this can be useful to get just DPDK version. > I'd also point out that if you have a currently running DPDK binary and > want to know the DPDK version number, just connect to the telemetry socket > and it will tell you e.g. > > $ echo "quit" | sudo ./usertools/dpdk-telemetry.py > Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2 > {"version": "DPDK 21.11.0-rc0", "pid": 134894, "max_output_len": 16384} > --> > > $ > > > /Bruce Considering the EAL "-v" option which does the same job as this patch. Planning to drop this change for now. Thanks Aman