From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70D4BA00C5; Tue, 15 Feb 2022 13:44:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 004CB410F7; Tue, 15 Feb 2022 13:44:50 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 2EE3540E78 for ; Tue, 15 Feb 2022 13:44:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644929088; x=1676465088; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=70bQiECmknXMZCX1t+wIovf6iEK2gqzjNku6QaT3VEg=; b=KzXXZvpMpT/QowcYBlD4XjJKzuD9I+mx5gehJVcNmBotK/N0W4CU7BPi bNcrEWFDcVRXCX1pWqNuE7YrCaxhl9hhB/cE1VQGQOBms4C3uhUoHY9rI xjX3sISq9bZRIBgWONQ2O2fJBg6jzRGKE375vCAuugJrAyNchjSd4/ZmL nL5sWisOAeSgw/ybOighosFU6fnsj2MMSRTSFAiK3m4N8vSV6Pe1lraAt c8KCVOI4/93+TMN982OHjF2hUuGlI8xLF3zhySRXLaIL6nxD3UCZySNnw fS0lCbzxigGOa/womX7ddmJhLCLWcqdC4bAEgd7qB9kZykms2z13iJ3+a Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10258"; a="230971128" X-IronPort-AV: E=Sophos;i="5.88,370,1635231600"; d="scan'208";a="230971128" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2022 04:44:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,370,1635231600"; d="scan'208";a="486156432" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga003.jf.intel.com with ESMTP; 15 Feb 2022 04:44:46 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 15 Feb 2022 04:44:46 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 15 Feb 2022 04:44:46 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 15 Feb 2022 04:44:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QI7vysAi5HKJOnv08I9F4gV/AeqTlo2yhSgeasO/p55mcvTVCzUQitDvgggJx5kELyGOQxAgi4TGVYprLTKv7YBsbl+j/x8FeG5jvOdXgYSOSxs0T8d2JViVMd2hfiFjKUswQvGYkJ1VNr2UZ2TewCh46PDsramAE3EfLyq7mEepPcUHDPEaANQT/d/7Xr5AJH8pisxJ41nwjty3u9TguJ6qz1aOofKy3AfDu6CRXSoYQ6u56FeWsulJkMImf0ev3n4n4uxVVutozPg+s1H2QSRWbFaI8/blztWkcIVqY1dFO6+AgUhFUjomnvoe9TXeswh2Q5pVRDvo5s8fuXsXgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9i/fVX+XVHQ/NkVnYJDKfh90n21XP7G/odHQ3BaMhqM=; b=TSSunRRXu7Ab96uMJkYRcEQr24tnDOgxJgiPF2D6E6xD//Tla3sy2AWiM8DyUMMj/KLbtYAeGSi5jtQJUmiE0dA1cs24Ju3mdVVMzLL0aKZ17JC7vWn89J2oNjfQFNgQpADdy56sNSNIi/2INYLzrQCOFJO9ekf6yA1X7iVCPHBLaqPYutCsCgYCT+EZRVBxt8CklHLcYeioLQqEXpA4XYEyw7ZjBcDvzLvm31efHK2vZq8+88Qc4w1V69EVGE6OYLOxKLUZoVT8Madfkp/vbCxLDHTsDxUV+qA5uqXnwCOnduhtW8t6Cr5GbaaErO0rMU/EmUWtdh2axFTRaPXfnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by CO1PR11MB4833.namprd11.prod.outlook.com (2603:10b6:303:99::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Tue, 15 Feb 2022 12:44:45 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022 12:44:44 +0000 Message-ID: Date: Tue, 15 Feb 2022 12:44:38 +0000 Content-Language: en-US To: "Nicolau, Radu" , Jingjing Wu , Beilei Xing CC: , , Kevin Traynor , Luca Boccassi References: <20220210130923.1442905-1-radu.nicolau@intel.com> <05a27976-6664-190c-38b7-9b63c7294973@intel.com> <23e5a111-9402-d6ce-a076-5dbcb24f5937@intel.com> <0e492107-2325-8f79-7a7f-ad652c40c741@intel.com> <61a3edb7-3d5c-1df8-52bd-26f4a951ad5b@intel.com> From: Ferruh Yigit Subject: Re: [PATCH] net/iavf: fix segmentation offload buffer size X-User: ferruhy In-Reply-To: <61a3edb7-3d5c-1df8-52bd-26f4a951ad5b@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0264.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:194::17) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 15e2bead-5d28-410d-bfa9-08d9f080f12f X-MS-TrafficTypeDiagnostic: CO1PR11MB4833:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:972; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: U4jKumhmLkg7xqrvSSQFEPLJg9WuBknSozyh1RAJfY1jzMScFJw+WMaElDh+VJ1cnjUXmwX765KCPmFl/XjAtrvksTsrrFgMCqxyj8TEKSGwE42ENRoa0DXTBhHPvCbzv0KKhv0jhuhNmAssPlViDKorNIQN1UGBQG78Y5oLSRBuG9yEThxydyRgzgoZozSnIX6pA5pKoQnIwMw6kuhAwzngBzlQOqXv0xdtG7Bqqhq7GXiSBgcRXOkmPmGmIRB1hWGdOsnmynde0d/nzJba9tgSlX8vLTEApBhAONgbkTKOQvyP1benkZWGIPZwf42tgJTFXrzrFmuIFnBqoE+4/TT3OQfAo7ow5p6Wy7L+WNiTVAtaVs7xUVFXtvk3dpVV0VXjd0Fdmb2pzBjyGoXn6DnTl0b+CeBFn4PwdC2vvO3+3ZuYKpSM0Nv4l9o+7o1kyRNHW/Qvm+EKptOPlHZzOsuBP9XKXIKJSIyz+f0z50v5ygULHVjyi0LHtsddjzwjmBKMBvz2UXC6JZiPacHeO9y6iuE6WikCwH7vTRiVfHXgIT2pPzWfdJonq0ZO2k1D01IC44h977Ozyj5gbRbxRpjyBr10oTs5XF2LAxIYKTFCsfqahdZzT8beY3Up8sT/tYnhFk5hixDW2WVC57ky+fS6tnYHcP9GHM24/K/hep4XAPE2qpGI0Ru5nOD3KXlsAkTx7R2hpqAPB13dlZgEfg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(4326008)(2906002)(2616005)(66946007)(110136005)(6636002)(66476007)(66556008)(8676002)(316002)(26005)(186003)(54906003)(31696002)(86362001)(31686004)(36756003)(44832011)(6512007)(6666004)(6506007)(53546011)(38100700002)(82960400001)(83380400001)(6486002)(508600001)(5660300002)(8936002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TEo4TUszbU5yamFEdFN2OGVyeUlQY2QwNSthTkhpd05PM1hnQUc4Tm5Kdkwv?= =?utf-8?B?blVBMUpYQXlSczJmRU9Ta20xYk1FRE9FY0d4S25FL0FJbU5yMjV6V2tIVGEw?= =?utf-8?B?TFpYVkFOMG1ZaFhBK2FQQlRNVGROVWRIUEhDdXhpZktwMU44UlN2Z0JzRmlI?= =?utf-8?B?Ykh5U2pxUnVFRWsrU3JocGZIRE8vZjkrZENQakVkaUpZZ0hFaFVOY3B5RjlQ?= =?utf-8?B?VXlITXNLT3pGNGZpeVJ1M2Z6UHNLSVRNREZ1d3ZiS3hRdjJabDlRWlRyazVE?= =?utf-8?B?Q01xRlBKMml5WlMvUDBiUi90cGZMYTlDR0VNTWUyc0U0dzdDL1YyR0RWdFNi?= =?utf-8?B?eFJQV3A3QlhPSU9RTys0MnoyT1l0OVVPbEZqUE4rMitsbjhXaHcxaDYrWUky?= =?utf-8?B?ZmdJaUVKK3BBVkVwb2JQcDY5SnhRV2hPanlKK3NZcmhzQXBwWExOenFaY0FY?= =?utf-8?B?UkM0N3IrUjVOaTNScXdSL1IxZjZ2VVQ1eUVWWTBTTlhFTnU0d3BqSXEvdm1L?= =?utf-8?B?eXZmemJvUDJHRktodXVUc01KUVlsQzdQZTdjSkZocnlROXZLZXB0dWhaRUZW?= =?utf-8?B?ZXEvQndieklhcFBjRFZQamJQK0FrcGRvTTV6ZzhiRm52SlZXZkZNSUhhdFo1?= =?utf-8?B?cnAwdmN3SUkzUnpiZWh5elZnWDAwQ2ZtV2gwaXZnTHlOaUVXcWh5Zm5GY0tC?= =?utf-8?B?STM3c0ZUcS9QeW8yOHZiTG5nMWNyeDdFbmRNallJWTN4dmZiWXRQV2thT0p5?= =?utf-8?B?V1VLRzRGUFU4WERYNCt6WHIxaXFYczViQzF1VStRalhRRkFxeWtRa1VJQldm?= =?utf-8?B?ajgyVkFuaUxVNTZOcDJ2dHVMVE1kcVVkQk5CZ29MWWdEL2d2L1habXU4blpZ?= =?utf-8?B?WW5na1pKNkN2UjhwRGIweWk0UGdibXBaRHg3d3JzdEkxTjN1TWZ1MnBwMSs2?= =?utf-8?B?S0ZaQS9BN2xPZC9DTEE5WTNmbVFrSVhudFB4TlloUmdING1hckFuU1ZFRUJB?= =?utf-8?B?dUJjalJSaTY1REk5QjExQVR0YklsaWx4bjN3RmxwemkzcWkyNitvWWwrWnBq?= =?utf-8?B?dXlnRlczU05rdGtrblJJQnpZa3htSjRnRWxRSGZHL0JQSjA4andaT2xiaFI3?= =?utf-8?B?S05WQkNhY2x2TkhETzNaSWZISW1CbmtaZjdyYmFXWWFCaDlMMWkxZ3dEMzRu?= =?utf-8?B?OTZSbEdhZUs2cnZKM1NzSjc2eVhVOElRd0FvSTA1QXY3S1VjYS9pQjNyZkVu?= =?utf-8?B?bDhwOHBTTXExWlZFMWxQNUtKWktxWUdxWFA2UU00YjA0L3lkMmFoMEZrMm9G?= =?utf-8?B?QTZhVlUyS3BhbDdnYTB0Mi85U29FR0pjUThETU9sVGdKR0pvbDdYT2R1eExl?= =?utf-8?B?WDVoTWdCeDRNM3JRZ2xhb09uZlFWUVNtZEpwb3dMYzBoKzZMWEhNR0kwL0pS?= =?utf-8?B?SHR4TlFrVVprUUFObE1FcGNyNDJYdEFvbjZSeVhqdFl2cFFKTmdMSnA2bjFY?= =?utf-8?B?TXkrbVA1cFhNc0lGS1UwY1FjWHlXVmo0RWkwQVk2QVIxRW5zbitpSi93UVlV?= =?utf-8?B?ZkJETjVzaGYwN0F5d1FaRWlKRFF2QkJuZ2lqQ1NRWDRyTlp3RE0wVWJyRllV?= =?utf-8?B?N1k5WVNaaXBIOFYzK0h4UUtIaWF5R0xXa0RDeVVPK29Ed2hQaU4yQU1EZnpV?= =?utf-8?B?dUZjZXVTMUVtUGYzWHFzYmVERjBjcEhBWTVna1JrWWJuaFM5elBBMUNkaytJ?= =?utf-8?B?d0dVUHhjZWlmK3FSUlc1U0NZSGl3bHo0QUlZUzI0WnhCQ2xoRjUyRUdaZmhV?= =?utf-8?B?ejQrUmQ3NkJQQ0dQNWZJSGE1L3ZIWGFWdm96N002UUd1eDlpR0R3aGdRaXJC?= =?utf-8?B?S0duNjhXTi9LRkJoZ0cybWkwT0hpb1RVNENwZFIxUDZ5SDAzeFExRjhLeFFQ?= =?utf-8?B?UU90OFovdDY1ZVRjdjREU0VHM0xhWDRwTUhKdC9Yb3M0dlFYS084YUZ0SnI0?= =?utf-8?B?a1hMK1JNUDF3dE5odDJSN2ZZbEZ4RUNVbXh4YTVzR3ZMczJycHNKVFdWb0Rq?= =?utf-8?B?aEhPcmR6UVF1dUhFWHJkVjR2aUp6TVV6Ym80cXFPVHI4aU1uOU9EQ2p1WkpD?= =?utf-8?B?QmVBY3pzU1JIbkR6UVQwYkJWK3owck1nT3Q4Tk9OWk1BSVZoakdUd3BKckpv?= =?utf-8?Q?faCMyQbqbfY2ukvdmjg6rlU=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 15e2bead-5d28-410d-bfa9-08d9f080f12f X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 12:44:44.5053 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IFejzX3ZYljT5PIV37iZkdDES80TJ9owim6zJKpghRM8vMZkWeLqPgAqmWRSyvKcBE1K7MOFrIJ5bUQIR4NU6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4833 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/15/2022 12:30 PM, Nicolau, Radu wrote: > > On 2/15/2022 11:19 AM, Ferruh Yigit wrote: >> On 2/15/2022 10:47 AM, Nicolau, Radu wrote: >>> >>> On 2/15/2022 10:06 AM, Ferruh Yigit wrote: >>>> On 2/10/2022 1:09 PM, Radu Nicolau wrote: >>>>> This reverts commit ff8b8bcd2ebe, which resulted in incorrect buffer size >>>>> being computed for TSO packets. >>>>> >>>>> Fixes: ff8b8bcd2ebe ("net/iavf: fix segmentation offload condition") >>>>> >>>> >>>> Commit 'ff8b8bcd2ebe' was already fixing segmentation offload, >>>> are we having the initial issue back when this patch reverted? >>>> Is there a fix for that initial issue? >>> The initial issue was around a very specific usecase - IPsec transport mode TSO and it is very likely back with this revert. But it's a much less severe impact than general traffic TSO. >> >> Got it, so this revert brings back an issue, should >> we document this in the commit log of this patch? >> Plus should we create a Bugzilla etc to record the >> introduced issue? > > I plan to follow up with a fix shortly. > > As for the commit message, since this was not merged to the LTS and main, do we really need it? > Not for the LTS but for main repo. We know merging this patch will introduce an previous issue back but that is not obvious from the commit log. I think it helps to document, in commit log, what issue this commit brings.