From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 701B4A0C3F; Thu, 15 Apr 2021 17:31:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E8C916237F; Thu, 15 Apr 2021 17:31:07 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 9638216237E for ; Thu, 15 Apr 2021 17:31:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618500664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C60aIfBGUDmIA5ojvchPT1StoX453bllIiJxViAOW44=; b=TibZI/hKFVFSYV+T+qCenIRpoiZy0cWVEI4nb/X9rzDicp1OAVDqICnIzQ9ARlu+xYQCG+ HIqJ/osIbN31mqRbcOd++bv8iG6gnsSGRPmomWBY/rv522Ug8vk/MHih+16aYm3p7GunFU tFPe4YjHwv98VRqUSbIKTWSh21vw86c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-549-tN8hzrdDOGOFyLkIDzxJyw-1; Thu, 15 Apr 2021 11:31:03 -0400 X-MC-Unique: tN8hzrdDOGOFyLkIDzxJyw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 251BD814256 for ; Thu, 15 Apr 2021 15:31:02 +0000 (UTC) Received: from [10.36.110.28] (unknown [10.36.110.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 84BCB10023B0; Thu, 15 Apr 2021 15:31:01 +0000 (UTC) To: Balazs Nemeth , dev@dpdk.org References: <589dabc3c3a22a8e297e09cb554810aa811bc9a7.1617790501.git.bnemeth@redhat.com> From: Maxime Coquelin Message-ID: Date: Thu, 15 Apr 2021 17:30:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <589dabc3c3a22a8e297e09cb554810aa811bc9a7.1617790501.git.bnemeth@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 2/4] vhost: perform all mbuf allocations in one loop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/7/21 12:17 PM, Balazs Nemeth wrote: > Move allocation out further and perform all allocation in one loop. The > same goes for freeing packets. This is to prepare for use of bulk > versions of these functions. > > Signed-off-by: Balazs Nemeth > --- > lib/librte_vhost/virtio_net.c | 18 ++++++------------ > 1 file changed, 6 insertions(+), 12 deletions(-) > > diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c > index 666e7fdb8..496f750e3 100644 > --- a/lib/librte_vhost/virtio_net.c > +++ b/lib/librte_vhost/virtio_net.c > @@ -2471,14 +2471,13 @@ virtio_dev_tx_packed(struct virtio_net *dev, > uint32_t remained = count; > uint16_t i; > > + for (i = 0; i < count; ++i) > + pkts[i] = rte_pktmbuf_alloc(mbuf_pool); Same comment as for previous patch, we need to check whether allocation succeeded.