From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7992342DCC;
	Tue,  4 Jul 2023 08:20:13 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 0B36640F18;
	Tue,  4 Jul 2023 08:20:13 +0200 (CEST)
Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])
 by mails.dpdk.org (Postfix) with ESMTP id B6DCA40E03
 for <dev@dpdk.org>; Tue,  4 Jul 2023 08:20:10 +0200 (CEST)
Received: from dggpeml100024.china.huawei.com (unknown [172.30.72.53])
 by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4QwCJj2QNLzLngS;
 Tue,  4 Jul 2023 14:17:57 +0800 (CST)
Received: from [10.67.100.224] (10.67.100.224) by
 dggpeml100024.china.huawei.com (7.185.36.115) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.27; Tue, 4 Jul 2023 14:20:08 +0800
Subject: Re: [PATCH v2 1/2] doc/contributing: provide coding details for
 dynamic logging
To: Bruce Richardson <bruce.richardson@intel.com>, <dev@dpdk.org>
CC: <stephen@networkplumber.org>, <mb@smartsharesystems.com>,
 <ferruh.yigit@amd.com>, <jerinjacobk@gmail.com>
References: <20230613143355.77914-1-bruce.richardson@intel.com>
 <20230620170728.74117-1-bruce.richardson@intel.com>
 <20230620170728.74117-2-bruce.richardson@intel.com>
From: fengchengwen <fengchengwen@huawei.com>
Message-ID: <a58eca8a-cc07-e51b-8b22-4a39167c13d6@huawei.com>
Date: Tue, 4 Jul 2023 14:20:08 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <20230620170728.74117-2-bruce.richardson@intel.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.100.224]
X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To
 dggpeml100024.china.huawei.com (7.185.36.115)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Acked-by: Chengwen Feng <fengchengwen@huawei.com>

On 2023/6/21 1:07, Bruce Richardson wrote:
> While the section on dynamic logging in the contributors guide covered
> the details of the logging naming scheme, it failed to cover exactly how
> the component developer, i.e. the contributor, could actually use
> dynamic logging in their component.
> 
> Fix this by splitting the details of the naming scheme into a separate
> subsection, and adding to the introduction on logging, a recommendation
> (and example) to use RTE_LOG_REGISTER_DEFAULT.
> 
> Similarly, when discussing specialization, include a reference to the
> RTE_LOG_REGISTER_SUFFIX macro.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---

...