From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id C6C4D2BA2
 for <dev@dpdk.org>; Thu, 20 Apr 2017 14:00:00 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga105.jf.intel.com with ESMTP; 20 Apr 2017 04:59:59 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.37,225,1488873600"; d="scan'208";a="1158723226"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.59])
 ([10.237.220.59])
 by fmsmga002.fm.intel.com with ESMTP; 20 Apr 2017 04:59:58 -0700
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: dev@dpdk.org, david.marchand@6wind.com
References: <fb02eec6-068f-d5fe-1b4a-054e92e406d9@intel.com>
 <20170420090140.30566-1-nicolas.dichtel@6wind.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <a590a8dd-994c-ee21-3a2b-03f379bbcc7e@intel.com>
Date: Thu, 20 Apr 2017 12:59:57 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.0.1
MIME-Version: 1.0
In-Reply-To: <20170420090140.30566-1-nicolas.dichtel@6wind.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2] igb_uio: switch to pci_alloc_irq_vectors()
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Apr 2017 12:00:01 -0000

On 4/20/2017 10:01 AM, Nicolas Dichtel wrote:
> pci_enable_msix() will be removed in kernel 4.12. The new API is available
> since linux 4.8, thus let's use it.
> 
> Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=aff171641d18
> Link: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=4244de1c64de
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> Reviewed-by: David Marchand <david.marchand@6wind.com>

<...>

> +#if LINUX_VERSION_CODE < KERNEL_VERSION(4, 8, 0)
> +#define HAVE_PCI_ENABLE_MSIX
> +#endif

Would you mind moving this check to the end of the file, to preserve
version check in increasing order (although I aware some doesn't fit this)?

When above done:

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>