Re: [dpdk-dev] [dpdk-stable] 17.11.10 (LTS) patches review and test

[Kevin Traynor <ktraynor@redhat.com>]

On 22/01/2020 12:37, Luca Boccassi wrote:
> On Wed, 2020-01-22 at 05:27 +0000, Yu, PingX wrote:
>> Luca,
>> Update the regression test result of Intel part. See the details as
>> below.
>>
>> * Intel(R) Testing
>> # Basic Intel(R) NIC testing
>> * PF(i40e): one compile issue is found and we fix it with attached
>> patch to go ahead the test. All passed. 
>>   1. Bugs:make -j 110 -C test Compile failed
>> * PF(ixgbe): the same as PF(i40e).
>> * VF: Pass
>> * Build or compile: Pass
>> * Intel NIC single core/NIC performance: Pass 
>>  
>> #Basic cryptodev and virtio testing
>> * vhost/virtio basic loopback, PVP and performance test: Pass.
>> * cryptodev: 1 bug is found.
>>   1. [dpdk-stable-17.11.10]Crypto:cryptodev_qat_autotest test failed.
>> PS: issue passed on 17.11.9.
>>   
>> Regards,
>> Yu Ping
> 
> Hello Yu,
> 
> Thanks for the report. For the first issue, you mention the patch is
> attached, but there were no attachments in your mail?
> 

I got the attachment, pasting below as it's straightforward. Didn't
check but I wonder is that the right Fixes commit, or another commit
removed path[] being used.

From bfb6609bc7c8d9d19f74eff6798c9a6931fe0d75 Mon Sep 17 00:00:00 2001
From: Jiang Mao <maox.jiang@intel.com>
Date: Fri, 17 Jan 2020 12:53:11 -0500
Subject: [PATCH] test/test: fix test app defining unused variable

Delete the unused variable to solve compiling error.

Signed-off-by: Jiang Mao <maox.jiang@intel.com>

Fixes: af75078f ("first public release")
---
Note: This patch just fixes v17.11.10-rc1, the other version have no
compiling error.
 test/test/process.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/test/test/process.h b/test/test/process.h
index 505d2f9..1c369e8 100644
--- a/test/test/process.h
+++ b/test/test/process.h
@@ -56,7 +56,6 @@
 	int num;
 	char *argv_cpy[numargs + 1];
 	int i, status;
-	char path[32];

 	pid_t pid = fork();
 	if (pid < 0)
-- 
1.8.3.1

> For the crypto/qat issue, could you please tell us what's the exact
> failure?
> 
> CC'ing the QAT developers and maintainers: I have done the following
> backports, could you please double check them:
> 
> https://git.dpdk.org/dpdk-stable/commit/?h=17.11&id=70116ae88ca7276591f9b16650386c828a92b0c8
> https://git.dpdk.org/dpdk-stable/commit/?h=17.11&id=1c015c688197f89664ef7e6360ab0ef0131de5af
> 
>>
>>> -----Original Message-----
>>> From: Luca Boccassi [mailto:
>>> bluca@debian.org
>>> ]
>>> Sent: Monday, January 13, 2020 8:47 PM
>>> To: dpdk stable <
>>> stable@dpdk.org
>>>>
>>> Cc: 
>>> dev@dpdk.org
>>> ; Akhil Goyal <
>>> akhil.goyal@nxp.com
>>>> ; Ali Alnubani
>>> <
>>> alialnu@mellanox.com
>>>> ; Walker, Benjamin <
>>> benjamin.walker@intel.com
>>>> ;
>>> David Christensen <
>>> drc@linux.vnet.ibm.com
>>>> ; Hemant Agrawal
>>> <
>>> hemant.agrawal@nxp.com
>>>> ; Stokes, Ian <
>>> ian.stokes@intel.com
>>>> ; Jerin Jacob
>>> <
>>> jerinj@marvell.com
>>>> ; Mcnamara, John <
>>> john.mcnamara@intel.com
>>>> ; Kevin
>>> Traynor <
>>> ktraynor@redhat.com
>>>> ; Pei Zhang <
>>> pezhang@redhat.com
>>>> ; Yu,
>>> PingX <
>>> pingx.yu@intel.com
>>>> ; Xu, Qian Q <
>>> qian.q.xu@intel.com
>>>> ; Raslan
>>> Darawsheh <
>>> rasland@mellanox.com
>>>> ; Thomas Monjalon
>>> <
>>> thomas@monjalon.net
>>>> ; Peng, Yuan <
>>> yuan.peng@intel.com
>>>> ; Chen, Zhaoyan
>>> <
>>> zhaoyan.chen@intel.com
>>>>
>>> Subject: 17.11.10 (LTS) patches review and test
>>>
>>> Hi all,
>>>
>>> Here is a list of patches targeted for LTS release 17.11.10.
>>> This will be the last 17.11 release.
>>>
>>> The planned date for the final release is the 30th of January.
>>>
>>> Please help with testing and validation of your use cases and
>>> report any
>>> issues/results with reply-all to this mail. For the final release
>>> the fixes and
>>> reported validations will be added to the release notes.
>>>
>>> A release candidate tarball can be found at:
>>>
>>>     
>>> https://dpdk.org/browse/dpdk-stable/tag/?id=v17.11.10-rc1
>>>
>>>
>>> These patches are located at branch 17.11 of dpdk-stable repo:
>>>     
>>> https://dpdk.org/browse/dpdk-stable/
>>>
>>>
>>> Thanks.
>>>
>>> Luca Boccassi
>>>
>>> ---
>>> Aaron Conole (1):
>>>       test/interrupt: account for race with callback
>>>
>>> Abhishek Sachan (1):
>>>       net/af_packet: fix stale sockets
>>>
>>> Adrian Moreno (4):
>>>       vhost: translate incoming log address to GPA
>>>       vhost: prevent zero copy mode if IOMMU is on
>>>       vhost: fix vring memory partially mapped
>>>       vhost: convert buffer addresses to GPA for logging
>>>
>>> Ajit Khaparde (3):
>>>       net/bnxt: fix async link handling and update
>>>       net/bnxt: get default HWRM command timeout from FW
>>>       net/bnxt: fix crash in xstats get
>>>
>>> Akhil Goyal (1):
>>>       crypto/dpaa2_sec: fix length retrieved from hardware
>>>
>>> Andrew Rybchenko (3):
>>>       ethdev: remove redundant device info cleanup before get
>>>       net/virtio: fix descriptor addressed in Tx
>>>       net/virtio: fix Tx checksum offloads
>>>
>>> Andrzej Ostruszka (3):
>>>       doc: fix description of versioning macros
>>>       net/dpaa2: fix possible use of uninitialized vars
>>>       doc: fix tap guide
>>>
>>> Archana Muniganti (1):
>>>       app/crypto-perf: fix input of AEAD decrypt
>>>
>>> Arek Kusztal (1):
>>>       crypto/qat: fix null auth issues when using vfio_pci
>>>
>>> Bruce Richardson (1):
>>>       examples/vm_power: fix type of cmdline token in cli
>>>
>>> Christian Ehrhardt (2):
>>>       kni: fix build with kernel 5.3
>>>       net/mlx4: fix build on ppc64
>>>
>>> Ciara Power (3):
>>>       app/testpmd: fix help for loop topology option
>>>       ethdev: fix include of ethernet header file
>>>       app/proc_info: fix string copying to use strlcpy
>>>
>>> David Hunt (1):
>>>       examples/vm_power: fix build without i40e
>>>
>>> David Marchand (7):
>>>       net/bonding: fix LACP fast queue Rx handler
>>>       net/bonding: fix unicast packets filtering
>>>       ethdev: fix endian annotation for SPI item
>>>       net/qede: limit Rx ring index read for debug
>>>       net/bonding: use non deprecated PCI API
>>>       doc/guides: clean repeated words
>>>       eal: remove dead code on NUMA node detection
>>>
>>> Dilshod Urazov (2):
>>>       net/virtio: reject deferred Rx start
>>>       net/virtio: reject deferred Tx start
>>>
>>> Eelco Chaudron (1):
>>>       net/i40e: downgrade error log
>>>
>>> Fan Zhang (1):
>>>       doc: fix AESNI-GCM limitations in crypto guide
>>>
>>> Ferruh Yigit (3):
>>>       net/igb: fix global variable multiple definitions
>>>       test: fix global variable multiple definitions
>>>       mk: remove library search path from binary
>>>
>>> Fiona Trahe (1):
>>>       crypto/qat: fix digest length in XCBC capability
>>>
>>> Flavia Musatescu (1):
>>>       net/af_packet: improve Tx statistics accuracy
>>>
>>> Flavio Leitner (1):
>>>       vhost: fix IPv4 checksum
>>>
>>> Gage Eads (1):
>>>       event/sw: fix xstats reset value
>>>
>>> Gavin Hu (5):
>>>       ring: enforce reading tail before slots
>>>       net/i40e: remove memory barrier from NEON Rx
>>>       net/i40e: remove compiler barrier from NEON Rx
>>>       net/bnxt: remove duplicate barrier
>>>       net/bnxt: enforce IO barrier for doorbell command
>>>
>>> Harry van Haaren (1):
>>>       test/service: fix wait for service core
>>>
>>> Hemant Agrawal (1):
>>>       event/dpaa2: fix default queue configuration
>>>
>>> Honnappa Nagarahalli (1):
>>>       test/lpm: fix measured cycles for delete
>>>
>>> Hui Zhao (2):
>>>       net/bonding: fix slave id types
>>>       net/bonding: fix OOB access in other aggregator modes
>>>
>>> Igor Romanov (1):
>>>       net/bonding: fix link speed update in broadcast mode
>>>
>>> Ivan Malov (1):
>>>       net/sfc: fix adapter lock usage on rule creation
>>>
>>> Joyce Kong (2):
>>>       net/i40e: fix address of first segment
>>>       net/ixgbe: fix address of first segment
>>>
>>> Julien Meunier (2):
>>>       cryptodev: fix initialization on multi-process
>>>       cryptodev: fix checks related to device id
>>>
>>> Junyu Jiang (2):
>>>       net/ixgbe: fix queue interrupt for X552/557
>>>       net/bonding: fix port ID check
>>>
>>> Kalesh AP (10):
>>>       net/bnxt: fix setting default MAC address
>>>       net/bnxt: fix multicast filter programming
>>>       net/bnxt: return error if setting link up fails
>>>       net/bnxt: remove redundant header file inclusion
>>>       net/bnxt: fix coding style
>>>       net/bnxt: remove unnecessary variable assignment
>>>       net/bnxt: fix dereference before null check
>>>       net/bnxt: cleanup comments
>>>       net/bnxt: move macro definitions to header file
>>>       net/bnxt: fix memory leak
>>>
>>> Kevin Traynor (3):
>>>       net/bnxt: remove commented out code
>>>       lib: fix log typos
>>>       lib: fix doxygen typos
>>>
>>> Krzysztof Kanas (3):
>>>       test/bonding: fix LSC related cases
>>>       test: optimise fd closing in forks
>>>       net/bonding: fix selection logic
>>>
>>> Lance Richardson (1):
>>>       net/bnxt: fix mbuf free when clearing Tx queue
>>>
>>> Lu Qiuwen (1):
>>>       net/fm10k: fix stats crash in multi-process
>>>
>>> Lukasz Bartosik (1):
>>>       examples/ipsec-secgw: fix default configuration
>>>
>>> Lunyuan Cui (2):
>>>       net/ixgbe: fix link status
>>>       net/e1000: fix link status
>>>
>>> Marcin Hajkowski (1):
>>>       power: fix socket indicator value
>>>
>>> Marcin Smoczynski (2):
>>>       net/tap: fix blocked Rx packets
>>>       examples/ipsec-secgw: fix GCM IV length
>>>
>>> Marvin Liu (3):
>>>       net/virtio: fix mbuf data and packet length mismatch
>>>       vhost: fix virtqueue not accessible
>>>       net/virtio-user: fix setting filters
>>>
>>> Mattias Rönnblom (1):
>>>       power: handle frequency increase with turbo disabled
>>>
>>> Maxime Coquelin (1):
>>>       vhost: un-inline dirty pages logging functions
>>>
>>> Michal Krawczyk (1):
>>>       vfio: fix truncated BAR offset for 32-bit
>>>
>>> Nipun Gupta (2):
>>>       net/dpaa2: set port in mbuf
>>>       net/dpaa2: add retry and timeout in packet enqueue API
>>>
>>> Noa Ezra (1):
>>>       net/vhost: fix redundant queue state event
>>>
>>> Patrick Fu (1):
>>>       net/virtio: init MTU in case no control channel
>>>
>>> Pavan Nikhilesh (2):
>>>       app/testpmd: use better randomness for Tx split
>>>       event/octeontx: fix partial Rx packet handling
>>>
>>> Peng Huang (1):
>>>       app/testpmd: fix Tx checksum when TSO enabled
>>>
>>> Phil Yang (1):
>>>       net/mlx5: fix Rx CQ doorbell synchronization on aarch64
>>>
>>> Radu Bulie (1):
>>>       mempool/dpaa2: report error on endless loop in mbuf release
>>>
>>> Radu Nicolau (1):
>>>       security: fix doxygen fields
>>>
>>> Rahul Gupta (1):
>>>       net/bnxt: fix Rx queue count
>>>
>>> Rahul Lakkireddy (1):
>>>       net/cxgbe: fix prefetch for non-coalesced Tx packets
>>>
>>> Raslan Darawsheh (1):
>>>       net/mlx: fix debug build with icc
>>>
>>> Robin Jarry (1):
>>>       usertools: fix pmdinfo with python 3 and pyelftools>=0.24
>>>
>>> Ruifeng Wang (3):
>>>       net/ixgbe: remove memory barrier from NEON Rx
>>>       lib/distributor: fix deadlock on aarch64
>>>       net/ixgbe: support packet type with NEON
>>>
>>> Seth Howell (1):
>>>       bus/pci: remove useless link dependency on ethdev
>>>
>>> Shahed Shaikh (2):
>>>       net/qede: fix setting MTU
>>>       net/qede: fix setting VLAN strip mode
>>>
>>> Shougang Wang (1):
>>>       app/testpmd: fix crash on port reset
>>>
>>> Shweta Choudaha (1):
>>>       net/igb: fix PHY status if PHY reset is not blocked
>>>
>>> Somnath Kotur (1):
>>>       net/bnxt: expose some missing counters in port stats
>>>
>>> Stephen Hemminger (6):
>>>       bus/pci: fix Intel IOMMU sysfs access check
>>>       net/bnxt: fix crash in secondary process
>>>       service: use log for error messages
>>>       test/mbuf: fix forged mbuf in clone test
>>>       app/testpmd: block xstats for hidden ports
>>>       examples/multi_process: fix client crash with sparse ports
>>>
>>> Thibaut Collet (1):
>>>       net/virtio: get all pending Rx packets in vectorized paths
>>>
>>> Thierry Herbelot (3):
>>>       drivers/crypto: remove some invalid comments
>>>       doc: fix a common typo in NIC guides
>>>       crypto/openssl: use local copy for session contexts
>>>
>>> Thomas Monjalon (3):
>>>       doc: robustify PDF build
>>>       net/mlx: fix build with make and recent gcc
>>>       ethdev: limit maximum number of queues
>>>
>>> Tiwei Bie (5):
>>>       doc: fix format in virtio guide
>>>       vhost: fix slave request fd leak
>>>       vhost: forbid reallocation when running
>>>       vhost: fix vring address handling during live migration
>>>       vhost: protect vring access done by application
>>>
>>> Vakul Garg (1):
>>>       examples/ipsec-secgw: fix SHA256-HMAC digest length
>>>
>>> Venkat Duvvuru (1):
>>>       net/bnxt: fix log message level
>>>
>>> Wangyu (Eric) (1):
>>>       bus/pci: align next mapping address on page boundary
>>>
>>> Wei Zhao (2):
>>>       net/ixgbe: enable new PF host mbox version
>>>       net/ixgbe: fix VF RSS offloads configuration
>>>
>>> Xiao Wang (2):
>>>       doc: fix typo in l2fwd-crypto guide
>>>       net/fm10k: fix mbuf free in vector Rx
>>>
>>> Xiao Zhang (3):
>>>       net/ixgbe: fix X553 speed capability
>>>       examples/l3fwd-power: fix Rx interrupt disabling
>>>       net/ixgbe: fix link status
>>>
>>> Xiaolong Ye (1):
>>>       ethdev: fix typos for ENOTSUP
>>>
>>> Xueming Li (2):
>>>       malloc: fix realloc copy size
>>>       malloc: fix realloc padded element size
>>>
>>> Yong Wang (1):
>>>       net/ixgbe: remove redundant assignment
>>>
>>> --
>>> Kind regards,
>>> Luca Boccassi