From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2DC0A0C43; Mon, 15 Nov 2021 11:30:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3AB794114D; Mon, 15 Nov 2021 11:30:07 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 636C141144 for ; Mon, 15 Nov 2021 11:30:03 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10168"; a="214139973" X-IronPort-AV: E=Sophos;i="5.87,236,1631602800"; d="scan'208";a="214139973" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2021 02:30:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,236,1631602800"; d="scan'208";a="493966178" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga007.jf.intel.com with ESMTP; 15 Nov 2021 02:30:02 -0800 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 15 Nov 2021 02:30:02 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 15 Nov 2021 02:30:02 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 15 Nov 2021 02:30:02 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F05Q96gMqjElG9S5rgmoujs2EyPvm181tSLKi80wwXQuu3D+w3qtgQMsRS5JTECwWyEdf//96FG3+FhNgjd1aXhxqLRmqhoNJj+BZi2b8UryIDt2qiuH0VRGugtSX4hFb5ZE2WmxNdMhqKGqKso6+AN2NTvGU9SG4zR7VXhHqtdioNqZ9TlQs7ijf8ENyo/bpUkrrRn+CX318VCQC1qqN/YY/ui+e5y96XvahwK9wFGvloUEl66zW/xhkFFYkRHk2KuNtfamKMFOOPqbvN3I64daF29IBydIUm40KzlUFRW0eFySXenHxGFgp++Y678sJ9EEFuH6xRFuMnb3RbKn9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2huqk3ZP4FJ0imafh0dN/UrwdTYWWa1Uf4VbWUeRN5c=; b=SO0XlRmKl3+ma9dWT7EUiLfU6mlVMyS/yomxt8Tf1Fl9a9SyLOHz+DqE702OYBZlrkagsy7bln5xL1ou2WR50hst2eNypl8hlx2VSS9jAaI9n/DDVDOG7YrhGOh3LUMqI3CL6+EEWB489PHcpXpSj1tGauDyaFguBuTddtYzIcwwueUZKEHqMzhP1PghZZA2OXWENL8Lteorq57HwJRul3JBSgQKumYDtATck7bSM46c9c+C45+HXtoDtPIvYdlEOL+cGbDTT0s1uIy0N8x8yBrvRuyQeVwnbMXZF577pS6AQhWqA6rFBOcELHkmDj22f5xtKK9EZmeJZ6Z/RMrwyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2huqk3ZP4FJ0imafh0dN/UrwdTYWWa1Uf4VbWUeRN5c=; b=nQ79c8vzUGvGxrhAlBFLvI3IwFbePdv14gx1xp/ZT3nbWlDrczhs0Hfe2LkoqtWXSAZGU9TWWPjWEomUnF0qFNUbbYaoh3D0vN3Ykuaoa6bGkj0Un3lAFSLhY0vnlo8zALpWNnSwfOiQLD2XmxIBeWBSRmZ47+Mbtd+1zwu5zmA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4982.namprd11.prod.outlook.com (2603:10b6:510:37::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.16; Mon, 15 Nov 2021 10:30:01 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4690.027; Mon, 15 Nov 2021 10:30:01 +0000 Message-ID: Date: Mon, 15 Nov 2021 10:29:55 +0000 Subject: Re: [PATCH v9 3/5] net/enetfec: support queue configuration Content-Language: en-US From: Ferruh Yigit To: Apeksha Gupta , , CC: , , References: <20211109113432.11876-6-apeksha.gupta@nxp.com> <20211110074829.16654-1-apeksha.gupta@nxp.com> <20211110074829.16654-4-apeksha.gupta@nxp.com> <5eea58ba-a5f6-76f2-f6fa-c3ceace62937@intel.com> X-User: ferruhy In-Reply-To: <5eea58ba-a5f6-76f2-f6fa-c3ceace62937@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2P251CA0004.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::14) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2P251CA0004.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.19 via Frontend Transport; Mon, 15 Nov 2021 10:29:59 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 297dd9b6-c007-4b48-b285-08d9a822e106 X-MS-TrafficTypeDiagnostic: PH0PR11MB4982: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kImyQMhqGMHLWH5HsnaiqHdQLJoEJjv4j9MaMMBx9mkyI5nMg+RYHeOuxCpJ7nsEp1KYNzIkKTlW7yO0fDSQmhu1zAsA15CsEBqXV/xetOTh4/Qh4Hd7HcQolQSTUqB8JtVqKM9zkpS2XGk4O+EmR9SNI3ST2pCGEfAm3YfeS8q2aIu6LShzQrsK5hCYsdjrE7TbacaeNOfcGNbs1kr/LPkqtlKsfOUOAnQlpLLMguwBon+MYjN7jD9BNoMbdirT1ZfGxjtLqJCWLK6gGBpY0tTV3pSJ/mX4hvqluWeA/n/aur5lOvebuKoPUVcwlgAK95rRT7l9qY9Ix3vigQ8r3sLpPehPPzV2NhrZWLooegBbHnV5KOHz816IdRQQZkNOhJv3mg4Y2A3FH//yrSjeOzL7gNGmT3GsaOVHdPzHtAmOm6xNJZpJw/G8GxNhym3zTnBwDsKTzV/aVBBrDewH/9FaHoJ8xXfnAPN5EPDO12iPyR7q727mO+anz3KtnOHayhRPVsdCENNE1xV4OP3STF+1hwtPNjTzfa+Gyhj9o9jA2reoWohmI912TNKXngRyWZBPpNevfs7uuks92NVdaC3ZWdBavmvp7pW70g1giZVJANjehx0nCiOGtxIY+WgIKxfOWmy7HZsMY54K8kLpY0tJ377BUecifylZ+et/T81V9uzPfv5Mc6z1b8ul9umStjmPi+QR0uhTN+QKzJz2vA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(84040400005)(2906002)(16576012)(38100700002)(508600001)(8936002)(44832011)(2616005)(31686004)(956004)(66946007)(186003)(316002)(6666004)(53546011)(8676002)(5660300002)(26005)(66476007)(66556008)(83380400001)(82960400001)(6486002)(31696002)(4326008)(86362001)(36756003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0tEaEVvWXp5TUpjMlpmOTVtbVdObmxRdHp5THhrUHlsM1BWWEp3QzhpSVhU?= =?utf-8?B?ZHM3VmxSM1k4OUxtZ2RoZHl5d0RBNGdVNGh4Vmd6UmRQVy9XZmR4U1pXaGgw?= =?utf-8?B?TUJrRHI1eStadTRBejg4ZnhTT1BjTGJTaWgyRzc5N1FRbXp1U0FNVUpzRUNp?= =?utf-8?B?UW01QTc5OXBjNnJuK2Z3MEtBZ2FWalNOU1gyS2F5NXdOL0wwcG9nT1hkWjhm?= =?utf-8?B?TG4relNod25XSWQwbUZPL2ZQUDdUZU1GaGs4ZTV2Y1BqRWlkYmhqTVZPNWEx?= =?utf-8?B?U09WWlFXMjFKdzhxbVcxWm0vZGR3M2owK3BJOTRhSFRsRTNFVHpJS284c3F4?= =?utf-8?B?c3pUM1Blb3UvYXhLRFp2am5uamptMlF0WHo4b3l6S296dGhESCtsRlZDM2tB?= =?utf-8?B?TkpVWU9OZjV0R0VURy9LZjVUdGhQT0s5ZlZWaUhXbE5wRHhlcXR1SnhQUWtB?= =?utf-8?B?aitCTVh4WDJOY2x5RkRkMDg4MDJtWFNMZnVXNU5NUjk3ZVA3QTNyNjdYd2E5?= =?utf-8?B?S3BoVmxkN2VNVi9RRVI5ay9KdU9uV2Rrb2h0MTR2SVc2TWQ0dzQ5d2Z6Q0x1?= =?utf-8?B?ako1TnFCdHdQMU12NHp4dDYyTzZabUpSanpjVkZZaVUyL3g1M0VLbmJ5Sjd5?= =?utf-8?B?Mk5jWmcvNjBMNVp2T0phdVpnVkh4dTVLRlVVYjMrUUc0QkxBaVpyQ09lY1Ja?= =?utf-8?B?YnNqdk83K0JqYTFkbWRyWXZldUl1REF5Vnd2V2dEUzU0SHlKM3U1bFkzYXg2?= =?utf-8?B?QkxhWC8wNjlUNTljMkdNc2NlQ0xwM1FtMG1vU09KdStZSlVjc0RYTG5Gem9V?= =?utf-8?B?Vng5Q1pjWFFNN0tiTUtFcFNWV24zSGVLUU01SWdOMC8wNm1acnFpNlFYY1Rj?= =?utf-8?B?dTcvMG9JQTJPTFdXeVZzVkE2U3hLUldVOW5reFo0dXJlUzgyc2NoNW4reWJn?= =?utf-8?B?cGg4R2hFMys0Umx1OFNVMTE1bGQ0QzJYdEJVNk1yTml1VDlqSkVQQjRXRFB2?= =?utf-8?B?MkRvVzIwYmRvTlY5TVlyV1NnUzlqS3R6MWgyMkdhWi90T3R0SmRHeTF0b0tG?= =?utf-8?B?UVJ3QStwQWcrcEIzVC9ldWZDdXZCY2pMeDNGY0lySjBmZHVwOVBxRkR4dy9N?= =?utf-8?B?T2huN0VRMVhmb1F1dE9UV0lCRXdCNnpZVlUrSlRNWGVVUUtldzY1YkEwdGJu?= =?utf-8?B?eWxWcHhDZG9JUS84eTUzRzMwSmFrTXVBam1jenQrS1JmSWljVm0rTExZMWRG?= =?utf-8?B?NHcvclllaU5MeC9HMGtRckoxUHJTanZmMjd6YUkyM1BWQk9mcHNoOWhhYkN0?= =?utf-8?B?dGZHV1hJdEdja2hxeTA1Q2FxK1d5bXY5RmFyT3Ira0E5V25scENzM1RYT1k1?= =?utf-8?B?M0VtNjVPQitXNWlGVXdZVmNZbGwreWVXejYrMmdzb3hGOHhKSUptNEczRVcy?= =?utf-8?B?UTd6Tno1STBxV1RDSE1oeWxSY0lYMHVBL2R4alloQzFSUW9HeTA1aXVIeE5p?= =?utf-8?B?bWt4akZoOEtmZkM2ZG1MeFBST3gycWhzOFA0TnlQS1lOSy9EQ3A4aC9pMFI4?= =?utf-8?B?Qm5HQWE2WFhiVTlMQXN2b2Z5M2hoeGNPMjNJZTFkV3NBWWRMdFdGK0JOb0ZP?= =?utf-8?B?RTUyYXpzS2t1RjFURFNZSis1MnpOaHlraERiaHZ3eW4rc3NmWjFSY3EvWHNT?= =?utf-8?B?UmRFUUJTNGxjQ05tajlqVUV5eUVaQXFDdEc1MlFjL0dDUE1nQ3FVSUtXUGNH?= =?utf-8?B?Q1RNVmNuaFd6R3E1SkdqTmFNTFluOGVMS1RhWCtuZGxVN0tob2RqVmtZM0Zy?= =?utf-8?B?RDh0NXBXUUJMWmJZTmFaUVJsV3MwYlBvVFZwREU4VFc0WmpqQ2pVNko0dzZj?= =?utf-8?B?emRjMloxTHl1Q0VBQUJRNnErbWtjWTg1SkwwUVRLRVNiMEVMUjY5ZnJ5Ym5L?= =?utf-8?B?VWtJTGdhRFJUcFkxUGJpb3Q0KzJYU0IzUG9RUUV3c21tYlZtdk5yZ2dRTWlN?= =?utf-8?B?dHNMU1ZGNDJyTEZ6dWs4YkcrQ2tKcGtWMFZSSVlRam5rM1BoUVBsSlBFRnNn?= =?utf-8?B?N3A5cWYrenlaSnRoVjRZaHNLZ1haUCsxd09lLzRCMkQ5S3BjamRya01JMm90?= =?utf-8?B?eGtBQVR3Nk9MSVVPbzhFd01laVNPU0lLLzRobk5Eek1HVldaMzlwdW9VMnFh?= =?utf-8?Q?oQKWbF3oe1X46ohGRnqKiBY=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 297dd9b6-c007-4b48-b285-08d9a822e106 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 10:30:00.9662 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GR5GAWf0ApyJoNMOQ8dKYCRrRFjIsW29bkobtDMuAjiOOCwvjRl0LTvePnN7qDXwjBE58Y7Vu8CThkqwRTXlZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4982 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/15/2021 10:23 AM, Ferruh Yigit wrote: > On 11/15/2021 10:06 AM, Ferruh Yigit wrote: >> On 11/10/2021 1:54 PM, Ferruh Yigit wrote: >>> On 11/10/2021 7:48 AM, Apeksha Gupta wrote: >>>> This patch adds Rx/Tx queue configuration setup operations. >>>> On packet reception the respective BD Ring status bit is set >>>> which is then used for packet processing. >>>> >>>> Signed-off-by: Sachin Saxena >>>> Signed-off-by: Apeksha Gupta >>> >>> <...> >>> >>>> + >>>> +    rte_write32(rte_cpu_to_le_32(fep->bd_addr_p_t[queue_idx]), >>> >>> Isn't 'fep->bd_addr_p_t[]' a 64-bit value? >>> >>> <...> >>> >>>> + >>>> +    rte_write32(rte_cpu_to_le_32(fep->bd_addr_p_r[queue_idx]), >>> >>> Isn't 'fep->bd_addr_p_r[]' a 64-bit address, why doing endianness operation >>> only on 32-bit and writing only 32-bit of it to register? >> >> Hi Apeksha, >> >> Above comments seems not addressed in v10 & v11, unfortunately this keep happening >> in this set. >> > > My bad, sorry. The variables seems updated as 'uint32_t' in the v10 & v11. > > So I am not sure about the reason of the below build error, can you help to understand it. > >> Above lines are causing a build error for gcc12, can you please check: >> ../drivers/net/enetfec/enet_ethdev.c:482:9: error: array subscript 1 is above array bounds of ‘uint32_t[1]’ {aka ‘unsigned int[1]’} [-Werror=array-bounds] >>    482 |         rte_write32(rte_cpu_to_le_32(fep->bd_addr_p_r[queue_idx]), >>        |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>    483 |                 (uint8_t *)fep->hw_baseaddr_v + ENETFEC_RD_START(queue_idx)); >>        |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> In file included from ../drivers/net/enetfec/enet_ethdev.c:18: >> ../drivers/net/enetfec/enet_ethdev.h:114:33: note: while referencing ‘bd_addr_p_r’ >>    114 |         uint32_t                bd_addr_p_r[ENETFEC_MAX_Q]; >>        |                                 ^~~~~~~~~~~ >> ../drivers/net/enetfec/enet_ethdev.c:482:9: error: array subscript 2 is above array bounds of ‘uint32_t[1]’ {aka ‘unsigned int[1]’} [-Werror=array-bounds] >>    482 |         rte_write32(rte_cpu_to_le_32(fep->bd_addr_p_r[queue_idx]), >>        |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>    483 |                 (uint8_t *)fep->hw_baseaddr_v + ENETFEC_RD_START(queue_idx)); >>        |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> In file included from ../drivers/net/enetfec/enet_ethdev.c:18: >> ../drivers/net/enetfec/enet_ethdev.h:114:33: note: while referencing ‘bd_addr_p_r’ >>    114 |         uint32_t                bd_addr_p_r[ENETFEC_MAX_Q]; >>        |                                 ^~~~~~~~~~~ >> >> > Warning talks about 'array subscript 1' & 'array subscript 2', not sure why it thinks 'queue_idx' can be '1' or '2'.