From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73897A3160 for ; Wed, 9 Oct 2019 15:43:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 340AE1E88E; Wed, 9 Oct 2019 15:43:50 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id D0B8F1E88D for ; Wed, 9 Oct 2019 15:43:48 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4DE1430013A1; Wed, 9 Oct 2019 13:43:48 +0000 (UTC) Received: from [10.36.118.85] (unknown [10.36.118.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1931310016EB; Wed, 9 Oct 2019 13:43:43 +0000 (UTC) To: David Marchand , dev@dpdk.org Cc: Thomas Monjalon References: <1570549949-17825-1-git-send-email-david.marchand@redhat.com> From: Kevin Traynor Message-ID: Date: Wed, 9 Oct 2019 14:43:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <1570549949-17825-1-git-send-email-david.marchand@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Wed, 09 Oct 2019 13:43:48 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] devtools: check coverity and bugzilla tags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 08/10/2019 16:52, David Marchand wrote: > Let's try to check for discrepancies in covery and bugzilla tags. s/covery/coverity/ - you are trying to fool your patch? :-) > The contributing guide specifies that: > - for coverity issues, the tag is 'Coverity issue:' > - for bugzilla issues, the tag is 'Bugzilla ID:' > Self tested: $ ./devtools/check-git-log.sh Missing 'Coverity issue:' tag: devtools: check coverity and bugzilla tags Missing 'Bugzilla ID:' tag: devtools: check coverity and bugzilla tags with typo fix, Acked-by: Kevin Traynor > Signed-off-by: David Marchand > --- > devtools/check-git-log.sh | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh > index a763ccf..2766957 100755 > --- a/devtools/check-git-log.sh > +++ b/devtools/check-git-log.sh > @@ -161,6 +161,24 @@ bad=$(echo "$tags" | > sed 's,^.,\t&,') > [ -z "$bad" ] || printf "Wrong tag:\n$bad\n" > > +# check missing Coverity issue: tag > +bad=$(for commit in $commits; do > + body=$(git log --format='%b' -1 $commit) > + echo "$body" |grep -qi coverity || continue > + echo "$body" |grep -q '^Coverity issue:' && continue > + git log --format='\t%s' -1 $commit > +done) > +[ -z "$bad" ] || printf "Missing 'Coverity issue:' tag:\n$bad\n" > + > +# check missing Bugzilla ID: tag > +bad=$(for commit in $commits; do > + body=$(git log --format='%b' -1 $commit) > + echo "$body" |grep -qi bugzilla || continue > + echo "$body" |grep -q '^Bugzilla ID:' && continue > + git log --format='\t%s' -1 $commit > +done) > +[ -z "$bad" ] || printf "Missing 'Bugzilla ID:' tag:\n$bad\n" > + > # check missing Fixes: tag > bad=$(for fix in $fixes ; do > git log --format='%b' -1 $fix | grep -q '^Fixes: ' || >