From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36833A00BE; Mon, 16 May 2022 22:29:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 179CE40A7A; Mon, 16 May 2022 22:29:56 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140089.outbound.protection.outlook.com [40.107.14.89]) by mails.dpdk.org (Postfix) with ESMTP id 8C3F34068B for ; Mon, 16 May 2022 22:29:54 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SJ0XEDgTMqjh+3D0rkMe1K7DNimtYBZLk6a36bushZW1MzsyuaAdfE9PIKSJvXojqM6Yxx8//8IxWun//ITT7HE9PH1kofH2e6UwFkwea8GTPORIJ6H/ScC82uIBBYFLLbrwYrE5GFXOm1/eI1fivpXSaif3oYpb4tOoz4LALpBqL48OcDB/X0NL7ZULsaQokiSymaKJalhYKAysO4YB/UsXJSw5vuAreRO9yGq9edzVwvKCzvWiM/2BLjk0BoczB/ygp8/YPr47Ov0Vk9fT82E2gjL5Smh3QkJ/cn1gnaC285T5eHJmCnaH1RgFdXLJCq+rgJbDoWDDnvG0mTUZbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Maa67iNtpvgj2kFTB1iIbjhExlkkoxs/TBCbvbSMHjc=; b=VoEV355SNIBGbbMxrfWJhxCxb7WpC3U+sNO1TkWSuRZ7NLjCDBXZdj3Zxpes4zWyR+8kawskDye4lPaPnueascD6m4+a9p+WLjJ7WOqIZTNUJn2YjUGEpQLZM24GGKQrbPZEoR2FApnC/3KGPTpEKKhJUJKFirsfWjdnbyEk3k+rR5jD0PakT638Jm1T6X7OS94RKEMu02H5XIpCmmH43VW8L6XERAbe3O6uLLOeAJFZK4JUGwNMm0AjbhANo4m7RK7yT6zs4oCTArDmh5BOTGzStLipe8qPdFZ5jpyuVd/zEmipAxPK1mFkdWKOIhdr5JkvVKl3lG4vZygQcIKFGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xsightlabs.com; dmarc=pass action=none header.from=xsightlabs.com; dkim=pass header.d=xsightlabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xsightlabs.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Maa67iNtpvgj2kFTB1iIbjhExlkkoxs/TBCbvbSMHjc=; b=eZRBHD+bc5oxuNdNv0fc8BGM+aPtEI0A5JyYbWLXaaBCOmwR/ji+0+NZ3XT8qisWhOwOFbjaa4jZeM51npw17yzqGbhSfebDqWFPDttSOnDZVQQmstAKQXug4DwsYkSuVdBmr39mtZPJmDFDheobiApx8HdM6LzzjxN7OTMhkz4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=xsightlabs.com; Received: from DB9P193MB1482.EURP193.PROD.OUTLOOK.COM (2603:10a6:10:2a6::7) by DB9P193MB1836.EURP193.PROD.OUTLOOK.COM (2603:10a6:10:241::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Mon, 16 May 2022 20:29:53 +0000 Received: from DB9P193MB1482.EURP193.PROD.OUTLOOK.COM ([fe80::3c11:328c:a5e5:7253]) by DB9P193MB1482.EURP193.PROD.OUTLOOK.COM ([fe80::3c11:328c:a5e5:7253%6]) with mapi id 15.20.5250.018; Mon, 16 May 2022 20:29:53 +0000 Message-ID: Date: Mon, 16 May 2022 16:29:47 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3] eal: allow worker lcore stacks to be allocated from hugepage memory To: Stephen Hemminger Cc: dev@dpdk.org, fengchengwen@huawei.com, mb@smartsharesystems.com, anatoly.burakov@intel.com, dmitry.kozliuk@gmail.com, bruce.richardson@intel.com, Honnappa.Nagarahalli@arm.com, nd@arm.com, haiyue.wang@intel.com References: <20220502141058.12707-1-donw@xsightlabs.com> <20220516195004.10091-1-donw@xsightlabs.com> <20220516132809.08e4c587@hermes.local> From: Don Wallwork In-Reply-To: <20220516132809.08e4c587@hermes.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: VI1PR0502CA0034.eurprd05.prod.outlook.com (2603:10a6:803:1::47) To DB9P193MB1482.EURP193.PROD.OUTLOOK.COM (2603:10a6:10:2a6::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cbe190f6-2d99-4409-8e5f-08da377ad570 X-MS-TrafficTypeDiagnostic: DB9P193MB1836:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Woagb3b1X6NDBnz6D8vC0/i2mU/VkvNJa2ry2sY4aY7zJcZphaENvst2yd3m27UaCl1qxy/3ssoUiG6uqAbwKL74r2QSUp1AidHEusvja1g38LnC6mrC0OpVv+WzedHbOK2TAeyqny3tIgxwgsjHs4IDeyGPFvP/C03MyzvX56kfhAO6gUWQEEhH5jhDdJJwoZVia7xqB8BcE5YyvOUfvxqR9hR7OWLEmaBnq81xe810/thA+G7Iclp1s+yGpaOfGExLUbWH61lzan+Opk/nessBgNA7l/B0FJZ/kXJ3CTFuNhFiHC8M/H5YAv7zk3YZJHMdgwLUvEPSrZIuS1Ibv0A4lKfO1CsbCge4N5ZHYU1FBlXjEwX8EdkA09SmlYZMogjlayLGNtwzdkZQ0a5SAhIkQL8Ubh5KjpTfJ/aMV4EFq1T5fMAORTZefX14lJte89czemxu575Yz8p66+MDhVUKB+xf3GP0B5YnlMQGlqEueQK+aNr9sbTrkZ8OU4/ZmpTBtf9J6eGM65nQGUIJM0HgD8pBWiwZzNFttkLe/T/C1rdYLx/cLe5DOaoCtXAZZL2aZLekWLnr/xeGhTnUKwfiVdU8vcLrZQC+nSOHaq4kFiGhoBR8cdw2ji4x//bZUqwkmn1FPORmaOtWlNDMDv79i2QH+u7n8Yce4hhD/c+joBY0etW+epCHV9QWpr30zHMy5tMPOP7uOEMRfjMq5qdtUhmroEWKPzYio75dRBjx46bMfF101R+Wdlz1p33fjwoyCrcc3RUEfpwyT+v5pg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9P193MB1482.EURP193.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(36756003)(31686004)(6506007)(186003)(53546011)(508600001)(6916009)(316002)(26005)(6512007)(6486002)(52116002)(2906002)(38350700002)(38100700002)(31696002)(6666004)(66946007)(66476007)(8676002)(4326008)(66556008)(2616005)(8936002)(7416002)(5660300002)(4744005)(86362001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UzRoMUZqSTgvZkpzOENpRzRqYzNVN3RWS05TbUYxMG5OTDl1dk5hcWhGaitu?= =?utf-8?B?cVRua3Uwd1RMZVhDbFpIajJCMGpMWkRSM21tMkRyNFNJUXZVZEloM1lxNk5m?= =?utf-8?B?d2kxd0dWUGh4cVh6aTJRanNzejJsc1BsUmFUTnpZRXBGaTYvQjFoVVlicXpt?= =?utf-8?B?cHQ5M3A4ZDYyMVRpSHhSdVZYVEZPTmZjTkVvbyttd2xWZ3F1Rm9weU5HQ0tv?= =?utf-8?B?dy9taVcvR2xJRisvalpjci9KWHpCY21tb1VZbmovMnJqekMxaXVjdXgwcXhN?= =?utf-8?B?NVBkRitEZENleHJ0eFppczZaQVdrYkRnWWloVmZTcm9hWlpSWmdseTMwaDU3?= =?utf-8?B?UWRZVS8ydm9Ka1VxeHJxVkw2bCs3N0Y2UXEwZjkvL1lZSWRvU2ovUm1HdXJY?= =?utf-8?B?MmpqcXp2TkJqY1A3Y2kwSE5UWkFoRFZlUzdPTlI5UXFGUkVVcHFIZWVZMWdi?= =?utf-8?B?QkMzUG5MNnFwRUlZNkRUb0Z4bmdyWlZaZXJaa1JKYzJCL2F5V1JoYkIwd3Z0?= =?utf-8?B?dSszRmNKSklSL0g1djdGUUR3RjBHaDIwYmFqRFp3eTZpU3YzZVBsbGdHQk92?= =?utf-8?B?MURkRWU2RTJJa1VwY2NWSGl5RzhZRVYwUGpEOXBBK0xRSCtRNUJwTEFVZFpl?= =?utf-8?B?SUd6SzNINXZjNXp6aU1DRWJaMUYxZU5qT3BYVkhWR3V3YVRhOGZ3WmlNUFRR?= =?utf-8?B?NVdMU0FlUEdSalFySE5scy9uNi9mcEtId2Q4Nkk2aEk2QjRKbllCV0lWcXRv?= =?utf-8?B?Q0h5dzk1Qi9pVlFVbEljcVdHY0laSHNKeG0waDViSUJwVVF0MkVQYXo4NUpw?= =?utf-8?B?Q3dmN1NEcmlUcERNS2ZHWHJERDhkNzZFUWx1MmFVSkhKZ3JOWUdQd3phc0pZ?= =?utf-8?B?WnJyQ3Y2WkgvSC9ER2dYM28zWWc3MC9xbjNkeXc2ZVFIMnJzUVF3VDZiYnIx?= =?utf-8?B?NU92L1I0WG9zeGFrNFhucVZmOXdXOVFMQ3RFYTV5WitqOFJWRTFkZDVqdEI4?= =?utf-8?B?RTJsMTA3TExCdGRWQU0vNG9iejlsbVd6aUFiZ21FTisxUmR6OUFBblduZU90?= =?utf-8?B?azN0ZDNpaUhQVUdWU3pkTkhrVWtSKzVUMENoVU1Ld2k5bVYyRk1LaStlNEwr?= =?utf-8?B?bVRaSnBud1hSaURmOXhyd05oZGZ6aHZnVVZrZnVlSjdXcjVFSmxrbnZMeTdj?= =?utf-8?B?QVBxN0k5Y1JpV3p6aHB2S2hjb2NSaU5aZHF4NE4xQlNUTmhIa1RPQnFTZ3RK?= =?utf-8?B?WFUwWHhpZjhMR1ZBSUl0ZjJuWlRPbU42YTd4bmpsTnFWYkNVdTlHZFdyT0Qy?= =?utf-8?B?SXdldzluMGdvK1ZBZittY08xalRKMEs4VHRhZHUxZkZGOFY3U3lsNmN6OW52?= =?utf-8?B?Z3NKK0JYUCtRWEt3anVyemZLaUxqcWlDYzRkb1ZOc3BqK0g5NnRHY3BaS2FM?= =?utf-8?B?MHZvK01UNjlSdnp3bHNicnRTTHFnaDJpL1dUQld5d1E0aCtYSGMyaFd5WVc5?= =?utf-8?B?YlJhc0dqekM4Zk0vSFU5cmZoYXhteUt0dGdhTUdOWVJaWjd1cm94MzVMdmNO?= =?utf-8?B?Q1NXeEFzeThjck0vRytlRlpCWmFIcVZRbkc1WUNBM1J3czZEVmpTYnJKY09E?= =?utf-8?B?L3VRN1NLNDF3ajE3NTF4SmYrcFl1djFyRVdkT2c2YXBlREZiNk1VdkIyQTF0?= =?utf-8?B?RGtzOWhHeElJMVIzNjRWeW9hSlMvT3ljMWVOb2Q0T3BFK2pDQjhFVE5MZUVN?= =?utf-8?B?NTVOZm1DR0FrV280a01xUG9UeWJyV3BkQzZvay9pV293ci93dldTSERGdVFV?= =?utf-8?B?eGl6MVczNlA4dGtVU2VDcUd5ai8yL3Fyb3pURDNvQzhTMFNQOHNFQUhVeWwy?= =?utf-8?B?T3FwQXBFNXFUaUZuYk1GQWNxVnlkZVdOM0EzaE8xSzZVN3R1R0JDQVRQOUJv?= =?utf-8?B?UmlzZXovNjJPRU5rZHhNV00zSEhMV0FZOUpNRUhGQk51UlhXcDNnUzRUTVZW?= =?utf-8?B?d2xEWHJNcE5LbUZIc2FuVmo1R3ZaUllUSGhjTXBaN0hBM2xscmNYTVQ4b0ZG?= =?utf-8?B?RzJkb0l6WVFZRzFrVUVaR3Z5eDJnN3poeVBTcHAvWUE2Y3BpNytIQWR6c2xw?= =?utf-8?B?Qm13UUM1M0VzVk9HTTFoWU41RFhKZkFvQUFxN2UwZ2dNQ3R5b3ROcXJ4eEZL?= =?utf-8?B?T0RoNUM5c2I1bWw2enFKM2s3TjM3VHFDdW1KRnRlVWJNSXI5QXV4Y1pzaldi?= =?utf-8?B?Q0drNDc5WS9OWm11MlV5bzc3WFUvLzJsRUY2OU4xQkJ1cDQxVlZLSFFhYUxk?= =?utf-8?B?TjZFOHpTditwOVUwQkQzaGtJOXE5Q3ZuYzFUWS9nRUUvODZWblRjUT09?= X-OriginatorOrg: xsightlabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: cbe190f6-2d99-4409-8e5f-08da377ad570 X-MS-Exchange-CrossTenant-AuthSource: DB9P193MB1482.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2022 20:29:53.4213 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 646a3e34-83ea-4273-9177-ab01923abaa9 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UWBr+csFeNX45R6b7zgT+Pm84th+RIsCxESuT4/i36Oq24ok7q9uFv3ZF5ypZgdd8JMMVu1hcsCciP88Zfc6Vw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9P193MB1836 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/16/2022 4:28 PM, Stephen Hemminger wrote: > On Mon, 16 May 2022 15:50:04 -0400 > Don Wallwork wrote: > > >> +static int >> +eal_parse_huge_worker_stack(const char *arg, size_t *huge_worker_stack_size) >> +{ >> + size_t worker_stack_size; >> + char *end; >> + if (arg == NULL || arg[0] == '\0') { >> + *huge_worker_stack_size = WORKER_STACK_SIZE_FROM_OS; >> + return 0; >> + } > Looks good. Minor nit if you do another version. > Please put blank line after declarations. Thanks.  Hopefully another version won't be required, but if so I'll make that change.