From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF5C4A32A2 for ; Fri, 25 Oct 2019 10:13:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9DB3D1E8AA; Fri, 25 Oct 2019 10:13:46 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id B0E471D50B; Fri, 25 Oct 2019 10:13:44 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2019 01:13:43 -0700 X-IronPort-AV: E=Sophos;i="5.68,228,1569308400"; d="scan'208";a="202546880" Received: from dhunt5-mobl4.ger.corp.intel.com (HELO [10.237.221.107]) ([10.237.221.107]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/AES256-SHA; 25 Oct 2019 01:13:41 -0700 To: Ruifeng Wang Cc: dev@dpdk.org, hkalra@marvell.com, gavin.hu@arm.com, honnappa.nagarahalli@arm.com, nd@arm.com, stable@dpdk.org References: <20191008095524.1585-1-ruifeng.wang@arm.com> <20191015092826.13002-1-ruifeng.wang@arm.com> <20191015092826.13002-3-ruifeng.wang@arm.com> From: "Hunt, David" Message-ID: Date: Fri, 25 Oct 2019 09:13:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20191015092826.13002-3-ruifeng.wang@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v3 2/2] test/distributor: fix false unit test failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 15/10/2019 10:28, Ruifeng Wang wrote: > Sanity test could spuriously fail with reporting flush count error. > It was caused by worker stat coherent issue between distributor and > worker thread. > Fix this issue by using atomic operations to update worker stat. > > Fixes: c3eabff124e6 ("distributor: add unit tests") > Cc: stable@dpdk.org > > Signed-off-by: Ruifeng Wang > Reviewed-by: Gavin Hu > --- > app/test/test_distributor.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > return 0; Acked-by: David Hunt