From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0068.outbound.protection.outlook.com [104.47.34.68]) by dpdk.org (Postfix) with ESMTP id F259A9E3 for ; Wed, 5 Apr 2017 14:40:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=S1lD/EH5BqMGoleiMtcg7arkShlJA6TdUw7aH2/FF+E=; b=AvG9V/Hw9abJjk44GZ+RpGSKkOdWdiuNx6Ky/Yi65orwD1oefoGNDGTy6T1yJ2zDR7JiV9XY7wGt6k12hUFm5xrg1mYWZeaTGWBB5jvio4GU/n7coDmBeuFrsGhwvHOpX1mNhD6OBu9Q1Q5qKeNxu5KvKxFK5KacgcrpicMZsxs= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none; nxp.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from [10.160.0.42] (111.93.218.67) by BY1PR0701MB1724.namprd07.prod.outlook.com (10.162.111.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.10; Wed, 5 Apr 2017 12:40:45 +0000 To: Shreyansh Jain References: <1491382264-23489-1-git-send-email-santosh.shukla@caviumnetworks.com> <1491382264-23489-2-git-send-email-santosh.shukla@caviumnetworks.com> Cc: olivier.matz@6wind.com, dev@dpdk.org, hemant.agrawal@nxp.com From: santosh Message-ID: Date: Wed, 5 Apr 2017 18:10:29 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BM1PR01CA0033.INDPRD01.PROD.OUTLOOK.COM (10.163.198.168) To BY1PR0701MB1724.namprd07.prod.outlook.com (10.162.111.143) X-MS-Office365-Filtering-Correlation-Id: 11630bec-fac6-4198-5d26-08d47c20fbba X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:BY1PR0701MB1724; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 3:R3hJirsYY+aUeGL2L+evbG+wK5N+nv5IwZNI8MQ0EjZE1zXlkxI3uVkXg/BymWqrKyTMTKjtrKqK1C/biEkLeqG7ZddrrKT11HdksK0E27UBM8EeTS9CySqMUplrfUXLkT4o/ehov8Cb7Gkyz1j9Hm+FCXF1w2RKlwaHpDKbIc1LC4Cs1ANumzHQgPi4nI30HGCDzCVr52bvfdaYXHg4x+JX1XSpJskOBZBJZYpe/vjScgVHLYR7MKLRhpu7ST+CmIXoJKrTgC/q3e2Yg+8EyfxdiBUtYthZdE6xltY+njffLbWTVQU1urjehHTzGoIo+3zfkt33rl5n8NJICYrhSg==; 25:f/agBgpbJ6u0sAt5D2TAoIKY+d5X3a+Xhmf6fQcTYsmcv75fF7GUmHYpF6Jq/yMaRR4agZVwazTdA35djA7peXFTirf9uwqdDFBo8RdHMIHpXfKrVCJJ58GmzeSbv1I4k8reFUZ9popDczAkjY45v0upvP6oQaA6mC9k8f5H88628PLT5PkSGsJNwRf6mUqWnxnjYpP5nx8wqnHKptMPANBPmP2XJLlMaEoXdlL1ERaS9YWVzRRuEl1wP9K8wDP9LfFGZEQCxvWyXTPg3OnT7zAn851fMfwrVRRNDWwWldPtPFcdXASLrtmyb+HM2R1umJOEWdMTinuI4zbsCYgd3DLiFggj760KmXBjEdZWZ78tYtGFk5oRbSy0kwaCHybjph7kooG5hqYr35lYUXZgU/uOtPOvYsyMukceX9JkivPGFqwVC6TIv8fLQ58YC6HhpERcPzxGV/+EAeeEsbjqBw== X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 31:HaEENDrYt3ZMi7e4kepag3IEcWjdWn94Yy3TyiWyu8iFrcs0CJ2wlCuuBP+LzHu3DQzUx6g1FuiKeOtkIGWPKvYNgL9Szt1op3BrviZCibtYGVkbHSTouRsMk1Vpab9h9tMO7jXwGxd6haaBsPIgkgrDJN8mVlX4A6xzYFEulwmeD5qfnnKhj5c3YRQhd0JKPWq0MkbB2P/uuCUeFEuvjqz1tP3PYT5inYpfwavSQ3uySXYMIb1MlOTEHnsbWHkAxjsYOHRdqQ0hJnYZf3eyqw==; 20:nLjpVj2SKOyPIkcNwOVc8/7x5IAIK2LPKw1LiGiOOSmwKrLnzhZ9XPDFR6K03TBHXDqSa6lE/WexTmbywh4dBmMsZdYx5FkDH0YJeH7oJPrXr81Mv4sGN/UPiBE4psA9+fbEauhlUswlmMSolYTmoPf2j5/4SdxcVmvPRPxzZnABTW1pQSAjCKdCsGAfhgTx3BMemf+B4OnB62png5FfgIZTYrrZ6lxWYoVl/nzWrS2TRgZZuqBgEtaxnmEk07liOanGjsIlrDCS9T2KAawRIkrxLy2qohC3S4mw8g0XYHAllzx9j61dE1ElBHvq/c0ruTAOc2KQlbJN+eR3Iage3aZUVl4gEhALxys958ZXuITW4gOwRXVoD/GKEImVfJM/ecFyIVizFjttRuGfaCBvcKUz7lCN+7BpMiJuJAXQo3HxTK+f0f8XnjiXj4wLGBozJz2PSoTvaxuNVpvZOaxTAKRoZiUgaLQ60JPu5NtwcEaDum6I/aDZNV0d2pdWHe27l9fosaUpLrrmfWaIZqPALAVdlGFde9v3VZJCHboS/kSnwj+K3DsslPLQrU3IsPROa0IS+aSxu9YoW8KouNmsyEABHydH6CzcGJrUOupoOpA= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(93006095)(10201501046)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123562025)(20161123564025)(20161123555025)(20161123560025)(6072148); SRVR:BY1PR0701MB1724; BCL:0; PCL:0; RULEID:; SRVR:BY1PR0701MB1724; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 4:efTiDPb0PgAEEc+BhSoBPb9Fp6uBxTHjhD1Gb0jsxNM3Geq/h/pOBmr9EDQQaP7dXz4t0XBSBSwsALUlC2et/Gg9OKsv+m+rwGaRErgajxPsJ7UdK/wSnXAkswunknFYeDnPTL0gp7icjTOl+YBPxq2F9x/q2ziGr+IqeF8s8C6gbfFn92FaMx9x/Gun0/qlunnlwVvRvq9XxOkhe8eGTh3imkzPj5nx2K7pRhckauz/1HPc/fhyzYc8YaVhSpiDyuhIS81fIpex0woTW5DqazxpFSo6rGX1qnUa8hImZAeUwM9h9Ki6/9I9s4EYt/5ZQR4XPoFuyUhc4/O8bm/3+yC4bEVhcCSlckmGtYG9kvHrvNmHK/8KEoOE97z+itb7zesvwww/9aRSGWuZwitzUe7vXY9AFWYGbwlqaff78KXeN/bHVs2/fcsIREg4VOUxX0pr9kqxZCxtqUeOVjP3yxaW6pu+f0+eCZk4aleU4bWGst8IOaZjB8/Vf2RB05soM33YMOIsei4sfXW6ppsSmsQDHKuQSYdNqk+T6nkQi3LgBEwJ3SXR7XhBFPOZKjp7pTn1OpS/+z2e/3QOOdmsjG+m2dRn329nb53tbBPWRvDWlw6A3JF1YCk8YUacxOorVQWmo2eE1PFDZww35/QKZPvDQSMoYUk+Ga09Wm3s1w2ACnlAarUOdD6MmCEBzdOK1hlYGPwjHIrhwMiwMTHvEhmoeLq1enDzN7sG44Q8//gmvdsAx7RgvK/D8IiIzInM X-Forefront-PRVS: 0268246AE7 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6049001)(39400400002)(39850400002)(39410400002)(39450400003)(39840400002)(24454002)(377454003)(50466002)(229853002)(64126003)(189998001)(42882006)(6916009)(6246003)(230700001)(53936002)(31696002)(54356999)(76176999)(50986999)(33646002)(2950100002)(90366009)(36756003)(86152003)(8656002)(3846002)(6486002)(42186005)(25786009)(305945005)(7736002)(5009440100003)(4326008)(6116002)(77096006)(110136004)(47776003)(65956001)(4001350100001)(65806001)(66066001)(38730400002)(65826007)(81166006)(8676002)(6666003)(23746002); DIR:OUT; SFP:1101; SCL:1; SRVR:BY1PR0701MB1724; H:[10.160.0.42]; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BY1PR0701MB1724; 23:w/K4s7C+7oow3ZnykfccbE4oqPNtdQlO5+m?= =?Windows-1252?Q?RkDOHlzl0LhqrHSKPjRW1uOIrR+3PgErA8OgSWtGHzpgEXttHQQ84Xq7?= =?Windows-1252?Q?xe4zfmV3FF2yIUrpacao9R3Lcvs2XifDBIqhd8mjXR2AgiaB9jn/oQy5?= =?Windows-1252?Q?+0DGHwNuXCHZNBdbLR3dx7ZoMQR6aHqZUgycTid6ouGDCgc0QdNskIaK?= =?Windows-1252?Q?HQ7VPrE8tNf4yqxEMfxqend0QHTwOs3wMtzz5i5qh+dTZIPNSoddlVTo?= =?Windows-1252?Q?gFGSpYMQB+61W3qXSfGZOCofE8mYaPLLGis6DrR+DM+1KJk7Is+645Cp?= =?Windows-1252?Q?FP4kEUYrKn+EzLQgeHcFGkjLv0iTzXroiAX9G7LbvTiFzzr3pLjWn2CG?= =?Windows-1252?Q?UNAe/+b4MVEccu7YXsG/J0YE17wC9YSfq1OTr72IC82oqALT+92Sz7Gx?= =?Windows-1252?Q?llUP1PrUQrmPKrs8+azgmpV3awxfQQM7UMPUg+RsPYPZRKSnLrZOxL2c?= =?Windows-1252?Q?eyzbFxVZsQ47Nw6IuQZpbPJsR+cPW3ahuIJPZzTfGRlARHVNTPSiK8yO?= =?Windows-1252?Q?XoRxJq64VC3x2mr9hSYJRmMPv2mH8b9BWsyep357fTPdseSAvDHwIDnN?= =?Windows-1252?Q?sOqscIm/U0pAN6tFqP745HY+mgyiy3L/Jiztsa1daa9nRypO9p75zaw6?= =?Windows-1252?Q?itzwWP1enHXgqCcztEcU/fPBfN2eIcWxwcHhFpr5UWHhnCeNbvbT+uUz?= =?Windows-1252?Q?wSqZkD8NYh93V+9qw+d895VIU1rreKVfzqn2yiNps6f799Aorg/WaXm4?= =?Windows-1252?Q?m8AbdTY48YCdHutCIWqTAz1m8kexqKAfNoINxhBQA2WeHu4iT7KXSXr5?= =?Windows-1252?Q?Q2GNsXgP3C0b2OIcTx0eD+FluJyjMCylkZKgl5yDar/J+6idrGS6Uf5M?= =?Windows-1252?Q?w/bu0yZUIdm3F/Zw1R0T7EYOdVtufyQRueRj+WoOWUxtaoAS6o73fAF9?= =?Windows-1252?Q?D+2rTk3Tv9im2h8szxeHHcph1nQGBy0Gm4idFMZGOmhFkHpluYwAQHCo?= =?Windows-1252?Q?zJMxzI3TEZNSiUQ9jwfNsL9sOQJyrvP4gVj2vYkmUjRYekATjwxTv5OW?= =?Windows-1252?Q?Tl5M2N+Hrateyc7/aVWttTjeANScdT8MA8f7FkTHrWZ+1PGEcIr6VU2E?= =?Windows-1252?Q?My8YW3rnigHjUgzcW3Xp7Iwj8kslYWSHHq4VNffbXvUyBmuTsToG2IYB?= =?Windows-1252?Q?2A8z8o19Pwbo+U/6BKe1PYySti6gvzePJ3Fyi8LBYJa6WJaJG/opJNjq?= =?Windows-1252?Q?F7qmVFMm2dC9N/sl8JoXB+VbFZmgBZHXb8yjqQvckJ8Om8sb6uUTcx10?= =?Windows-1252?Q?WDcTjwzcOKLVN?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 6:uiJTRpPzpjOQlZ4BwAn5mdnBDGsg6bJVouGOiZoLP6c8JegWMbdAAgi01z6+z/ZTqYkhQlm2p6XGP7q4w3F7QwJd2XAJMDTbX89loIx5+V8BS9eq/l/jkZNKSl6h+z2CjbsMJqbi4zRS2PmZJOGoaUuicSE/j7RJOxudtqbFp/dOz+Wkk0UPwhRIeXIEtSwsJDxZ/8MjyILs+AgweKLWlopbeVDA4sI45pm4eeQQqPnVbmWp2dEUF9G/AEMKH6PFyDFMGWRTzWWBT9cJ/4m4IJ7Dgijhio5pj80UpcPn/Bey2aN76dhzWhrify/zIeKQFBHJgz+v9kWZ0DnmahxDf+Op/WFz/o+40cIcy3Mlv5k8up13Y8obkxgnJhK2YnucMSOct1pI0h34nrlgpH3jJw==; 5:C0CQOM57VRqb49E78lB9ka83TUwctOg3P3zCWZOJ9svo4jLK6i0p5igJRzMV8NHlMOA49+86M16zb4Tb5l3YKO0TDtER4Z1x/6dNxqxc6Opki0Lpl1INZ+iF/Ee/dFB8k9Js/kLtXzLDEm3SghcCrA==; 24:N9LecxKP5qyEHIqTtPc0ZDhnNc2fZ81DFAFO7dMuFimZbuLZhxB752gL6Jc3NGBQW/EFVzIhYftHdPcQmw3nzHfXn2kBoNG6ZOYWfffQfT4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 7:t5O854pVa517JYZtgivFiGE3k+v0Q4eu6lRovG4EUXyxcK4vHoeDMoovVBijeEtLWC8KREksldYh7Rn9jdG1skWEyso3es+KUaueIW4P5LE573prM/uP4VEzyMbLDRpQHZYB3PzH6U9wbaxPveRw49ltdAz5kFhaafMTL4rK9sDQVwUKsrRIEBA+2WyfwVN+IE1afimP8CJSNWbzPOulxuZDVHcTubBxywyO2omb0IuPXWB6iNB0sxiY/mEt4mVZGkY/mdKDKjhsh9/ruwG6OWhRLtOjC4G7LVE6Eo3+rlIKUe34u3vQb3YICV53p4gkI1kE8BXVLw8PRfyYRtvPmQ== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2017 12:40:45.1019 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1724 Subject: Re: [dpdk-dev] [PATCH 2/2] test/mempool_perf: support default mempool autotest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2017 12:40:49 -0000 Hi Shreyansh, On Wednesday 05 April 2017 03:32 PM, Shreyansh Jain wrote: > Hi Santosh, > On Wednesday 05 April 2017 02:21 PM, Santosh Shukla wrote: >> Mempool_perf autotest currently does perf regression for: >> * nochache >> * cache >> Introducing default_pool, mainly targeted for ext-mempool regression >> test. Ext-mempool don't need 'cache' modes so only adding test-case >> support for 'nocache' mode. >> So to run ext-mempool perf regression, user has to set >> RTE_MBUF_DEFAULT_MEMPOOL_OPS="<>" >> There is chance of duplication ie.. if user sets >> RTE_MBUF_DEFAULT_MEMPOOL_OPS="ring_mp_mc" then regression >> will happen twice for 'ring_mp_mc' >> Signed-off-by: Santosh Shukla >> --- >> test/test/test_mempool_perf.c | 41 +++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 41 insertions(+) >> diff --git a/test/test/test_mempool_perf.c b/test/test/test_mempool_perf.c >> index 3c45971..9c80860 100644 >> --- a/test/test/test_mempool_perf.c >> +++ b/test/test/test_mempool_perf.c >> @@ -111,6 +111,7 @@ >> static struct rte_mempool *mp; >> static struct rte_mempool *mp_cache, *mp_nocache; >> +static struct rte_mempool *default_pool; >> static int use_external_cache; >> static unsigned external_cache_size = RTE_MEMPOOL_CACHE_MAX_SIZE; >> @@ -337,6 +338,31 @@ struct mempool_test_stats { > Similar observations as [PATCH 1/2], the context above is not correct. > it should be test_mempool_perf(void) Will post v2. >> if (mp_cache == NULL) >> goto err; >> + /* Create a mempool based on Default handler */ >> + default_pool = rte_mempool_create_empty("default_pool", >> + MEMPOOL_SIZE, >> + MEMPOOL_ELT_SIZE, >> + 0, 0, >> + SOCKET_ID_ANY, 0); >> + >> + if (default_pool == NULL) { >> + printf("cannot allocate %s mempool\n", >> + RTE_MBUF_DEFAULT_MEMPOOL_OPS); >> + goto err; >> + } >> + if (rte_mempool_set_ops_byname(default_pool, >> + RTE_MBUF_DEFAULT_MEMPOOL_OPS, NULL) < 0) { >> + printf("cannot set %s handler\n", >> + RTE_MBUF_DEFAULT_MEMPOOL_OPS); >> + goto err; >> + } >> + if (rte_mempool_populate_default(default_pool) < 0) { >> + printf("cannot populate %s mempool\n", >> + RTE_MBUF_DEFAULT_MEMPOOL_OPS); >> + goto err; >> + } >> + rte_mempool_obj_iter(default_pool, my_obj_init, NULL); >> + >> /* performance test with 1, 2 and max cores */ >> printf("start performance test (without cache)\n"); >> mp = mp_nocache; >> @@ -351,6 +377,20 @@ struct mempool_test_stats { >> goto err; >> /* performance test with 1, 2 and max cores */ >> + printf("start performance test for %s (without cache)\n", >> + RTE_MBUF_DEFAULT_MEMPOOL_OPS); >> + mp = default_pool; >> + >> + if (do_one_mempool_test(1) < 0) >> + goto err; >> + >> + if (do_one_mempool_test(2) < 0) >> + goto err; >> + >> + if (do_one_mempool_test(rte_lcore_count()) < 0) >> + goto err; >> + >> + /* performance test with 1, 2 and max cores */ >> printf("start performance test (with cache)\n"); >> mp = mp_cache; >> @@ -384,6 +424,7 @@ struct mempool_test_stats { >> err: >> rte_mempool_free(mp_cache); >> rte_mempool_free(mp_nocache); >> + rte_mempool_free(default_pool); >> return ret; >> } > Other than the above trivial comment: > Acked-by: Shreyansh Jain Thanks!, >