From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B9C5CA00E6 for ; Tue, 11 Jun 2019 11:31:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B97001C358; Tue, 11 Jun 2019 11:31:12 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id C6D771C353 for ; Tue, 11 Jun 2019 11:31:10 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20190611093109euoutp02b2366c5728823d5e6b195032dae7affe~nGvz2-6l00869308693euoutp02j for ; Tue, 11 Jun 2019 09:31:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20190611093109euoutp02b2366c5728823d5e6b195032dae7affe~nGvz2-6l00869308693euoutp02j DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1560245469; bh=0SrMXbi4TExQ0AVuo3ykjOtsErl5mc/GF+HAE0tPNoI=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=OThKioEJtf042/PmgPEf958rbMzJfCaDNlsBOoOV/AJCYXA64/UGQFQxnmaKTPL5m m7BBlY/eRl4g8fkvdHDj45tMdTDrn8rmXWFzgAkA/xnF+fD6s1nzxZpQb/SIAZ2O+u D5FWBntZLDP3eGR67pGr1ToDdJwYE65KhawumAjU= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20190611093109eucas1p2163d9536d4601c16edde4684cb6ddca9~nGvzYSvHn2055720557eucas1p2V; Tue, 11 Jun 2019 09:31:09 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id F9.21.04325.CD47FFC5; Tue, 11 Jun 2019 10:31:08 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20190611093108eucas1p28d2002157f1b32fb6c9c56f8eff32e2b~nGvyh9kq32666826668eucas1p27; Tue, 11 Jun 2019 09:31:08 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20190611093107eusmtrp19c9b2fa4b047d880dfd2920dbd73bd40~nGvyScIA80288402884eusmtrp1Q; Tue, 11 Jun 2019 09:31:07 +0000 (GMT) X-AuditID: cbfec7f5-fbbf09c0000010e5-5f-5cff74dc76ce Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 71.C2.04146.BD47FFC5; Tue, 11 Jun 2019 10:31:07 +0100 (BST) Received: from [106.109.129.180] (unknown [106.109.129.180]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20190611093107eusmtip2b41ed969c1da115cdc59b8f23219b6f2~nGvxyNTPH2260422604eusmtip2b; Tue, 11 Jun 2019 09:31:07 +0000 (GMT) To: David Marchand , "Yigit, Ferruh" Cc: dev , Bruce Richardson , Ian Stokes , Aaron Conole , "ovs-dev@openvswitch.org" From: Ilya Maximets Message-ID: Date: Tue, 11 Jun 2019 12:31:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAKsWRmVeSWpSXmKPExsWy7djP87p3Sv7HGHxtMLb49eYBu8WNVfYW 21d0sVm8+7SdyeLO3tPsFlfaf7JbbHx4ltVi7qfnjA4cHr8WLGX1WLznJZPHs5v/GT3e77vK 5tG3ZRVjAGsUl01Kak5mWWqRvl0CV8anKbOZC2bzVWx8/Jq5gXExTxcjJ4eEgInE2aWnGUFs IYEVjBLvJ6l1MXIB2V8YJU5e72aBcD4zSjR1TGCD6eh5+AUqsZxRYuaEacwQzkdGiV3HprCC VAkLGEp8nbcbzBYRiJJY13icFaSIWeAIo8TtuS/ZQRJsAjoSp1YfAVvOK2AnsXDjORYQm0VA VeJMzxqwGlGBCIkvOzdB1QhKnJz5BKyGUyBQovnfdmYQm1lAXKLpy0pWCFteonnrbLCLJAR2 sUucuLmcCeJuF4kJJ/ZC2cISr45vYYewZSROT+5hgbDrJe63vGSEaO5glJh+6B9Ug73Eltfn gBo4gDZoSqzfpQ8RdpSY9PkXI0hYQoBP4sZbQYgb+CQmbZvODBHmlehoE4KoVpH4fXA5M4Qt JXHz3Wf2CYxKs5B8NgvJN7OQfDMLYe8CRpZVjOKppcW56anFxnmp5XrFibnFpXnpesn5uZsY geno9L/jX3cw7vuTdIhRgINRiYc3IvpfjBBrYllxZe4hRgkOZiUR3q7vQCHelMTKqtSi/Pii 0pzU4kOM0hwsSuK81QwPooUE0hNLUrNTUwtSi2CyTBycUg2M0bM93U0zLnJ8LZyqYW2S87Qj ZZL5rZjCzs+2LvOf3LM/m3Hv4MnSvslHhMWkk/6r6Tx/y3547k63Hr8J0Xuv2Hi3+yeYLGyY tegtv+qjvxd3r1lc4sJ/I8X2/OzesAR+mxXnGsyXLmrbcCE+gGHHmj+vMxapPF5v/mPBDa9+ 4e98uZ42fZzXlFiKMxINtZiLihMBzOBZAkMDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCIsWRmVeSWpSXmKPExsVy+t/xe7q3S/7HGCz6b2Xx680Ddosbq+wt tq/oYrN492k7k8WdvafZLa60/2S32PjwLKvF3E/PGR04PH4tWMrqsXjPSyaPZzf/M3q833eV zaNvyyrGANYoPZui/NKSVIWM/OISW6VoQwsjPUNLCz0jE0s9Q2PzWCsjUyV9O5uU1JzMstQi fbsEvYxPU2YzF8zmq9j4+DVzA+Nini5GTg4JAROJnodfWLoYuTiEBJYySvQsX8oCkZCS+PHr AiuELSzx51oXG0TRe0aJt1sfgSWEBQwlvs7bDWaLCERJnP+3gR2kiFngCKNE+5uprBAdSxgl uq6fZAapYhPQkTi1+ggjiM0rYCexcOM5sHUsAqoSZ3rWsIPYogIRErN3NbBA1AhKnJz5BMzm FAiUaP63HWwOs4C6xJ95l6BscYmmLytZIWx5ieats5knMArNQtI+C0nLLCQts5C0LGBkWcUo klpanJueW2yoV5yYW1yal66XnJ+7iREYg9uO/dy8g/HSxuBDjAIcjEo8vBHR/2KEWBPLiitz DzFKcDArifB2fQcK8aYkVlalFuXHF5XmpBYfYjQFem4is5Rocj4wPeSVxBuaGppbWBqaG5sb m1koifN2CByMERJITyxJzU5NLUgtgulj4uCUamDMC2qT+rBPoNp9qdiiNo5V2uuqVkcZrHvE 2zTjCP+qv0Y2V1kFzK7KsX1KeHLZyq+nezffrSR/BfaS01+NZs03Zg5Tn/i81Vu597W9ytz0 yll/lVj2rM5mFGkPlz245qyv/uL1fUKLTsdkLPyn/qVnRWVi2VmNxv2vXq/vEVS+1TBro7Dh F2slluKMREMt5qLiRABU5qZ+1wIAAA== X-CMS-MailID: 20190611093108eucas1p28d2002157f1b32fb6c9c56f8eff32e2b X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20190611084549epcas5p42a1a9b787cf71df23f18ebaf4092beaa X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190611084549epcas5p42a1a9b787cf71df23f18ebaf4092beaa References: Subject: Re: [dpdk-dev] Forcing inlining for igb_uio and kni X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11.06.2019 11:45, David Marchand wrote: > I noticed that OVS CI [1] patches the dpdk sources to force some inlining parameters and get kni and igb_uio to build fine. > > Looking at it in dpdk, meson support dropped this. > In the makefiles, I can't find a reason in the git history (we go back to 1.3.0rX version). > > [dmarchan@dmarchan dpdk]$ git grep max-inline-insns-single > kernel/linux/igb_uio/Makefile:MODULE_CFLAGS += -I$(SRCDIR) --param max-inline-insns-single=100 > kernel/linux/kni/Makefile:MODULE_CFLAGS += -I$(SRCDIR) --param max-inline-insns-single=50 > [dmarchan@dmarchan dpdk]$ git blame origin/master -- kernel/linux/igb_uio/Makefile |grep max-inline-insns-single > 13dc56a6 lib/librte_eal/linuxapp/igb_uio/Makefile (Intel            2012-12-20 00:00:00 +0100 15) MODULE_CFLAGS += -I$(SRCDIR) --param max-inline-insns-single=100 > [dmarchan@dmarchan dpdk]$ git blame origin/master -- kernel/linux/kni/Makefile |grep max-inline-insns-single > 3fc5ca2f lib/librte_eal/linuxapp/kni/Makefile (Intel            2012-12-20 00:00:00 +0100 14) MODULE_CFLAGS += -I$(SRCDIR) --param max-inline-insns-single=50 > > Is there a valid reason to keep this? > 1: https://github.com/openvswitch/ovs/blob/master/.travis/linux-build.sh#L81 Hi, David. I don't know the reason for these in OVS travis config, But we don't need to know them, actually. I have a patch to drop all the kernel related stuff from the DPDK build in OVS Travis checks, just didn't send it yet. Will send soon, probably. If (or when) OVS Travis will migrate to meson, I'd suggest to just use '-Denable_kmods=false'. Best regards, Ilya Maximets.