DPDK patches and discussions
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: "Ferruh Yigit" <ferruh.yigit@amd.com>,
	"Niklas Söderlund" <niklas.soderlund@corigine.com>,
	"Xueming(Steven) Li" <xuemingl@nvidia.com>
Cc: Chaoyong He <chaoyong.he@corigine.com>,
	dev@dpdk.org, Luca Boccassi <bluca@debian.org>,
	oss-drivers@corigine.com, Peng Zhang <peng.zhang@corigine.com>,
	jin.liu@corigine.com, stable@dpdk.org
Subject: Re: [PATCH] net/nfp: support 48-bit DMA address for firmware with NFDk
Date: Thu, 16 Feb 2023 10:28:34 +0000	[thread overview]
Message-ID: <a629b775-847b-9c2b-ce58-b0de5fc537bc@redhat.com> (raw)
In-Reply-To: <1856a555-e7d5-6dfa-6cf0-c4e170b81482@amd.com>

On 15/02/2023 18:28, Ferruh Yigit wrote:
> On 2/15/2023 5:47 PM, Niklas Söderlund wrote:
>> Hi Ferruh,
>>
>> Thanks for your continues effort in dealing with NFP patches.
>>
>> On 2023-02-15 13:42:01 +0000, Ferruh Yigit wrote:
>>> On 2/8/2023 9:15 AM, Chaoyong He wrote:
>>>> From: Peng Zhang <peng.zhang@corigine.com>
>>>>
>>>> 48-bit DMA address is supported in the firmware with NFDk, so enable
>>>> this feature in PMD now. But the firmware with NFD3 still just
>>>> support 40-bit DMA address.
>>>>
>>>> RX free list descriptor, used by both NFD3 and NFDk, is also modified
>>>> to support 48-bit DMA address. That's OK because the top bits is always
>>>> set to 0 when assigned with 40-bit DMA address.
>>>>
>>>> Fixes: c73dced48c8c ("net/nfp: add NFDk Tx")
>>>> Cc: jin.liu@corigine.com
>>>> Cc: stable@dpdk.org
>>>>
>>>
>>> Why a backport is requested? As far as I understand this is not fixing
>>> anything but extending device capability. Is this a fix?
>>
>> I agree this is a bit of a grey zone. We reasoned this was a fix as we
>> should have done this from the start in the commit that added support
>> for NFDk. Are you OK moving forward with this as a fix or would you
>> prefer we resubmit without the request to backport?
>>
> 
> I am not sure, is this change have any potential to change behavior for
> existing users?
> Like if one of your user is using 22.11.1 release, and if this patch
> backported to next LTS version, 22.11.2, will user notice any difference?
> 
> 
> @Luca, @Kevin, what is your comment as LTS maintainers?
> 

A bit difficult to know. If NFDk is not practicably usable without it, 
then it could be considered a fix. If it's just extending to add 
nice-to-have functionality then probably it is not a fix.

It would need to ensure that it is tested on 22.11 branch and there are 
no regressions. It is only relevant to DPDK 22.11 LTS so Cc Xueming who 
will ultimately decide.

A guide below on some things to consider for this type of backport is here:
http://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be-backported

>>>
>>>> Signed-off-by: Peng Zhang <peng.zhang@corigine.com>
>>>> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
>>>> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
>>>
>>
> 


  reply	other threads:[~2023-02-16 10:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-08  9:15 Chaoyong He
2023-02-15 13:42 ` Ferruh Yigit
2023-02-15 17:47   ` Niklas Söderlund
2023-02-15 18:28     ` Ferruh Yigit
2023-02-16 10:28       ` Kevin Traynor [this message]
2023-02-16 10:37         ` Niklas Söderlund
2023-02-16 10:41           ` Chaoyong He
2023-02-16 10:55             ` Niklas Soderlund
2023-02-16 10:59             ` Ferruh Yigit
2023-02-16 11:11               ` Nole Zhang
2023-02-16 11:17                 ` Ferruh Yigit
2023-02-20  9:02 ` [PATCH v2] net/nfp: fix 48-bit DMA address support for NFDk Chaoyong He
2023-02-20 14:02   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a629b775-847b-9c2b-ce58-b0de5fc537bc@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=bluca@debian.org \
    --cc=chaoyong.he@corigine.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=jin.liu@corigine.com \
    --cc=niklas.soderlund@corigine.com \
    --cc=oss-drivers@corigine.com \
    --cc=peng.zhang@corigine.com \
    --cc=stable@dpdk.org \
    --cc=xuemingl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).