From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6713BA056D; Mon, 21 Nov 2022 23:57:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 42C1042D3B; Mon, 21 Nov 2022 23:57:34 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2054.outbound.protection.outlook.com [40.107.94.54]) by mails.dpdk.org (Postfix) with ESMTP id A724140DF6 for ; Mon, 21 Nov 2022 23:57:32 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=arFu/hdig0in7tqxMea++AlVYTWWQp9n61eXqjQYpN1tDKrsZ6kkozE6IKKfTdxonAlnUOZw/z/Pnk2Gwi0TOUI5a1z5HdypxqTiw7z2wJiRGDim1u/5HyFpuz0nfUevCjfi9e8YuxPFl5TqGNxWDTPNg+XTAzPS49e0cGC2h3nZaOZbvDObWCbjndR9wO4buLiqcfWuRwxBnvagdz8t1TiOvZ25k7iMon6A6VD/EHnJvftb7fC6Yw6GJ5BpRCyYbSUQHgkhfFvyhbmFgtFAA6uwuD2ywIEgqkLe7KqgFUa74ZwYn6oeQomjfjnANl+CPheHWx07C5LkyAgduZUw7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3LS7G3TUmH0QrxlEnZOzYDJQ0OrPy4DLxTBspfGkD90=; b=ehzaPLlogEXhoFs1sfZhS/hP4vbNZpuTkDqFtvA5C4usi8PZwX+laIW7Pbpch6wIkZym3xq/AkbqQrJuFq+zCrYCsN2S9MvMqUhbbOVjdc5Yrj0a/3WggaCcb/+nw4zaB4e1At/X/Bh57DgNO3IMyAB00D+VDmNTwwRMB0tkCfwseBOCM9gzT4r9NFeBPAf/x69hqzGsealJUxHFCmslhUxrurzRw4I0shlJgZns7np6fdWzBhUl79Fcl0RTvHONVduptRQeIlrm5zul4sXGKfP7dXvwtmrMTl/ljw8kIzbrYU3VHlhPcW9Nuf82ExnStzeEY0qskFeE0O1y1OBczw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3LS7G3TUmH0QrxlEnZOzYDJQ0OrPy4DLxTBspfGkD90=; b=XDWd8xPRwLG4u2N2wOeY5TT9voU99WilAsi+BPoyjdAXc7BK6q1LVtIM42EGpS8xjmHhdmWpDvVEBI5jGfboCNrfsqR6ny/8+FaQ+CpOofQq37pNCIyb86hsIU2Lls/orAB9QtDFcV7PsrQWMtxQP5751jK3sM7wPjy+x2cQvsY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH0PR12MB5042.namprd12.prod.outlook.com (2603:10b6:610:e1::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Mon, 21 Nov 2022 22:57:30 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842%9]) with mapi id 15.20.5834.015; Mon, 21 Nov 2022 22:57:30 +0000 Message-ID: Date: Mon, 21 Nov 2022 22:57:25 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 02/11] net/tap: check if name is null Content-Language: en-US To: Sinan Kaya , Thomas Monjalon Cc: dev@dpdk.org References: <20221121204015.1135573-1-okaya@kernel.org> <20221121204015.1135573-3-okaya@kernel.org> <9023252.CDJkKcVGEf@thomas> <0f1222b5e03b5c7a396f60954686c1b569ed50f9.camel@kernel.org> From: Ferruh Yigit In-Reply-To: <0f1222b5e03b5c7a396f60954686c1b569ed50f9.camel@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0064.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2af::20) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH0PR12MB5042:EE_ X-MS-Office365-Filtering-Correlation-Id: 7bbb8d67-7e04-4d35-1ba7-08dacc13c4b0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vvhVFnGcKnInNSYOJ4ZYQ5QxrBRy1Lqbd67x6hEvuX80pR7XGVulLZYSAUljIQ4H8Gf+K2GhAMJiaYeytKWsGOd81SNShrDZSgtqlvmAd/294VCGUixc9ILkokbEnY879wLWMMMigf/grpWnNF9LKG2yRksGghYJfAJK0YgdA+XhH/nA2qbibjFoN4RICoefAIl9/+A/UJVEAtUR8V2YWmINNmpWGf3CgKYyXVaHU+OVQvu2sVIWFTwmayQO890IF+I2rxIMtBH5nvgTBTFP2p/nkw687VXYyJaQ+0Wn+It5omvgtGHZw08vTPrNPzr72MnKZRpEZeAY1osWY8KvonUVwa3RJAv6N556EFRMwff4gIsa6Lu8xS/FM+soyo/fTLFtkRbVDrTlJ7z2+K39Y3Lbwx6r7DP5i65LsHUaZyZ+Aeo3dzHAHmSC02YYzmBYGE5MX1LQGWIgmbO+oZBlcuyHvhHo66BlgvqQFtYGvbkGLmOp53ndUdFXjbl8Z+m0USxL1mssd+7+92COrCqJotLlFTIS68eXENQJu6ViPsjfjkpcGi0EVRrDD3CdvdyR3PLtETR5x3oA4ewbLqvsKytRS7pLegcEeis6MyEwViBjiqZRedQ6cyVGq0spx2pkXdQEXpcYoRphDe1SZlsM3bbqh1xiZzY3DDQ8EkJY9p3fgVwUWmCsU6fucg9RkjatK+CfXvyLQQ8+AZo6I+99Euc8nsOQ4yuZNgbPS0hd8d2LF6kG+0do3oCSndVvgCfy X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(366004)(39860400002)(136003)(396003)(346002)(451199015)(36756003)(31686004)(38100700002)(41300700001)(44832011)(4001150100001)(4744005)(2906002)(83380400001)(86362001)(31696002)(66476007)(316002)(66556008)(6486002)(66946007)(8676002)(26005)(4326008)(6512007)(966005)(186003)(110136005)(8936002)(5660300002)(478600001)(2616005)(6506007)(53546011)(6666004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QmVOS3FhMTc1eHp2eUROSE1LancrbUJGbWkyeE50dkdIU2xpeXhwa09tM1Y3?= =?utf-8?B?NVkxMjI3eXpWQlpLSThWTnNqK1gwVHdScjVub0VNMDFRRWxQcDkvUUdNL3M2?= =?utf-8?B?ais0WmY3UDNSTEZzUkc2OUN1RzQzU20ydXl1NTdscldPQTNUdlh5UGZlRWRC?= =?utf-8?B?QnhlZkdzYkhwREdVeU5YZVFGeFNKWEtGdVoyVGFiK3hUNWtRcGpseTNsS1BJ?= =?utf-8?B?L2k5d2h1Y2RVYkJhMU9IanRKdkVtcE5FU25wQ3oxa3ZIVFI4V0ZHaVIyZDhv?= =?utf-8?B?TjJCS2tOdVNnZ2R6a1pKOU1oZkt5M29udUJhUmVEenlPeXJvaTF2MmxmR0Fx?= =?utf-8?B?Z0lEbURWcUxNeGtvUzYrUnJkSGYyWjR0cnNTNjMzYy9uVlNQdnFJem52Wmp6?= =?utf-8?B?dUhFckdkWE1USVFKTDJXeEdKcEdITU96L1orMWpzQ1pRaVFjd2RWeFJYWFVp?= =?utf-8?B?Sm52UG43QzlYRHJiYzFJVkZkSkV3bWFQckhVQWR6Uy9nN1p5aThNY1pYdTdi?= =?utf-8?B?RG1JMXZGSi9DQVd3V2ZlTlQ2WVNCMEtLaTd0R2tJWHNSMEE5SFd1UlcrRVND?= =?utf-8?B?UDFnQjF2YmJ1WHY5Y1VTdElWWDEwVm94aU1pUURUaUY5K0JqMnR6NjlnUENS?= =?utf-8?B?RTFaU1JXbmd1bk94RDdkVHdXTXNQOTVXSzB2VTl4eE00QUtwd0FidGU2UjZo?= =?utf-8?B?bFFZdSs0cjM4aUNleE1VcnFaWXNhZlQzNURQdFUybE1CNU9OQlZJSm9nYzNV?= =?utf-8?B?N3V5TFVQb0w5Umh6UzVuYW9Zd2prN1I4T3BqRlI0aERrbC8vNXMwYlkyM1dD?= =?utf-8?B?WlFQc1dCVXpnbVBBTVByWkloNGtHQWI1cFZ0Z0JWQXErdnZzUXY4VkE3NEtk?= =?utf-8?B?OVhMS0hPdlVUSnZ0a1liUjJ3czFHNFRMWWxiZ1ZOdno5cWlpdzMzelpBRkcy?= =?utf-8?B?VVB6THNTNnBBbEZPeTQxcnREZ1dhUnBCQ3oxK3hxYm1IVER1UFVUUFdnZHl2?= =?utf-8?B?VzYyRnAxY3hrbXQrZFl2eE52YkNERDlpQ3U0ZGpUZ1FiMnZQSVVyQUR5Nkc5?= =?utf-8?B?ZUdKNWw5VU9pOGRwSThlbUQ2cEVackxvRkhCc1BtWjdkNDl4VWRmYU41N3hG?= =?utf-8?B?ZVpJeHRYTXFWbVh0S2MxSkdFamh3bnA4aHVpS2c5NmdFZ3grYVl1RkFVZzFQ?= =?utf-8?B?Uno2MHM0bjBrSDRkTmNwdmI2YUQrcytyOWtlclQ2QjQ3SWRRaEYvODNLVktj?= =?utf-8?B?M0FjWVhZUDF6MWFUUnBqYVMyR0svMlJKNkpCV1pVNnhRVTE5TG1rY2Z6eTd1?= =?utf-8?B?VzFYRU5UbFBwRnQ1OTVvODhJb1p6OWYxT3QxOExhRCtHV2FISEEvMVRjT2dH?= =?utf-8?B?VUxIcUZsR2xGbEhIak5oTXlMQ1JBVHArSnkwNjVMYUpNWDYrL1FFVWZ5RXVm?= =?utf-8?B?bVhzM2laUm5GNjE0SEpzMzJTbzcrck5jYjFmOGZ1U3g5ZGV2ZzlQaFM5NFli?= =?utf-8?B?TjZJb3FtN3l0M0lzV1lnNDF3TXFGb1cvUWZsWXlxdXlYM2ZENlhBQzJxdkVB?= =?utf-8?B?cCtzMVVxWGs3VW9MYmVzdTZ0d2xPajNSRHZ4eWdGOS9CT09Rei9LS3YxRzZG?= =?utf-8?B?SklHZDNlU3pZMGllVGI3eVBnK29oV3B2RGlwb1haRHc0UmZMa2taZkNkMGU1?= =?utf-8?B?UitwVGtVQXBpenJObXVoY1BOQUViUU8vTmg1N1BxcTlHbzJVODFKVTF6VDBm?= =?utf-8?B?Z3FBZmsxNUl4a0RHdTdNUGQ5OGdMdzhNS0JQN3pidTFPU0x3RXhDYk5XM1BX?= =?utf-8?B?V2d1RTlOUmlNekZiM2xQU21WbWV0WHJNSWZBMUhsMTlYOCtIUjE1WVpacmps?= =?utf-8?B?TW5DVi9RWXdNZXVCVXFUUWtPcDBpREdkUi83NUt5dUNGdmkvZWRLZlR6Z25i?= =?utf-8?B?YlJocDRGU3I5Zm9Nd21qNjBodnJzNmJkK2dIWnpBS0o1RVpQU29wNzdNdFdn?= =?utf-8?B?L0x2YU1BdkkyR0h3SG1yRlpqNC9HS0x2NyttcGZUK1p5R00ycTJoOFpJRDMv?= =?utf-8?B?Z2FSZWhYZVREeXhxZTNaQ0tGM2lvbWVIbnNBc1A2YWtsN0ltek15Zk15U3NM?= =?utf-8?Q?NwFmt8GIm5aLfy3feVc1Nui3N?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7bbb8d67-7e04-4d35-1ba7-08dacc13c4b0 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 22:57:30.4552 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: j3gMibfbM6bkzWU4+incTTXiwXgGfS56uSqUZ8VF7NEwEpjqEu3siTzzmvBfJkbg X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5042 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/21/2022 10:03 PM, Sinan Kaya wrote: > On Mon, 2022-11-21 at 22:41 +0100, Thomas Monjalon wrote: >> 21/11/2022 21:40, >> okaya@kernel.org >> >> : >>> --- a/drivers/net/tap/rte_eth_tap.c >>> +++ b/drivers/net/tap/rte_eth_tap.c >>> @@ -2340,6 +2340,10 @@ rte_pmd_tun_probe(struct rte_vdev_device *dev) >>> struct rte_eth_dev *eth_dev; >>> >>> name = rte_vdev_device_name(dev); >>> + if (!name) { >> >> Please it is preferred to check against NULL, >> because name is not a boolean, thanks. >> I know it's longer but it is more explicit. > > Sure, I can do that. Getting used to dpdk coding style. I wasn't sure > what to do with braces on single line too. At least, I got a warning on > that too. > DPDK coding convention is documented if it helps: https://doc.dpdk.org/guides/contributing/coding_style.html >> >> Thanks for the fixes in this series. >> >> > > Cheers >