From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Ray Kinsella <mdr@ashroe.eu>, Haiyue Wang <haiyue.wang@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Xiao Wang <xiao.w.wang@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Jerin Jacob <jerinj@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Chenbo Xia <chenbo.xia@intel.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: remove legacy Rx descriptor done API
Date: Mon, 11 Oct 2021 16:22:58 +0300 [thread overview]
Message-ID: <a62cf006-2721-8eda-f11d-96250fd9858d@oktetlabs.ru> (raw)
In-Reply-To: <5502102.FQXPWbTtxv@thomas>
On 10/5/21 10:16 PM, Thomas Monjalon wrote:
> 28/09/2021 17:48, Andrew Rybchenko:
>> rte_eth_rx_descriptor_status() should be used as a replacement.
>>
>> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> [...]
>> @@ -126,6 +126,10 @@ Removed Items
>> blacklist/whitelist are removed. Users must use the new
>> block/allow list arguments.
>>
>> +* ethdev: Removed ``rx_descriptor_done`` dev_ops and
>> + ``rte_eth_rx_descriptor_done``. Existing ``rte_eth_rx_descriptor_status``
>> + APIs can be used as a replacement.
>
> I suggest this wording:
>
> ethdev: Removed ``rte_eth_rx_descriptor_done`` API function and its driver callback.
> It is replaced by the more complete function ``rte_eth_rx_descriptor_status``.
Thanks, sounds better to me too. Will be in v2.
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>
next prev parent reply other threads:[~2021-10-11 13:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 15:48 Andrew Rybchenko
2021-09-30 13:26 ` Ferruh Yigit
2021-10-05 19:16 ` Thomas Monjalon
2021-10-11 13:22 ` Andrew Rybchenko [this message]
2021-10-06 8:51 ` Ferruh Yigit
2021-10-06 9:09 ` Andrew Rybchenko
2021-10-11 13:23 ` Andrew Rybchenko
2021-10-11 13:24 ` [dpdk-dev] [PATCH v2] " Andrew Rybchenko
2021-10-11 14:47 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a62cf006-2721-8eda-f11d-96250fd9858d@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=beilei.xing@intel.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=haiyue.wang@intel.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=maxime.coquelin@redhat.com \
--cc=mdr@ashroe.eu \
--cc=ndabilpuram@marvell.com \
--cc=qi.z.zhang@intel.com \
--cc=thomas@monjalon.net \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).