From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2C81EA034F;
	Mon, 11 Oct 2021 15:23:00 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C33EB40142;
	Mon, 11 Oct 2021 15:22:59 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 250EF4003C
 for <dev@dpdk.org>; Mon, 11 Oct 2021 15:22:59 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id A2F2F7F567;
 Mon, 11 Oct 2021 16:22:58 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru A2F2F7F567
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1633958578;
 bh=vuXmt3ozDa5heqVj2VvJfDNSJLqYo4PS37w1/GVOu/E=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=TQJBYFKkHDY4pMVye+uCIRiwz7iWS1AWkdro+53mlRATehjAXMZPFCkxs932gGGpp
 yK/JQSprTPh/fpr0L+1/rV5+Y1VBW1DFk4rfeJgsJ5WJowUSsyYqygILbdWQ4/25PU
 TDhJ0BEo+08M0CV3FpF2qTQyUBS0R81RZPGkmE0Q=
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Ray Kinsella <mdr@ashroe.eu>, Haiyue Wang <haiyue.wang@intel.com>,
 Qi Zhang <qi.z.zhang@intel.com>, Xiao Wang <xiao.w.wang@intel.com>,
 Beilei Xing <beilei.xing@intel.com>, Jerin Jacob <jerinj@marvell.com>,
 Nithin Dabilpuram <ndabilpuram@marvell.com>,
 Kiran Kumar K <kirankumark@marvell.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>,
 Chenbo Xia <chenbo.xia@intel.com>, Ferruh Yigit <ferruh.yigit@intel.com>,
 dev@dpdk.org
References: <20210928154856.1015020-1-andrew.rybchenko@oktetlabs.ru>
 <5502102.FQXPWbTtxv@thomas>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <a62cf006-2721-8eda-f11d-96250fd9858d@oktetlabs.ru>
Date: Mon, 11 Oct 2021 16:22:58 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <5502102.FQXPWbTtxv@thomas>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] ethdev: remove legacy Rx descriptor done API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/5/21 10:16 PM, Thomas Monjalon wrote:
> 28/09/2021 17:48, Andrew Rybchenko:
>> rte_eth_rx_descriptor_status() should be used as a replacement.
>>
>> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> [...]
>> @@ -126,6 +126,10 @@ Removed Items
>>    blacklist/whitelist are removed. Users must use the new
>>    block/allow list arguments.
>>  
>> +* ethdev: Removed ``rx_descriptor_done`` dev_ops and
>> +  ``rte_eth_rx_descriptor_done``.  Existing ``rte_eth_rx_descriptor_status``
>> +  APIs can be used as a replacement.
> 
> I suggest this wording:
> 
> ethdev: Removed ``rte_eth_rx_descriptor_done`` API function and its driver callback.
> It is replaced by the more complete function ``rte_eth_rx_descriptor_status``.

Thanks, sounds better to me too. Will be in v2.

> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>