[PATCH v1 0/2] app/bbdev: minor application updates

[PATCH v1 0/2] app/bbdev: minor application updates

[Nicolas Chautru]

Hi Maxime, all,

Adding a couple of changes to the built in test application for bbdev
test on top of previous changes.

Thanks,
Nic

Nicolas Chautru (2):
  app/bbdev: add capture of queue dump
  app/bbdev: add support for interrupt disable

 app/test-bbdev/test_bbdev_perf.c | 40 ++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

-- 
2.34.1

[PATCH v1 1/2] app/bbdev: add capture of queue dump

[Nicolas Chautru]

Capturing additional queue dump information in the
bbdev-test application using the api introduced earlier.

Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
---
 app/test-bbdev/test_bbdev_perf.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index 9be360b225..405c22de44 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -111,6 +111,8 @@ static uint32_t ldpc_cap_flags;
 /* FFT window width predefined on device and on vector. */
 static int fft_window_width_dev;
 
+bool dump_ops = true;
+
 /* Represents tested active devices */
 static struct active_device {
 	const char *driver_name;
@@ -3109,6 +3111,20 @@ run_test_case_on_device(test_case_function *test_case_func, uint8_t dev_id,
 	/* Run test case function */
 	t_ret = test_case_func(ad, op_params);
 
+	if (dump_ops) {
+		/* Dump queue information in local file. */
+		static FILE *fd;
+		fd = fopen("./dump_bbdev_queue_ops.txt", "w");
+		if (fd == NULL) {
+			printf("Open dump file error.\n");
+			return -1;
+		}
+		rte_bbdev_queue_ops_dump(ad->dev_id, ad->queue_ids[i], fd);
+		fclose(fd);
+		/* Run it once only. */
+		dump_ops = false;
+	}
+
 	/* Free active device resources and return */
 	free_buffers(ad, op_params);
 	return t_ret;
-- 
2.34.1

[PATCH v1 2/2] app/bbdev: add support for interrupt disable

[Nicolas Chautru]

Adding support for calling the interrupt disable api
for coverage.

Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
---
 app/test-bbdev/test_bbdev_perf.c | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index 405c22de44..6ee1ca34b2 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -3535,6 +3535,10 @@ throughput_intr_lcore_ldpc_dec(void *arg)
 			rte_atomic_store_explicit(&tp->nb_dequeued, 0, rte_memory_order_relaxed);
 	}
 
+	TEST_ASSERT_SUCCESS(rte_bbdev_queue_intr_disable(tp->dev_id, queue_id),
+			"Failed to disable interrupts for dev: %u, queue_id: %u",
+			tp->dev_id, queue_id);
+
 	return TEST_SUCCESS;
 }
 
@@ -3629,6 +3633,10 @@ throughput_intr_lcore_dec(void *arg)
 			rte_atomic_store_explicit(&tp->nb_dequeued, 0, rte_memory_order_relaxed);
 	}
 
+	TEST_ASSERT_SUCCESS(rte_bbdev_queue_intr_disable(tp->dev_id, queue_id),
+			"Failed to disable interrupts for dev: %u, queue_id: %u",
+			tp->dev_id, queue_id);
+
 	return TEST_SUCCESS;
 }
 
@@ -3718,6 +3726,10 @@ throughput_intr_lcore_enc(void *arg)
 			rte_atomic_store_explicit(&tp->nb_dequeued, 0, rte_memory_order_relaxed);
 	}
 
+	TEST_ASSERT_SUCCESS(rte_bbdev_queue_intr_disable(tp->dev_id, queue_id),
+			"Failed to disable interrupts for dev: %u, queue_id: %u",
+			tp->dev_id, queue_id);
+
 	return TEST_SUCCESS;
 }
 
@@ -3810,6 +3822,10 @@ throughput_intr_lcore_ldpc_enc(void *arg)
 			rte_atomic_store_explicit(&tp->nb_dequeued, 0, rte_memory_order_relaxed);
 	}
 
+	TEST_ASSERT_SUCCESS(rte_bbdev_queue_intr_disable(tp->dev_id, queue_id),
+			"Failed to disable interrupts for dev: %u, queue_id: %u",
+			tp->dev_id, queue_id);
+
 	return TEST_SUCCESS;
 }
 
@@ -3901,6 +3917,10 @@ throughput_intr_lcore_fft(void *arg)
 			rte_atomic_store_explicit(&tp->nb_dequeued, 0, rte_memory_order_relaxed);
 	}
 
+	TEST_ASSERT_SUCCESS(rte_bbdev_queue_intr_disable(tp->dev_id, queue_id),
+			"Failed to disable interrupts for dev: %u, queue_id: %u",
+			tp->dev_id, queue_id);
+
 	return TEST_SUCCESS;
 }
 
@@ -3986,6 +4006,10 @@ throughput_intr_lcore_mldts(void *arg)
 			rte_atomic_store_explicit(&tp->nb_dequeued, 0, rte_memory_order_relaxed);
 	}
 
+	TEST_ASSERT_SUCCESS(rte_bbdev_queue_intr_disable(tp->dev_id, queue_id),
+			"Failed to disable interrupts for dev: %u, queue_id: %u",
+			tp->dev_id, queue_id);
+
 	return TEST_SUCCESS;
 }
 
-- 
2.34.1

Re: [PATCH v1 1/2] app/bbdev: add capture of queue dump

[Hemant Agrawal]

Reviewed-by:  Hemant Agrawal <hemant.agrawal@nxp.com>

On 25-10-2024 23:27, Nicolas Chautru wrote:
> Capturing additional queue dump information in the
> bbdev-test application using the api introduced earlier.
>
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
>   app/test-bbdev/test_bbdev_perf.c | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
>
> diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
> index 9be360b225..405c22de44 100644
> --- a/app/test-bbdev/test_bbdev_perf.c
> +++ b/app/test-bbdev/test_bbdev_perf.c
> @@ -111,6 +111,8 @@ static uint32_t ldpc_cap_flags;
>   /* FFT window width predefined on device and on vector. */
>   static int fft_window_width_dev;
>   
> +bool dump_ops = true;
> +
>   /* Represents tested active devices */
>   static struct active_device {
>   	const char *driver_name;
> @@ -3109,6 +3111,20 @@ run_test_case_on_device(test_case_function *test_case_func, uint8_t dev_id,
>   	/* Run test case function */
>   	t_ret = test_case_func(ad, op_params);
>   
> +	if (dump_ops) {
> +		/* Dump queue information in local file. */
> +		static FILE *fd;
> +		fd = fopen("./dump_bbdev_queue_ops.txt", "w");
> +		if (fd == NULL) {
> +			printf("Open dump file error.\n");
> +			return -1;
> +		}
> +		rte_bbdev_queue_ops_dump(ad->dev_id, ad->queue_ids[i], fd);
> +		fclose(fd);
> +		/* Run it once only. */
> +		dump_ops = false;
> +	}
> +
>   	/* Free active device resources and return */
>   	free_buffers(ad, op_params);
>   	return t_ret;

Re: [PATCH v1 2/2] app/bbdev: add support for interrupt disable

[Hemant Agrawal]

Reviewed-by:  Hemant Agrawal <hemant.agrawal@nxp.com>

On 25-10-2024 23:27, Nicolas Chautru wrote:
> Adding support for calling the interrupt disable api
> for coverage.
>
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
>   app/test-bbdev/test_bbdev_perf.c | 24 ++++++++++++++++++++++++
>   1 file changed, 24 insertions(+)
>
> diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
> index 405c22de44..6ee1ca34b2 100644
> --- a/app/test-bbdev/test_bbdev_perf.c
> +++ b/app/test-bbdev/test_bbdev_perf.c
> @@ -3535,6 +3535,10 @@ throughput_intr_lcore_ldpc_dec(void *arg)
>   			rte_atomic_store_explicit(&tp->nb_dequeued, 0, rte_memory_order_relaxed);
>   	}
>   
> +	TEST_ASSERT_SUCCESS(rte_bbdev_queue_intr_disable(tp->dev_id, queue_id),
> +			"Failed to disable interrupts for dev: %u, queue_id: %u",
> +			tp->dev_id, queue_id);
> +
>   	return TEST_SUCCESS;
>   }
>   
> @@ -3629,6 +3633,10 @@ throughput_intr_lcore_dec(void *arg)
>   			rte_atomic_store_explicit(&tp->nb_dequeued, 0, rte_memory_order_relaxed);
>   	}
>   
> +	TEST_ASSERT_SUCCESS(rte_bbdev_queue_intr_disable(tp->dev_id, queue_id),
> +			"Failed to disable interrupts for dev: %u, queue_id: %u",
> +			tp->dev_id, queue_id);
> +
>   	return TEST_SUCCESS;
>   }
>   
> @@ -3718,6 +3726,10 @@ throughput_intr_lcore_enc(void *arg)
>   			rte_atomic_store_explicit(&tp->nb_dequeued, 0, rte_memory_order_relaxed);
>   	}
>   
> +	TEST_ASSERT_SUCCESS(rte_bbdev_queue_intr_disable(tp->dev_id, queue_id),
> +			"Failed to disable interrupts for dev: %u, queue_id: %u",
> +			tp->dev_id, queue_id);
> +
>   	return TEST_SUCCESS;
>   }
>   
> @@ -3810,6 +3822,10 @@ throughput_intr_lcore_ldpc_enc(void *arg)
>   			rte_atomic_store_explicit(&tp->nb_dequeued, 0, rte_memory_order_relaxed);
>   	}
>   
> +	TEST_ASSERT_SUCCESS(rte_bbdev_queue_intr_disable(tp->dev_id, queue_id),
> +			"Failed to disable interrupts for dev: %u, queue_id: %u",
> +			tp->dev_id, queue_id);
> +
>   	return TEST_SUCCESS;
>   }
>   
> @@ -3901,6 +3917,10 @@ throughput_intr_lcore_fft(void *arg)
>   			rte_atomic_store_explicit(&tp->nb_dequeued, 0, rte_memory_order_relaxed);
>   	}
>   
> +	TEST_ASSERT_SUCCESS(rte_bbdev_queue_intr_disable(tp->dev_id, queue_id),
> +			"Failed to disable interrupts for dev: %u, queue_id: %u",
> +			tp->dev_id, queue_id);
> +
>   	return TEST_SUCCESS;
>   }
>   
> @@ -3986,6 +4006,10 @@ throughput_intr_lcore_mldts(void *arg)
>   			rte_atomic_store_explicit(&tp->nb_dequeued, 0, rte_memory_order_relaxed);
>   	}
>   
> +	TEST_ASSERT_SUCCESS(rte_bbdev_queue_intr_disable(tp->dev_id, queue_id),
> +			"Failed to disable interrupts for dev: %u, queue_id: %u",
> +			tp->dev_id, queue_id);
> +
>   	return TEST_SUCCESS;
>   }
>   

Re: [PATCH v1 1/2] app/bbdev: add capture of queue dump

[Maxime Coquelin]

On 10/25/24 19:57, Nicolas Chautru wrote:
> Capturing additional queue dump information in the
> bbdev-test application using the api introduced earlier.
> 
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
>   app/test-bbdev/test_bbdev_perf.c | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
> 
> diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
> index 9be360b225..405c22de44 100644
> --- a/app/test-bbdev/test_bbdev_perf.c
> +++ b/app/test-bbdev/test_bbdev_perf.c
> @@ -111,6 +111,8 @@ static uint32_t ldpc_cap_flags;
>   /* FFT window width predefined on device and on vector. */
>   static int fft_window_width_dev;
>   
> +bool dump_ops = true;
> +
>   /* Represents tested active devices */
>   static struct active_device {
>   	const char *driver_name;
> @@ -3109,6 +3111,20 @@ run_test_case_on_device(test_case_function *test_case_func, uint8_t dev_id,
>   	/* Run test case function */
>   	t_ret = test_case_func(ad, op_params);
>   
> +	if (dump_ops) {
> +		/* Dump queue information in local file. */
> +		static FILE *fd;
> +		fd = fopen("./dump_bbdev_queue_ops.txt", "w");
> +		if (fd == NULL) {
> +			printf("Open dump file error.\n");
> +			return -1;
> +		}
> +		rte_bbdev_queue_ops_dump(ad->dev_id, ad->queue_ids[i], fd);
> +		fclose(fd);
> +		/* Run it once only. */
> +		dump_ops = false;
> +	}
> +
>   	/* Free active device resources and return */
>   	free_buffers(ad, op_params);
>   	return t_ret;

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime

Re: [PATCH v1 2/2] app/bbdev: add support for interrupt disable

[Maxime Coquelin]

On 10/25/24 19:57, Nicolas Chautru wrote:
> Adding support for calling the interrupt disable api
> for coverage.
> 
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
>   app/test-bbdev/test_bbdev_perf.c | 24 ++++++++++++++++++++++++
>   1 file changed, 24 insertions(+)
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime

Re: [PATCH v1 0/2] app/bbdev: minor application updates

[Maxime Coquelin]

On 10/25/24 19:57, Nicolas Chautru wrote:
> Hi Maxime, all,
> 
> Adding a couple of changes to the built in test application for bbdev
> test on top of previous changes.
> 
> Thanks,
> Nic
> 
> Nicolas Chautru (2):
>    app/bbdev: add capture of queue dump
>    app/bbdev: add support for interrupt disable
> 
>   app/test-bbdev/test_bbdev_perf.c | 40 ++++++++++++++++++++++++++++++++
>   1 file changed, 40 insertions(+)
> 

Applied to next-baseband/for-main

Thanks,
Maxime